refactor(tests): use assert_v as namespace for test constants

Author: mydearxym

test/groupher_server_web/mutation/cms/job_test.exs

@@ -98,13 +98,13 @@ defmodule GroupherServer.Test.Mutation.Job do
       user_conn = simu_conn(:user, user)
 
       {:ok, community} = db_insert(:community)
-      job_attr = mock_attrs(:job, %{body: xss_string()})
+      job_attr = mock_attrs(:job, %{body: assert_v(:xss_string)})
 
       variables = job_attr |> Map.merge(%{communityId: community.id}) |> camelize_map_key
       created = user_conn |> mutation_result(@create_job_query, variables, "createJob")
       {:ok, job} = ORM.find(CMS.Job, created["id"])
 
-      assert job.body == xss_safe_string()
+      assert job.body == assert_v(:xss_safe_string)
     end
 
     test "can create job with tags" do

test/groupher_server_web/mutation/cms/post_comment_test.exs

@@ -50,13 +50,19 @@ defmodule GroupherServer.Test.Mutation.PostComment do
 
     @tag :wip
     test "xss comment should be escaped", ~m(user_conn community post)a do
-      variables = %{community: community.raw, thread: "POST", id: post.id, body: xss_string()}
+      variables = %{
+        community: community.raw,
+        thread: "POST",
+        id: post.id,
+        body: assert_v(:xss_string)
+      }
+
       created = user_conn |> mutation_result(@create_comment_query, variables, "createComment")
 
       {:ok, found} = ORM.find(CMS.PostComment, created["id"])
 
       assert created["id"] == to_string(found.id)
-      assert created["body"] == xss_safe_string()
+      assert created["body"] == assert_v(:xss_safe_string)
     end
 
     test "guest user create comment fails", ~m(guest_conn post community)a do

test/groupher_server_web/mutation/cms/post_test.exs

@@ -69,13 +69,13 @@ defmodule GroupherServer.Test.Mutation.Post do
       user_conn = simu_conn(:user, user)
 
       {:ok, community} = db_insert(:community)
-      post_attr = mock_attrs(:post, %{body: xss_string()})
+      post_attr = mock_attrs(:post, %{body: assert_v(:xss_string)})
 
       variables = post_attr |> Map.merge(%{communityId: community.id})
       created = user_conn |> mutation_result(@create_post_query, variables, "createPost")
       {:ok, post} = ORM.find(CMS.Post, created["id"])
 
-      assert post.body == xss_safe_string()
+      assert post.body == assert_v(:xss_safe_string)
     end
 
     # NOTE: this test is IMPORTANT, cause json_codec: Jason in router will cause

test/groupher_server_web/mutation/cms/repo_test.exs

@@ -160,13 +160,13 @@ defmodule GroupherServer.Test.Mutation.Repo do
       user_conn = simu_conn(:user, user)
 
       {:ok, community} = db_insert(:community)
-      repo_attr = mock_attrs(:repo, %{readme: xss_string()})
+      repo_attr = mock_attrs(:repo, %{readme: assert_v(:xss_string)})
 
       variables = repo_attr |> Map.merge(%{communityId: community.id}) |> camelize_map_key
       created = user_conn |> mutation_result(@create_repo_query, variables, "createRepo")
       {:ok, repo} = ORM.find(CMS.Repo, created["id"])
 
-      assert repo.readme == xss_safe_string()
+      assert repo.readme == assert_v(:xss_safe_string)
     end
 
     test "unauth user update git-repo fails", ~m(user_conn guest_conn repo)a do

test/groupher_server_web/query/accounts/account_test.exs

@@ -186,7 +186,7 @@ defmodule GroupherServer.Test.Query.Account.Basic do
     """
     test "guest user can get subscrubed communities list and count", ~m(guest_conn user)a do
       variables = %{login: user.login}
-      {:ok, communities} = db_insert_multi(:community, page_size())
+      {:ok, communities} = db_insert_multi(:community, assert_v(:page_size))
 
       Enum.each(
         communities,
@@ -205,12 +205,12 @@ defmodule GroupherServer.Test.Query.Account.Basic do
       assert subscribed_communities |> Enum.any?(&(&1["id"] == to_string(community_2.id)))
       assert subscribed_communities |> Enum.any?(&(&1["id"] == to_string(community_3.id)))
       assert subscribed_communities |> Enum.any?(&(&1["id"] == to_string(community_x.id)))
-      assert subscribed_communities_count == page_size()
+      assert subscribed_communities_count == assert_v(:page_size)
     end
 
     test "guest user can get subscrubed community list by index", ~m(guest_conn user)a do
       variables = %{login: user.login}
-      {:ok, communities} = db_insert_multi(:community, page_size())
+      {:ok, communities} = db_insert_multi(:community, assert_v(:page_size))
 
       Enum.each(
         communities,
@@ -247,7 +247,7 @@ defmodule GroupherServer.Test.Query.Account.Basic do
 
     test "guest user can get subscrubed communities count of 20 at most", ~m(guest_conn user)a do
       variables = %{login: user.login}
-      {:ok, communities} = db_insert_multi(:community, page_size() + 1)
+      {:ok, communities} = db_insert_multi(:community, assert_v(:page_size) + 1)
 
       Enum.each(
         communities,
@@ -257,8 +257,8 @@ defmodule GroupherServer.Test.Query.Account.Basic do
       results = guest_conn |> query_result(@query, variables, "user")
       subscribed_communities = results["subscribedCommunities"]
 
-      assert subscribed_communities["totalCount"] == page_size() + 1
-      assert subscribed_communities["pageSize"] == page_size()
+      assert subscribed_communities["totalCount"] == assert_v(:page_size) + 1
+      assert subscribed_communities["pageSize"] == assert_v(:page_size)
     end
 
     @query """

test/groupher_server_web/query/cms/cms_test.exs

@@ -443,7 +443,7 @@ defmodule GroupherServer.Test.Query.CMS.Basic do
     """
     test "guest can get editors list and count of a community", ~m(guest_conn community)a do
       title = "chief editor"
-      {:ok, users} = db_insert_multi(:user, inner_page_size())
+      {:ok, users} = db_insert_multi(:user, assert_v(:inner_page_size))
 
       Enum.each(
         users,
@@ -462,7 +462,7 @@ defmodule GroupherServer.Test.Query.CMS.Basic do
       assert editors |> Enum.any?(&(&1["id"] == to_string(user_2.id)))
       assert editors |> Enum.any?(&(&1["id"] == to_string(user_3.id)))
       assert editors |> Enum.any?(&(&1["id"] == to_string(user_x.id)))
-      assert editors_count == inner_page_size()
+      assert editors_count == assert_v(:inner_page_size)
     end
 
     @query """
@@ -508,7 +508,7 @@ defmodule GroupherServer.Test.Query.CMS.Basic do
     }
     """
     test "guest can get subscribers list and count of a community", ~m(guest_conn community)a do
-      {:ok, users} = db_insert_multi(:user, inner_page_size())
+      {:ok, users} = db_insert_multi(:user, assert_v(:inner_page_size))
 
       Enum.each(
         users,
@@ -527,11 +527,11 @@ defmodule GroupherServer.Test.Query.CMS.Basic do
       assert subscribers |> Enum.any?(&(&1["id"] == to_string(user_2.id)))
       assert subscribers |> Enum.any?(&(&1["id"] == to_string(user_3.id)))
       assert subscribers |> Enum.any?(&(&1["id"] == to_string(user_x.id)))
-      assert subscribers_count == inner_page_size()
+      assert subscribers_count == assert_v(:inner_page_size)
     end
 
     test "guest user can get subscribers count of 20 at most", ~m(guest_conn community)a do
-      {:ok, users} = db_insert_multi(:user, inner_page_size() + 1)
+      {:ok, users} = db_insert_multi(:user, assert_v(:inner_page_size) + 1)
 
       Enum.each(
         users,
@@ -542,7 +542,7 @@ defmodule GroupherServer.Test.Query.CMS.Basic do
       results = guest_conn |> query_result(@query, variables, "community")
       subscribers = results["subscribers"]
 
-      assert length(subscribers) == inner_page_size()
+      assert length(subscribers) == assert_v(:inner_page_size)
     end
 
     @query """

test/support/assert_helper.ex

@@ -16,11 +16,15 @@ defmodule GroupherServer.Test.AssertHelper do
   used for non exsit id
   """
   def non_exsit_id, do: 15_982_398_614
-  def inner_page_size, do: @inner_page_size
-  def page_size, do: @page_size
+  # def page_size, do: @page_size
 
-  def xss_string, do: "<script>alert(\"hello,world\")</script>"
-  def xss_safe_string, do: "&lt;script&gt;alert(&quot;hello,world&quot;)&lt;/script&gt;"
+  def assert_v(:inner_page_size), do: @inner_page_size
+  def assert_v(:page_size), do: @page_size
+
+  def assert_v(:xss_string), do: "<script>alert(\"hello,world\")</script>"
+
+  def assert_v(:xss_safe_string),
+    do: "&lt;script&gt;alert(&quot;hello,world&quot;)&lt;/script&gt;"
 
   def is_valid_kv?(obj, key, :list) when is_map(obj) do
     obj = map_key_stringify(obj)