refactor(article-emotions): mutation for post/job

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment_emotion.ex

@@ -56,9 +56,14 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentEmotion do
           user_id: user.id
         }
 
-        {:ok, article_comment_user_emotion} = ORM.find_by(ArticleCommentUserEmotion, target)
-        args = Map.put(target, :"#{emotion}", false)
-        article_comment_user_emotion |> ORM.update(args)
+        case ORM.find_by(ArticleCommentUserEmotion, target) do
+          {:ok, article_comment_user_emotion} ->
+            args = Map.put(target, :"#{emotion}", false)
+            article_comment_user_emotion |> ORM.update(args)
+
+          {:error, _} ->
+            ORM.create(ArticleCommentUserEmotion, target)
+        end
       end)
       |> Multi.run(:query_emotion_states, fn _, _ ->
         query_emotion_states(comment, emotion)

lib/groupher_server/cms/delegates/article_emotion.ex

@@ -55,9 +55,16 @@ defmodule GroupherServer.CMS.Delegate.ArticleEmotion do
           %{recived_user_id: article.author.user_id, user_id: user.id}
           |> Map.put(info.foreign_key, article_id)
 
-        {:ok, article_user_emotion} = ORM.find_by(ArticleUserEmotion, target)
-        args = Map.put(target, :"#{emotion}", false)
-        article_user_emotion |> ORM.update(args)
+        case ORM.find_by(ArticleUserEmotion, target) do
+          {:ok, article_user_emotion} ->
+            args = Map.put(target, :"#{emotion}", false)
+            article_user_emotion |> ORM.update(args)
+
+          {:error, _} ->
+            # args = Map.put(target, :"#{emotion}", false)
+            args = target
+            ORM.create(ArticleUserEmotion, args)
+        end
       end)
       |> Multi.run(:query_emotion_status, fn _, _ ->
         query_emotion_status(thread, article.id, emotion)

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -128,6 +128,14 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     CMS.collected_users(thread, id, filter)
   end
 
+  def emotion_to_article(_root, ~m(id thread emotion)a, %{context: %{cur_user: user}}) do
+    CMS.emotion_to_article(thread, id, emotion, user)
+  end
+
+  def undo_emotion_to_article(_root, ~m(id thread emotion)a, %{context: %{cur_user: user}}) do
+    CMS.undo_emotion_to_article(thread, id, emotion, user)
+  end
+
   # #######################
   # category ..
   # #######################

lib/groupher_server_web/schema/Helper/fields.ex

@@ -7,7 +7,8 @@ defmodule GroupherServerWeb.Schema.Helper.Fields do
   alias GroupherServer.{Accounts, CMS}
 
   @page_size get_config(:general, :page_size)
-  @supported_emotions get_config(:article, :comment_supported_emotions)
+  @supported_emotions get_config(:article, :supported_emotions)
+  @supported_comment_emotions get_config(:article, :comment_supported_emotions)
   @supported_collect_folder_threads Accounts.CollectFolder.supported_threads()
 
   defmacro timestamp_fields do
@@ -192,7 +193,7 @@ defmodule GroupherServerWeb.Schema.Helper.Fields do
   end
 
   @doc """
-  general emotion enum for comments
+  general emotion enum for articles
   #NOTE: xxx_user_logins field is not support for gq-endpoint
   """
   defmacro emotion_enum() do
@@ -205,7 +206,20 @@ defmodule GroupherServerWeb.Schema.Helper.Fields do
   end
 
   @doc """
-  general emotions for comments
+  general emotion enum for comments
+  #NOTE: xxx_user_logins field is not support for gq-endpoint
+  """
+  defmacro comment_emotion_enum() do
+    @supported_comment_emotions
+    |> Enum.map(fn emotion ->
+      quote do
+        value(unquote(:"#{emotion}"))
+      end
+    end)
+  end
+
+  @doc """
+  general emotions for articles
   #NOTE: xxx_user_logins field is not support for gq-endpoint
   """
   defmacro emotion_fields() do
@@ -219,6 +233,21 @@ defmodule GroupherServerWeb.Schema.Helper.Fields do
     end)
   end
 
+  @doc """
+  general emotions for comments
+  #NOTE: xxx_user_logins field is not support for gq-endpoint
+  """
+  defmacro comment_emotion_fields() do
+    @supported_comment_emotions
+    |> Enum.map(fn emotion ->
+      quote do
+        field(unquote(:"#{emotion}_count"), :integer)
+        field(unquote(:"viewer_has_#{emotion}ed"), :boolean)
+        field(unquote(:"latest_#{emotion}_users"), list_of(:simple_user))
+      end
+    end)
+  end
+
   @doc """
   general collect folder meta info
   """

lib/groupher_server_web/schema/Helper/mutations.ex

@@ -100,4 +100,28 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
       end
     end
   end
+
+  defmacro article_emotion_mutation(thread) do
+    quote do
+      @desc unquote("emotion to #{thread}")
+      field unquote(:"emotion_to_#{thread}"), unquote(thread) do
+        arg(:id, non_null(:id))
+        arg(:emotion, non_null(:article_emotion))
+        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
+
+        middleware(M.Authorize, :login)
+        resolve(&R.CMS.emotion_to_article/3)
+      end
+
+      @desc unquote("undo emotion to #{thread}")
+      field unquote(:"undo_emotion_to_#{thread}"), unquote(thread) do
+        arg(:id, non_null(:id))
+        arg(:emotion, non_null(:article_emotion))
+        arg(:thread, unquote(:"#{thread}_thread"), default_value: unquote(thread))
+
+        middleware(M.Authorize, :login)
+        resolve(&R.CMS.undo_emotion_to_article/3)
+      end
+    end
+  end
 end

lib/groupher_server_web/schema/cms/cms_misc.ex

@@ -153,10 +153,11 @@ defmodule GroupherServerWeb.Schema.CMS.Misc do
     value(:grey)
   end
 
+  @desc "emotion options of article"
+  enum(:article_emotion, do: emotion_enum())
+
   @desc "emotion options of comment"
-  enum :article_comment_emotion do
-    emotion_enum()
-  end
+  enum(:article_comment_emotion, do: comment_emotion_enum())
 
   @desc "the filter mode for list comments"
   enum :article_comments_mode do

lib/groupher_server_web/schema/cms/cms_types.ex

@@ -44,6 +44,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:communities, list_of(:community), resolve: dataloader(CMS, :communities))
 
     field(:meta, :article_meta)
+    field(:emotions, :article_emotions)
 
     field :comments, list_of(:comment) do
       arg(:filter, :members_filter)
@@ -99,6 +100,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:communities, list_of(:community), resolve: dataloader(CMS, :communities))
 
     field(:meta, :article_meta)
+    field(:emotions, :article_emotions)
 
     field(:salary, :string)
     field(:exp, :string)
@@ -316,6 +318,10 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
   end
 
   object :article_comment_emotions do
+    comment_emotion_fields()
+  end
+
+  object :article_emotions do
     emotion_fields()
   end
 

lib/groupher_server_web/schema/cms/mutations/job.ex

@@ -75,6 +75,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Job do
     article_pin_mutation(:job)
     article_trash_mutation(:job)
     article_delete_mutation(:job)
+    article_emotion_mutation(:job)
     #############
   end
 end

lib/groupher_server_web/schema/cms/mutations/post.ex

@@ -49,6 +49,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Post do
     article_pin_mutation(:post)
     article_trash_mutation(:post)
     article_delete_mutation(:post)
+    article_emotion_mutation(:post)
     #############
   end
 end

test/groupher_server/cms/emotions/job_emotions_test.exs

@@ -6,7 +6,7 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
   alias Helper.ORM
   alias GroupherServer.CMS
 
-  alias CMS.{Embeds, ArticlerEmotion, ArticleUserEmotion}
+  alias CMS.{Embeds, ArticleUserEmotion}
 
   @default_emotions Embeds.ArticleEmotion.default_emotions()
 
@@ -22,7 +22,7 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
   end
 
   describe "[emotion in paged jobs]" do
-    @tag :wip2
+    @tag :wip3
     test "login user should got viewer has emotioned status",
          ~m(community job_attrs user)a do
       total_count = 10
@@ -61,15 +61,15 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
   end
 
   describe "[basic article emotion]" do
-    @tag :wip2
+    @tag :wip3
     test "job has default emotions after created", ~m(community job_attrs user)a do
       {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
 
       emotions = job.emotions |> Map.from_struct() |> Map.delete(:id)
       assert @default_emotions == emotions
     end
 
-    @tag :wip2
+    @tag :wip3
     test "can make emotion to job", ~m(community job_attrs user user2)a do
       {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
 
@@ -83,7 +83,7 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
       assert user_exist_in?(user2, emotions.latest_downvote_users)
     end
 
-    @tag :wip2
+    @tag :wip3
     test "can undo emotion to job", ~m(community job_attrs user user2)a do
       {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
 
@@ -100,7 +100,7 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
       assert not user_exist_in?(user2, emotions.latest_downvote_users)
     end
 
-    @tag :wip2
+    @tag :wip3
     test "same user make same emotion to same job.", ~m(community job_attrs user)a do
       {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
 
@@ -113,7 +113,7 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
       assert user_exist_in?(user, job.emotions.latest_downvote_users)
     end
 
-    @tag :wip2
+    @tag :wip3
     test "same user same emotion to same job only have one user_emotion record",
          ~m(community job_attrs user)a do
       {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
@@ -131,7 +131,7 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
       assert record.heart
     end
 
-    @tag :wip2
+    @tag :wip3
     test "different user can make same emotions on same job",
          ~m(community job_attrs user user2 user3)a do
       {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
@@ -148,7 +148,7 @@ defmodule GroupherServer.Test.CMS.Emotions.JobEmotions do
       assert user_exist_in?(user3, emotions.latest_beer_users)
     end
 
-    @tag :wip2
+    @tag :wip3
     test "same user can make differcent emotions on same job", ~m(community job_attrs user)a do
       {:ok, job} = CMS.create_content(community, :job, job_attrs, user)