refactor(notify): clean up

Author: mydearxym

test/groupher_server/accounts/mailbx_test.exs

@@ -11,21 +11,11 @@ defmodule GroupherServer.Test.Accounts.Mailbox do
     {:ok, user2} = db_insert(:user)
     {:ok, user3} = db_insert(:user)
 
-    notify_attrs = %{
-      thread: :post,
-      article_id: post.id,
-      title: post.title,
-      action: :upvote,
-      user_id: user.id,
-      read: false
-    }
-
-    {:ok, ~m(post user user2 user3 notify_attrs)a}
+    {:ok, ~m(post user user2 user3)a}
   end
 
   describe "mailbox status" do
-    @tag :wip2
-    test "can get mailbox status", ~m(post user user2 notify_attrs)a do
+    test "can get mailbox status", ~m(post user user2)a do
       notify_attrs = %{
         thread: :post,
         article_id: post.id,

test/groupher_server/delivery/mention_test.exs

@@ -27,7 +27,6 @@ defmodule GroupherServer.Test.Delivery.Mention do
   end
 
   describe "mentions" do
-    @tag :wip2
     test "can get unread mention count of a user", ~m(post user user2 user3 mention_attr)a do
       mention_contents = [
         Map.merge(mention_attr, %{from_user_id: user.id, to_user_id: user3.id})
@@ -45,7 +44,6 @@ defmodule GroupherServer.Test.Delivery.Mention do
       assert count == 2
     end
 
-    @tag :wip2
     test "can batch send mentions", ~m(post user user2 mention_attr)a do
       mention_contents = [
         Map.merge(mention_attr, %{from_user_id: user.id, to_user_id: user2.id})
@@ -61,7 +59,6 @@ defmodule GroupherServer.Test.Delivery.Mention do
       assert mention.user.login == user.login
     end
 
-    @tag :wip2
     test "mention multiable times on same article, will only have one record",
          ~m(post user user2 mention_attr)a do
       mention_contents = [
@@ -79,7 +76,6 @@ defmodule GroupherServer.Test.Delivery.Mention do
       assert result.total_count == 1
     end
 
-    @tag :wip2
     test "if mention before, update with no mention content will not do mention in final",
          ~m(post user user2 user3 mention_attr)a do
       mention_contents = [
@@ -108,7 +104,6 @@ defmodule GroupherServer.Test.Delivery.Mention do
   end
 
   describe "mark read" do
-    @tag :wip
     test "can mark read a mention", ~m(post user user2 mention_attr)a do
       mention_contents = [
         Map.merge(mention_attr, %{from_user_id: user.id, to_user_id: user2.id})
@@ -126,7 +121,6 @@ defmodule GroupherServer.Test.Delivery.Mention do
       assert mention.read
     end
 
-    @tag :wip
     test "can mark multi mention as read", ~m(post user user2 user3 mention_attr)a do
       mention_contents = [
         Map.merge(mention_attr, %{from_user_id: user2.id, to_user_id: user.id})
@@ -155,7 +149,6 @@ defmodule GroupherServer.Test.Delivery.Mention do
       assert mention2.read
     end
 
-    @tag :wip
     test "can mark read all", ~m(post user user2 user3 mention_attr)a do
       mention_contents = [
         Map.merge(mention_attr, %{from_user_id: user2.id, to_user_id: user.id})

test/groupher_server/delivery/notification_test.exs

@@ -80,7 +80,6 @@ defmodule GroupherServer.Test.Delivery.Notification do
   end
 
   describe "notification" do
-    @tag :wip2
     test "can get unread notification count of a user", ~m(user user2 user3 notify_attrs)a do
       {:ok, _} = Delivery.send(:notify, notify_attrs, user2)
       {:ok, _} = Delivery.send(:notify, notify_attrs, user3)
@@ -341,7 +340,6 @@ defmodule GroupherServer.Test.Delivery.Notification do
   end
 
   describe "mark read" do
-    @tag :wip
     test "can mark multi notification as read", ~m(user user2 user3 notify_attrs)a do
       {:ok, notify} = Delivery.send(:notify, notify_attrs, user2)
       move_insert_at_long_ago(notify)
@@ -362,7 +360,6 @@ defmodule GroupherServer.Test.Delivery.Notification do
       assert result.total_count == 2
     end
 
-    @tag :wip
     test "can mark all notification as read", ~m(user user2 user3 notify_attrs)a do
       {:ok, notify} = Delivery.send(:notify, notify_attrs, user2)
       move_insert_at_long_ago(notify)