chore(radar): use article_react_mutations

Author: mydearxym

lib/groupher_server_web/schema/Helper/mutations.ex

@@ -2,29 +2,16 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   @moduledoc """
   general mutations used for articles
 
+  can not dedefine private macros, see:
+  https://github.com/elixir-lang/elixir/issues/3887
+
   e.g:
   in schema/cms/mutation/post.ex
 
   add following:
-  article_upvote_mutation(:post)
-
-  post will have two mutation endpoint:
-
-  upvote_post
-  unto_emotion_post
-
-  same for the job/repo .. article thread
-  """
-  alias GroupherServerWeb.Middleware, as: M
-  alias GroupherServerWeb.Resolvers, as: R
+    article_react_mutations(:post, [:upvote, :pin, :mark_delete, :delete, :emotion, :report, :sink, :lock_comment])
 
-  @doc """
-  e.g:
-
-  turn:
-    article_react_mutations(:radar, [:upvote, :pin, :mark_delete, :delete, :emotion, :report, :sink, :lock_comment])
-
-  into:
+  it will expand as
     article_upvote_mutation(:radar)
     article_pin_mutation(:radar)
     article_mark_delete_mutation(:radar)
@@ -33,6 +20,14 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
     article_report_mutation(:radar)
     article_sink_mutation(:radar)
     article_lock_comment_mutation(:radar)
+
+  same for the job/repo .. article thread
+  """
+  alias GroupherServerWeb.Middleware, as: M
+  alias GroupherServerWeb.Resolvers, as: R
+
+  @doc """
+  add basic mutation reactions to article
   """
   defmacro article_react_mutations(thread, reactions) do
     reactions
@@ -51,7 +46,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   upvote_[thread]
   unto_emotion_[thread]
   """
-  defmacrop article_upvote_mutation(thread) do
+  defmacro article_upvote_mutation(thread) do
     quote do
       @desc unquote("upvote to #{thread}")
       field unquote(:"upvote_#{thread}"), :article do
@@ -81,7 +76,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   pin_[thread]
   unto_pin_[thread]
   """
-  defmacrop article_pin_mutation(thread) do
+  defmacro article_pin_mutation(thread) do
     quote do
       @desc unquote("pin to #{thread}")
       field unquote(:"pin_#{thread}"), unquote(thread) do
@@ -117,7 +112,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   mark_delete_[thread]
   unto_mark_delete_[thread]
   """
-  defmacrop article_mark_delete_mutation(thread) do
+  defmacro article_mark_delete_mutation(thread) do
     quote do
       @desc unquote("mark delete a #{thread} type article, aka soft-delete")
       field unquote(:"mark_delete_#{thread}"), unquote(thread) do
@@ -152,7 +147,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   mark_delete_[thread]
   """
   # TODO: if post belongs to multi communities, unset instead delete
-  defmacrop article_delete_mutation(thread) do
+  defmacro article_delete_mutation(thread) do
     quote do
       @desc unquote("delete a #{thread}, not delete")
       field unquote(:"delete_#{thread}"), unquote(thread) do
@@ -175,7 +170,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   emotion_to_[thread]
   unto_emotion_to_[thread]
   """
-  defmacrop article_emotion_mutation(thread) do
+  defmacro article_emotion_mutation(thread) do
     quote do
       @desc unquote("emotion to #{thread}")
       field unquote(:"emotion_to_#{thread}"), unquote(thread) do
@@ -207,7 +202,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   report_[thread]
   undo_report_[thread]
   """
-  defmacrop article_report_mutation(thread) do
+  defmacro article_report_mutation(thread) do
     quote do
       @desc unquote("report a #{thread}")
       field unquote(:"report_#{thread}"), unquote(thread) do
@@ -239,7 +234,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   sink_[thread]
   undo_sink_[thread]
   """
-  defmacrop article_sink_mutation(thread) do
+  defmacro article_sink_mutation(thread) do
     quote do
       @desc unquote("sink a #{thread}")
       field unquote(:"sink_#{thread}"), :article do
@@ -275,7 +270,7 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
   lock_[thread]_comment
   undo_lock_[thread]_comment
   """
-  defmacrop article_lock_comment_mutation(thread) do
+  defmacro article_lock_comment_mutation(thread) do
     quote do
       @desc unquote("lock comment of a #{thread}")
       field unquote(:"lock_#{thread}_comment"), :article do