refactor(create-article): fix article_tags tests

Author: mydearxym

test/groupher_server/cms/article_tags/blog_tag_test.exs

@@ -12,9 +12,9 @@ defmodule GroupherServer.Test.CMS.ArticleTag.BlogTag do
     article_tag_attrs = mock_attrs(:article_tag)
     article_tag_attrs2 = mock_attrs(:article_tag)
 
-    post_attrs = mock_attrs(:blog)
+    blog_attrs = mock_attrs(:blog)
 
-    {:ok, ~m(user community blog post_attrs article_tag_attrs article_tag_attrs2)a}
+    {:ok, ~m(user community blog blog_attrs article_tag_attrs article_tag_attrs2)a}
   end
 
   describe "[blog tag CURD]" do
@@ -80,30 +80,29 @@ defmodule GroupherServer.Test.CMS.ArticleTag.BlogTag do
 
   describe "[create/update blog with tags]" do
     test "can create blog with exsited article tags",
-         ~m(community user post_attrs article_tag_attrs article_tag_attrs2)a do
+         ~m(community user blog_attrs article_tag_attrs article_tag_attrs2)a do
       {:ok, article_tag} = CMS.create_article_tag(community, :blog, article_tag_attrs, user)
       {:ok, article_tag2} = CMS.create_article_tag(community, :blog, article_tag_attrs2, user)
 
-      post_with_tags =
-        Map.merge(post_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
+      blog_with_tags = Map.merge(blog_attrs, %{article_tags: [article_tag.id, article_tag2.id]})
 
-      {:ok, created} = CMS.create_article(community, :blog, post_with_tags, user)
+      {:ok, created} = CMS.create_article(community, :blog, blog_with_tags, user)
       {:ok, blog} = ORM.find(Blog, created.id, preload: :article_tags)
 
       assert exist_in?(article_tag, blog.article_tags)
       assert exist_in?(article_tag2, blog.article_tags)
     end
 
     test "can not create blog with other community's article tags",
-         ~m(community user post_attrs article_tag_attrs article_tag_attrs2)a do
+         ~m(community user blog_attrs article_tag_attrs article_tag_attrs2)a do
       {:ok, community2} = db_insert(:community)
       {:ok, article_tag} = CMS.create_article_tag(community, :blog, article_tag_attrs, user)
       {:ok, article_tag2} = CMS.create_article_tag(community2, :blog, article_tag_attrs2, user)
 
-      post_with_tags =
-        Map.merge(post_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
+      blog_with_tags =
+        Map.merge(blog_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
 
-      {:error, reason} = CMS.create_article(community, :blog, post_with_tags, user)
+      {:error, reason} = CMS.create_article(community, :blog, blog_with_tags, user)
       is_error?(reason, :invalid_domain_tag)
     end
   end

test/groupher_server/cms/article_tags/job_tag_test.exs

@@ -12,9 +12,9 @@ defmodule GroupherServer.Test.CMS.ArticleTag.JobTag do
     article_tag_attrs = mock_attrs(:article_tag)
     article_tag_attrs2 = mock_attrs(:article_tag)
 
-    post_attrs = mock_attrs(:job)
+    job_attrs = mock_attrs(:job)
 
-    {:ok, ~m(user community job post_attrs article_tag_attrs article_tag_attrs2)a}
+    {:ok, ~m(user community job job_attrs article_tag_attrs article_tag_attrs2)a}
   end
 
   describe "[job tag CURD]" do
@@ -80,30 +80,29 @@ defmodule GroupherServer.Test.CMS.ArticleTag.JobTag do
 
   describe "[create/update job with tags]" do
     test "can create job with exsited article tags",
-         ~m(community user post_attrs article_tag_attrs article_tag_attrs2)a do
+         ~m(community user job_attrs article_tag_attrs article_tag_attrs2)a do
       {:ok, article_tag} = CMS.create_article_tag(community, :job, article_tag_attrs, user)
       {:ok, article_tag2} = CMS.create_article_tag(community, :job, article_tag_attrs2, user)
 
-      post_with_tags =
-        Map.merge(post_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
+      job_with_tags = Map.merge(job_attrs, %{article_tags: [article_tag.id, article_tag2.id]})
 
-      {:ok, created} = CMS.create_article(community, :job, post_with_tags, user)
+      {:ok, created} = CMS.create_article(community, :job, job_with_tags, user)
       {:ok, job} = ORM.find(Job, created.id, preload: :article_tags)
 
       assert exist_in?(article_tag, job.article_tags)
       assert exist_in?(article_tag2, job.article_tags)
     end
 
     test "can not create job with other community's article tags",
-         ~m(community user post_attrs article_tag_attrs article_tag_attrs2)a do
+         ~m(community user job_attrs article_tag_attrs article_tag_attrs2)a do
       {:ok, community2} = db_insert(:community)
       {:ok, article_tag} = CMS.create_article_tag(community, :job, article_tag_attrs, user)
       {:ok, article_tag2} = CMS.create_article_tag(community2, :job, article_tag_attrs2, user)
 
-      post_with_tags =
-        Map.merge(post_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
+      job_with_tags =
+        Map.merge(job_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
 
-      {:error, reason} = CMS.create_article(community, :job, post_with_tags, user)
+      {:error, reason} = CMS.create_article(community, :job, job_with_tags, user)
       is_error?(reason, :invalid_domain_tag)
     end
   end

test/groupher_server/cms/article_tags/post_tag_test.exs

@@ -84,8 +84,7 @@ defmodule GroupherServer.Test.CMS.ArticleTag.PostTag do
       {:ok, article_tag} = CMS.create_article_tag(community, :post, article_tag_attrs, user)
       {:ok, article_tag2} = CMS.create_article_tag(community, :post, article_tag_attrs2, user)
 
-      post_with_tags =
-        Map.merge(post_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
+      post_with_tags = Map.merge(post_attrs, %{article_tags: [article_tag.id, article_tag2.id]})
 
       {:ok, created} = CMS.create_article(community, :post, post_with_tags, user)
       {:ok, post} = ORM.find(Post, created.id, preload: :article_tags)

test/groupher_server/cms/article_tags/repo_tag_test.exs

@@ -12,9 +12,9 @@ defmodule GroupherServer.Test.CMS.ArticleTag.RepoTag do
     article_tag_attrs = mock_attrs(:article_tag)
     article_tag_attrs2 = mock_attrs(:article_tag)
 
-    post_attrs = mock_attrs(:repo)
+    repo_attrs = mock_attrs(:repo)
 
-    {:ok, ~m(user community repo post_attrs article_tag_attrs article_tag_attrs2)a}
+    {:ok, ~m(user community repo repo_attrs article_tag_attrs article_tag_attrs2)a}
   end
 
   describe "[repo tag CURD]" do
@@ -80,30 +80,29 @@ defmodule GroupherServer.Test.CMS.ArticleTag.RepoTag do
 
   describe "[create/update repo with tags]" do
     test "can create repo with exsited article tags",
-         ~m(community user post_attrs article_tag_attrs article_tag_attrs2)a do
+         ~m(community user repo_attrs article_tag_attrs article_tag_attrs2)a do
       {:ok, article_tag} = CMS.create_article_tag(community, :repo, article_tag_attrs, user)
       {:ok, article_tag2} = CMS.create_article_tag(community, :repo, article_tag_attrs2, user)
 
-      post_with_tags =
-        Map.merge(post_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
+      repo_with_tags = Map.merge(repo_attrs, %{article_tags: [article_tag.id, article_tag2.id]})
 
-      {:ok, created} = CMS.create_article(community, :repo, post_with_tags, user)
+      {:ok, created} = CMS.create_article(community, :repo, repo_with_tags, user)
       {:ok, repo} = ORM.find(Repo, created.id, preload: :article_tags)
 
       assert exist_in?(article_tag, repo.article_tags)
       assert exist_in?(article_tag2, repo.article_tags)
     end
 
     test "can not create repo with other community's article tags",
-         ~m(community user post_attrs article_tag_attrs article_tag_attrs2)a do
+         ~m(community user repo_attrs article_tag_attrs article_tag_attrs2)a do
       {:ok, community2} = db_insert(:community)
       {:ok, article_tag} = CMS.create_article_tag(community, :repo, article_tag_attrs, user)
       {:ok, article_tag2} = CMS.create_article_tag(community2, :repo, article_tag_attrs2, user)
 
-      post_with_tags =
-        Map.merge(post_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
+      repo_with_tags =
+        Map.merge(repo_attrs, %{article_tags: [%{id: article_tag.id}, %{id: article_tag2.id}]})
 
-      {:error, reason} = CMS.create_article(community, :repo, post_with_tags, user)
+      {:error, reason} = CMS.create_article(community, :repo, repo_with_tags, user)
       is_error?(reason, :invalid_domain_tag)
     end
   end