refactor(article-comment): wip

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment.ex

@@ -244,28 +244,41 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
         {:ok, %{user_list: emotioned_user_info_list, user_count: emotioned_user_count}}
       end)
       |> Multi.run(:update_comment_emotion, fn _, %{query_emotion_status: status} ->
+        %{user_count: user_count, user_list: user_list} = status
+
         updated_emotions =
           %{}
-          |> Map.put(:"#{emotion}_count", status.user_count)
-          |> Map.put(
-            :"#{emotion}_user_logins",
-            status.user_list |> Enum.map(& &1.login)
-          )
+          |> Map.put(:"#{emotion}_count", user_count)
+          |> Map.put(:"#{emotion}_user_logins", user_list |> Enum.map(& &1.login))
           |> Map.put(
             :"latest_#{emotion}_users",
-            Enum.slice(status.user_list, 0, @max_latest_emotion_users_count)
+            Enum.slice(user_list, 0, @max_latest_emotion_users_count)
           )
 
+        viewer_has_emotioned = user.login in Map.get(updated_emotions, :"#{emotion}_user_logins")
+
+        updated_emotions =
+          updated_emotions |> Map.put(:"viewer_has_#{emotion}ed", viewer_has_emotioned)
+
         comment
         |> Ecto.Changeset.change()
         |> Ecto.Changeset.put_embed(:emotions, updated_emotions)
         |> Repo.update()
+        # virtual field can not be updated
+        |> add_viewer_emotioned_ifneed(updated_emotions)
       end)
       |> Repo.transaction()
       |> upsert_comment_result
     end
   end
 
+  defp add_viewer_emotioned_ifneed({:error, error}, _), do: {:error, error}
+
+  defp add_viewer_emotioned_ifneed({:ok, comment}, emotions) do
+    # Map.merge(comment, %{emotion: emotions})
+    {:ok, Map.merge(comment, %{emotion: emotions})}
+  end
+
   @doc """
   creates a comment for article like psot, job ...
   """

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -322,6 +322,10 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     CMS.delete_article_comment(comment)
   end
 
+  def emotion_to_comment(_root, ~m(id emotion)a, %{context: %{cur_user: user}}) do
+    CMS.emotion_to_comment(id, emotion, user)
+  end
+
   ############
   ############
   ############

lib/groupher_server_web/schema/cms/cms_misc.ex

@@ -152,6 +152,11 @@ defmodule GroupherServerWeb.Schema.CMS.Misc do
     value(:grey)
   end
 
+  @desc "emotion options of comment"
+  enum :article_comment_emotion do
+    emotion_enum()
+  end
+
   @desc "the filter mode for list comments"
   enum :article_comments_mode do
     value(:replies)

lib/groupher_server_web/schema/cms/mutations/comment.ex

@@ -44,6 +44,20 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Comment do
       resolve(&R.CMS.delete_article_comment/3)
     end
 
+    @desc "emotion to a comment"
+    field :emotion_to_comment, :article_comment do
+      arg(:id, non_null(:id))
+      arg(:emotion, non_null(:article_comment_emotion))
+
+      middleware(M.Authorize, :login)
+      resolve(&R.CMS.emotion_to_comment/3)
+    end
+
+    ############################
+    ############################
+    ############################
+    ############################
+
     @desc "create a comment"
     field :create_comment, :comment do
       # TODO use thread and force community pass-in

lib/groupher_server_web/schema/utils/helper.ex

@@ -224,6 +224,19 @@ defmodule GroupherServerWeb.Schema.Utils.Helper do
     end
   end
 
+  @doc """
+  general emotion enum for comments
+  #NOTE: xxx_user_logins field is not support for gq-endpoint
+  """
+  defmacro emotion_enum() do
+    @supported_emotions
+    |> Enum.map(fn emotion ->
+      quote do
+        value(unquote(:"#{emotion}"))
+      end
+    end)
+  end
+
   @doc """
   general emotions for comments
   #NOTE: xxx_user_logins field is not support for gq-endpoint

test/groupher_server_web/mutation/cms/article_comment_test.exs

@@ -15,7 +15,7 @@ defmodule GroupherServer.Test.Mutation.ArticleComment do
     {:ok, ~m(user_conn user guest_conn owner_conn community post)a}
   end
 
-  describe "[create article comment]" do
+  describe "[article comment CURD]" do
     @write_comment_query """
     mutation($thread: CmsThread!, $id: ID!, $content: String!) {
       createArticleComment(thread: $thread,id: $id, content: $content) {
@@ -86,4 +86,33 @@ defmodule GroupherServer.Test.Mutation.ArticleComment do
       assert deleted["isDeleted"]
     end
   end
+
+  describe "[article comment emotion]" do
+    @emotion_comment_query """
+    mutation($id: ID!, $emotion: ArticleCommentEmotion!) {
+      emotionToComment(id: $id, emotion: $emotion) {
+        id
+        emotions {
+          beerCount
+          viewerHasBeered
+          latestBeerUsers {
+            login
+            nickname
+          }
+        }
+      }
+    }
+    """
+    @tag :wip2
+    test "login user can emotion to a comment", ~m(post user guest_conn user_conn owner_conn)a do
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, "post comment", user)
+      variables = %{id: comment.id, emotion: "BEER"}
+
+      comment =
+        user_conn |> mutation_result(@emotion_comment_query, variables, "emotionToComment")
+
+      assert comment |> get_in(["emotions", "beerCount"]) == 1
+      assert get_in(comment, ["emotions", "viewerHasBeered"])
+    end
+  end
 end