refactor(create_tag): update args to follow conventions

Author: mydearxym

lib/mastani_server/cms/cms.ex

@@ -34,7 +34,7 @@ defmodule MastaniServer.CMS do
   # >> thread
   defdelegate create_thread(attrs), to: CommunityCURD
   # >> tag
-  defdelegate create_tag(thread, attrs, user), to: CommunityCURD
+  defdelegate create_tag(community, thread, attrs, user), to: CommunityCURD
   defdelegate update_tag(attrs), to: CommunityCURD
   defdelegate get_tags(community, thread), to: CommunityCURD
   defdelegate get_tags(community, thread, topic), to: CommunityCURD

lib/mastani_server/cms/delegates/community_curd.ex

@@ -53,14 +53,14 @@ defmodule MastaniServer.CMS.Delegate.CommunityCURD do
   create a Tag base on type: post / tuts / videos ...
   """
   # TODO: change to create_tag(community, thread, attrs, ....)
-  def create_tag(thread, attrs, %Accounts.User{id: user_id}) do
+  def create_tag(%Community{id: community_id}, thread, attrs, %Accounts.User{id: user_id}) do
     with {:ok, action} <- match_action(thread, :tag),
          {:ok, author} <- ensure_author_exists(%Accounts.User{id: user_id}),
-         {:ok, _community} <- ORM.find(Community, attrs.community_id),
+         {:ok, _community} <- ORM.find(Community, community_id),
          {:ok, topic} = find_or_insert_topic(attrs) do
       attrs =
         attrs
-        |> Map.merge(%{author_id: author.id, topic_id: topic.id})
+        |> Map.merge(%{author_id: author.id, topic_id: topic.id, community_id: community_id})
         |> map_atom_value(:string)
         |> Map.merge(%{thread: attrs.thread |> to_string |> String.downcase()})
 

lib/mastani_server/cms/delegates/seeds.ex

@@ -20,6 +20,9 @@ defmodule MastaniServer.CMS.Delegate.Seeds do
   @default_threads ["post", "user", "job", "video", "wiki", "cheatsheet", "repo"]
   @home_threads ["post", "user", "news", "city", "share", "job"]
 
+  # those thread has tag list
+  @general_threads ["post", "job", "repo", "video"]
+
   @pl_communities ["javascript", "scala", "haskell", "swift", "typescript", "lua", "racket"]
   @default_categories ["pl", "front-end", "back-end", "ai", "design", "mobile", "others"]
 
@@ -78,6 +81,9 @@ defmodule MastaniServer.CMS.Delegate.Seeds do
          {:ok, categories} <- seed_categories(bot, :default),
          {:ok, communities} <- seed_for_communities(bot, :pl) do
       threadify_communities(communities.entries, threads)
+      # tagfy_threads(communities.entries, threads)
+
+      # TODO: set tags for post, video, job, repo thread
       categorify_communities(communities.entries, categories)
     end
   end
@@ -145,6 +151,18 @@ defmodule MastaniServer.CMS.Delegate.Seeds do
     end)
   end
 
+  # tagfy only post job repo and video
+  defp tagfy_threads(communities, threads) when is_list(communities) do
+    Enum.each(communities, fn community ->
+      Enum.each(threads, fn thread ->
+        case thread.raw in @general_threads do
+          true -> IO.inspect(thread.raw, label: "set this thread")
+          false -> IO.inspect(thread.raw, label: "not target")
+        end
+      end)
+    end)
+  end
+
   # set categories to given communities
   defp categorify_communities(communities, categories) do
     Enum.each(communities, fn community ->

lib/mastani_server_web/resolvers/cms_resolver.ex

@@ -223,8 +223,10 @@ defmodule MastaniServerWeb.Resolvers.CMS do
   # #######################
   # tags ..
   # #######################
-  def create_tag(_root, args, %{context: %{cur_user: user}}) do
-    CMS.create_tag(args.thread, args, user)
+  def create_tag(_root, %{thread: thread, community_id: community_id} = args, %{
+        context: %{cur_user: user}
+      }) do
+    CMS.create_tag(%Community{id: community_id}, thread, args, user)
   end
 
   def delete_tag(_root, %{id: id}, _info), do: Tag |> ORM.find_delete(id)

test/mastani_server/cms/cms_test.exs

@@ -3,6 +3,7 @@ defmodule MastaniServer.Test.CMS do
 
   alias MastaniServer.Accounts.User
   alias MastaniServer.CMS
+  alias CMS.Community
 
   alias Helper.{Certification, ORM}
 
@@ -16,22 +17,28 @@ defmodule MastaniServer.Test.CMS do
 
   describe "[cms tag]" do
     test "create tag with valid data", ~m(community user)a do
-      valid_attrs = mock_attrs(:tag, %{community_id: community.id})
+      valid_attrs = mock_attrs(:tag)
 
-      {:ok, tag} = CMS.create_tag(:post, valid_attrs, %User{id: user.id})
+      {:ok, tag} = CMS.create_tag(community, :post, valid_attrs, %User{id: user.id})
       assert tag.title == valid_attrs.title
     end
 
     test "create tag with non-exsit user fails", ~m(user)a do
-      invalid_attrs = mock_attrs(:tag, %{community_id: non_exsit_id()})
+      invalid_attrs = mock_attrs(:tag)
 
-      assert {:error, _} = CMS.create_tag(:post, invalid_attrs, %User{id: user.id})
+      assert {:error, _} =
+               CMS.create_tag(%Community{id: non_exsit_id()}, :post, invalid_attrs, %User{
+                 id: user.id
+               })
     end
 
     test "create tag with non-exsit community fails", ~m(user)a do
-      invalid_attrs = mock_attrs(:tag, %{community_id: non_exsit_id()})
+      invalid_attrs = mock_attrs(:tag)
 
-      assert {:error, _} = CMS.create_tag(:post, invalid_attrs, %User{id: user.id})
+      assert {:error, _} =
+               CMS.create_tag(%Community{id: non_exsit_id()}, :post, invalid_attrs, %User{
+                 id: user.id
+               })
     end
   end
 

test/mastani_server_web/query/cms/cms_test.exs

@@ -237,8 +237,10 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
     test "guest user can get paged tags", ~m(guest_conn community user)a do
       variables = %{filter: %{page: 1, size: 10}}
 
-      valid_attrs = mock_attrs(:tag, %{user_id: user.id, community_id: community.id})
-      {:ok, _} = CMS.create_tag(:post, valid_attrs, %User{id: user.id})
+      valid_attrs = mock_attrs(:tag, %{user_id: user.id})
+
+      {:ok, _} =
+        CMS.create_tag(%Community{id: community.id}, :post, valid_attrs, %User{id: user.id})
 
       results = guest_conn |> query_result(@query, variables, "tags")
 
@@ -273,8 +275,10 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
     end
 
     test "user can get partial tags by default index topic", ~m(guest_conn community user)a do
-      valid_attrs = mock_attrs(:tag, %{community_id: community.id})
-      {:ok, _tag} = CMS.create_tag(:post, valid_attrs, %User{id: user.id})
+      valid_attrs = mock_attrs(:tag)
+
+      {:ok, _tag} =
+        CMS.create_tag(%Community{id: community.id}, :post, valid_attrs, %User{id: user.id})
 
       variables = %{thread: "POST", communityId: community.id, topic: "index"}
       results = guest_conn |> query_result(@query, variables, "partialTags")