refactor(cited-article): more test

Author: mydearxym

lib/groupher_server/cms/delegates/cite_tasks.ex

@@ -193,7 +193,7 @@ defmodule GroupherServer.CMS.Delegate.CiteTasks do
   {:ok, "https://coderplanets.com/post/190220"}
   """
   defp parse_link(attrs) do
-    with {"href", link} <- Enum.find(attrs, fn {a, v} -> a == "href" end) do
+    with {"href", link} <- Enum.find(attrs, fn {a, _v} -> a == "href" end) do
       {:ok, link}
     else
       _ -> {:error, "invalid fmt"}

priv/repo/migrations/20210611015726_create_cited_articles.exs

@@ -11,9 +11,9 @@ defmodule GroupherServer.Repo.Migrations.CreateCitedArticles do
       add(:article_comment_id, references(:articles_comments, on_delete: :delete_all))
 
       add(:post_id, references(:cms_posts, on_delete: :delete_all))
-      add(:repo_id, references(:cms_posts, on_delete: :delete_all))
-      add(:job_id, references(:cms_posts, on_delete: :delete_all))
-      add(:blog_id, references(:cms_posts, on_delete: :delete_all))
+      add(:repo_id, references(:cms_repos, on_delete: :delete_all))
+      add(:job_id, references(:cms_jobs, on_delete: :delete_all))
+      add(:blog_id, references(:cms_blogs, on_delete: :delete_all))
 
       add(:block_linker, {:array, :string})
     end

test/groupher_server/cms/cite_contents/cite_blog_test.exs

@@ -0,0 +1,79 @@
+defmodule GroupherServer.Test.CMS.CiteContent.Blog do
+  use GroupherServer.TestTools
+
+  import Helper.Utils, only: [get_config: 2]
+
+  alias Helper.ORM
+  alias GroupherServer.CMS
+
+  alias CMS.Model.Blog
+
+  alias CMS.Delegate.CiteTasks
+
+  @site_host get_config(:general, :site_host)
+
+  setup do
+    {:ok, user} = db_insert(:user)
+    {:ok, user2} = db_insert(:user)
+    {:ok, blog} = db_insert(:blog)
+    {:ok, blog2} = db_insert(:blog)
+    {:ok, blog3} = db_insert(:blog)
+    {:ok, blog4} = db_insert(:blog)
+    {:ok, blog5} = db_insert(:blog)
+
+    {:ok, community} = db_insert(:community)
+
+    blog_attrs = mock_attrs(:blog, %{community_id: community.id})
+
+    {:ok, ~m(user user2 community blog blog2 blog3 blog4 blog5 blog_attrs)a}
+  end
+
+  describe "[cite basic]" do
+    @tag :wip
+    test "cited multi blog should work", ~m(user community blog2 blog3 blog4 blog5 blog_attrs)a do
+      body =
+        mock_rich_text(
+          ~s(the <a href=#{@site_host}/blog/#{blog2.id} /> and <a href=#{@site_host}/blog/#{
+            blog2.id
+          }>same la</a> is awesome, the <a href=#{@site_host}/blog/#{blog3.id}></a> is awesome too.),
+          # second paragraph
+          ~s(the paragraph 2 <a href=#{@site_host}/blog/#{blog2.id} class=#{blog2.title}> again</a>, the paragraph 2 <a href=#{
+            @site_host
+          }/blog/#{blog4.id}> again</a>, the paragraph 2 <a href=#{@site_host}/blog/#{blog5.id}> again</a>)
+        )
+
+      blog_attrs = blog_attrs |> Map.merge(%{body: body})
+      {:ok, blog} = CMS.create_article(community, :blog, blog_attrs, user)
+
+      body = mock_rich_text(~s(the <a href=#{@site_host}/blog/#{blog3.id} />))
+      blog_attrs = blog_attrs |> Map.merge(%{body: body})
+      {:ok, blog_n} = CMS.create_article(community, :blog, blog_attrs, user)
+
+      CiteTasks.handle(blog)
+      CiteTasks.handle(blog_n)
+
+      {:ok, blog2} = ORM.find(Blog, blog2.id)
+      {:ok, blog3} = ORM.find(Blog, blog3.id)
+      {:ok, blog4} = ORM.find(Blog, blog4.id)
+      {:ok, blog5} = ORM.find(Blog, blog5.id)
+
+      assert blog2.meta.citing_count == 1
+      assert blog3.meta.citing_count == 2
+      assert blog4.meta.citing_count == 1
+      assert blog5.meta.citing_count == 1
+    end
+
+    @tag :wip
+    test "cited blog itself should not work", ~m(user community blog_attrs)a do
+      {:ok, blog} = CMS.create_article(community, :blog, blog_attrs, user)
+
+      body = mock_rich_text(~s(the <a href=#{@site_host}/blog/#{blog.id} />))
+      {:ok, blog} = CMS.update_article(blog, %{body: body})
+
+      CiteTasks.handle(blog)
+
+      {:ok, blog} = ORM.find(Blog, blog.id)
+      assert blog.meta.citing_count == 0
+    end
+  end
+end

test/groupher_server/cms/cite_contents/cite_job_test.exs

@@ -0,0 +1,79 @@
+defmodule GroupherServer.Test.CMS.CiteContent.Job do
+  use GroupherServer.TestTools
+
+  import Helper.Utils, only: [get_config: 2]
+
+  alias Helper.ORM
+  alias GroupherServer.CMS
+
+  alias CMS.Model.Job
+
+  alias CMS.Delegate.CiteTasks
+
+  @site_host get_config(:general, :site_host)
+
+  setup do
+    {:ok, user} = db_insert(:user)
+    {:ok, user2} = db_insert(:user)
+    {:ok, job} = db_insert(:job)
+    {:ok, job2} = db_insert(:job)
+    {:ok, job3} = db_insert(:job)
+    {:ok, job4} = db_insert(:job)
+    {:ok, job5} = db_insert(:job)
+
+    {:ok, community} = db_insert(:community)
+
+    job_attrs = mock_attrs(:job, %{community_id: community.id})
+
+    {:ok, ~m(user user2 community job job2 job3 job4 job5 job_attrs)a}
+  end
+
+  describe "[cite basic]" do
+    @tag :wip
+    test "cited multi job should work", ~m(user community job2 job3 job4 job5 job_attrs)a do
+      body =
+        mock_rich_text(
+          ~s(the <a href=#{@site_host}/job/#{job2.id} /> and <a href=#{@site_host}/job/#{job2.id}>same la</a> is awesome, the <a href=#{
+            @site_host
+          }/job/#{job3.id}></a> is awesome too.),
+          # second paragraph
+          ~s(the paragraph 2 <a href=#{@site_host}/job/#{job2.id} class=#{job2.title}> again</a>, the paragraph 2 <a href=#{
+            @site_host
+          }/job/#{job4.id}> again</a>, the paragraph 2 <a href=#{@site_host}/job/#{job5.id}> again</a>)
+        )
+
+      job_attrs = job_attrs |> Map.merge(%{body: body})
+      {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
+
+      body = mock_rich_text(~s(the <a href=#{@site_host}/job/#{job3.id} />))
+      job_attrs = job_attrs |> Map.merge(%{body: body})
+      {:ok, job_n} = CMS.create_article(community, :job, job_attrs, user)
+
+      CiteTasks.handle(job)
+      CiteTasks.handle(job_n)
+
+      {:ok, job2} = ORM.find(Job, job2.id)
+      {:ok, job3} = ORM.find(Job, job3.id)
+      {:ok, job4} = ORM.find(Job, job4.id)
+      {:ok, job5} = ORM.find(Job, job5.id)
+
+      assert job2.meta.citing_count == 1
+      assert job3.meta.citing_count == 2
+      assert job4.meta.citing_count == 1
+      assert job5.meta.citing_count == 1
+    end
+
+    @tag :wip
+    test "cited job itself should not work", ~m(user community job_attrs)a do
+      {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
+
+      body = mock_rich_text(~s(the <a href=#{@site_host}/job/#{job.id} />))
+      {:ok, job} = CMS.update_article(job, %{body: body})
+
+      CiteTasks.handle(job)
+
+      {:ok, job} = ORM.find(Job, job.id)
+      assert job.meta.citing_count == 0
+    end
+  end
+end

test/groupher_server/cms/cite_contents/cite_post_test.exs

@@ -1,4 +1,4 @@
-defmodule GroupherServer.Test.CMS.CiteContent do
+defmodule GroupherServer.Test.CMS.CiteContent.Post do
   use GroupherServer.TestTools
 
   import Helper.Utils, only: [get_config: 2]
@@ -64,7 +64,7 @@ defmodule GroupherServer.Test.CMS.CiteContent do
     end
 
     @tag :wip
-    test "cited post itself should not work", ~m(user community post post_attrs)a do
+    test "cited post itself should not work", ~m(user community post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
 
       body = mock_rich_text(~s(the <a href=#{@site_host}/post/#{post.id} />))

test/support/factory.ex

@@ -113,7 +113,7 @@ defmodule GroupherServer.Support.Factory do
     desc = Faker.Lorem.sentence(%Range{first: 15, last: 60})
 
     %{
-      meta: @default_article_meta,
+      meta: @default_article_meta |> Map.merge(%{thread: "REPO"}),
       title: String.slice(desc, 1, 49),
       owner_name: "coderplanets",
       owner_url: "http://www.github.com/coderplanets",
@@ -183,7 +183,7 @@ defmodule GroupherServer.Support.Factory do
     text = Faker.Lorem.sentence(%Range{first: 80, last: 120})
 
     %{
-      meta: @default_article_meta,
+      meta: @default_article_meta |> Map.merge(%{thread: "JOB"}),
       title: String.slice(text, 1, 49),
       company: Faker.Company.name(),
       body: mock_rich_text(),
@@ -205,7 +205,7 @@ defmodule GroupherServer.Support.Factory do
     text = Faker.Lorem.sentence(%Range{first: 80, last: 120})
 
     %{
-      meta: @default_article_meta,
+      meta: @default_article_meta |> Map.merge(%{thread: "BLOG"}),
       title: String.slice(text, 1, 49),
       body: mock_rich_text(),
       digest: String.slice(text, 1, 150),