refactor(notify): hooks for follow & test

Author: mydearxym

lib/groupher_server/accounts/delegates/fans.ex

@@ -7,10 +7,11 @@ defmodule GroupherServer.Accounts.Delegate.Fans do
   import Helper.ErrorCode
   import ShortMaps
 
-  alias Helper.{ORM, QueryBuilder, SpecType}
+  alias Helper.{ORM, QueryBuilder, Later, SpecType}
   alias GroupherServer.{Accounts, Repo}
 
-  alias GroupherServer.Accounts.Model.{User, Embeds, UserFollower, UserFollowing}
+  alias Accounts.Model.{User, Embeds, UserFollower, UserFollowing}
+  alias Accounts.Delegate.Hooks
 
   alias Ecto.Multi
 
@@ -20,27 +21,30 @@ defmodule GroupherServer.Accounts.Delegate.Fans do
   follow a user
   """
   @spec follow(User.t(), User.t()) :: {:ok, User.t()} | SpecType.gq_error()
-  def follow(%User{id: user_id}, %User{id: follower_id}) do
-    with true <- to_string(user_id) !== to_string(follower_id),
-         {:ok, target_user} <- ORM.find(User, follower_id) do
+  def follow(%User{} = user, %User{} = follower) do
+    with true <- to_string(user.id) !== to_string(follower.id),
+         {:ok, target_user} <- ORM.find(User, follower.id) do
       Multi.new()
       |> Multi.insert(
         :create_follower,
-        UserFollower.changeset(%UserFollower{}, %{user_id: target_user.id, follower_id: user_id})
+        UserFollower.changeset(%UserFollower{}, %{user_id: target_user.id, follower_id: user.id})
       )
       |> Multi.insert(
         :create_following,
         UserFollowing.changeset(%UserFollowing{}, %{
-          user_id: user_id,
+          user_id: user.id,
           following_id: target_user.id
         })
       )
       |> Multi.run(:update_user_follow_info, fn _, _ ->
-        update_user_follow_info(target_user, user_id, :add)
+        update_user_follow_info(target_user, user.id, :add)
       end)
       |> Multi.run(:add_achievement, fn _, _ ->
         Accounts.achieve(%User{id: target_user.id}, :inc, :follow)
       end)
+      |> Multi.run(:after_hooks, fn _, _ ->
+        Later.run({Hooks.Notify, :handle, [:follow, user, follower]})
+      end)
       |> Repo.transaction()
       |> result()
     else
@@ -53,22 +57,25 @@ defmodule GroupherServer.Accounts.Delegate.Fans do
   undo a follow action to a user
   """
   @spec undo_follow(User.t(), User.t()) :: {:ok, User.t()} | SpecType.gq_error()
-  def undo_follow(%User{id: user_id}, %User{id: follower_id}) do
-    with true <- to_string(user_id) !== to_string(follower_id),
-         {:ok, target_user} <- ORM.find(User, follower_id) do
+  def undo_follow(%User{} = user, %User{} = follower) do
+    with true <- to_string(user.id) !== to_string(follower.id),
+         {:ok, target_user} <- ORM.find(User, follower.id) do
       Multi.new()
       |> Multi.run(:delete_follower, fn _, _ ->
-        ORM.findby_delete!(UserFollower, %{user_id: target_user.id, follower_id: user_id})
+        ORM.findby_delete!(UserFollower, %{user_id: target_user.id, follower_id: user.id})
       end)
       |> Multi.run(:delete_following, fn _, _ ->
-        ORM.findby_delete!(UserFollowing, %{user_id: user_id, following_id: target_user.id})
+        ORM.findby_delete!(UserFollowing, %{user_id: user.id, following_id: target_user.id})
       end)
       |> Multi.run(:update_user_follow_info, fn _, _ ->
-        update_user_follow_info(target_user, user_id, :remove)
+        update_user_follow_info(target_user, user.id, :remove)
       end)
       |> Multi.run(:minus_achievement, fn _, _ ->
         Accounts.achieve(%User{id: target_user.id}, :dec, :follow)
       end)
+      |> Multi.run(:after_hooks, fn _, _ ->
+        Later.run({Hooks.Notify, :handle, [:undo, :follow, user, follower]})
+      end)
       |> Repo.transaction()
       |> result()
     else

lib/groupher_server/accounts/delegates/hooks/notify.ex

@@ -0,0 +1,26 @@
+defmodule GroupherServer.Accounts.Delegate.Hooks.Notify do
+  @moduledoc """
+  notify hooks, for upvote, collect, comment, reply
+  """
+  alias GroupherServer.{Accounts, Delivery}
+  alias Accounts.Model.User
+
+  # 发布评论是特殊情况，单独处理
+  def handle(:follow, %User{} = user, %User{} = from_user) do
+    notify_attrs = %{
+      action: :follow,
+      user_id: user.id
+    }
+
+    Delivery.send(:notify, notify_attrs, from_user)
+  end
+
+  def handle(:undo, :follow, %User{} = user, %User{} = from_user) do
+    notify_attrs = %{
+      action: :follow,
+      user_id: user.id
+    }
+
+    Delivery.revoke(:notify, notify_attrs, from_user)
+  end
+end

test/groupher_server/accounts/hooks/notify_test.exs

@@ -0,0 +1,41 @@
+defmodule GroupherServer.Test.Accounts.Hooks.Notify do
+  use GroupherServer.TestTools
+
+  import GroupherServer.CMS.Delegate.Helper, only: [preload_author: 1]
+
+  alias GroupherServer.{Accounts, Delivery}
+  alias Accounts.Delegate.Hooks
+
+  setup do
+    {:ok, user} = db_insert(:user)
+    {:ok, user2} = db_insert(:user)
+
+    {:ok, ~m(user user2 )a}
+  end
+
+  describe "[follow notify]" do
+    @tag :wip
+    test "follow notify hook should work", ~m(user user2)a do
+      {:ok, _} = Accounts.follow(user, user2)
+      Hooks.Notify.handle(:follow, user, user2)
+
+      {:ok, notifications} = Delivery.fetch(:notification, user.id, %{page: 1, size: 20})
+      assert notifications.total_count == 1
+
+      notify = notifications.entries |> List.first()
+      assert notify.action == "FOLLOW"
+      assert notify.user_id == user.id
+      assert user_exist_in?(user2, notify.from_users)
+    end
+
+    @tag :wip
+    test "undo follow notify hook should work", ~m(user user2)a do
+      {:ok, _} = Accounts.follow(user, user2)
+      Hooks.Notify.handle(:follow, user, user2)
+      Hooks.Notify.handle(:undo, :follow, user, user2)
+
+      {:ok, notifications} = Delivery.fetch(:notification, user.id, %{page: 1, size: 20})
+      assert notifications.total_count == 0
+    end
+  end
+end

test/groupher_server/delivery/notification_test.exs

@@ -40,7 +40,6 @@ defmodule GroupherServer.Test.Delivery.Notification do
   end
 
   describe "account follow" do
-    @tag :wip
     test "support follow action", ~m(user user2)a do
       notify_attrs = %{
         action: :follow,
@@ -59,7 +58,6 @@ defmodule GroupherServer.Test.Delivery.Notification do
       assert user2 |> user_exist_in?(notify.from_users)
     end
 
-    @tag :wip
     test "similar follow notify should be merged", ~m(user user2 user3)a do
       notify_attrs = %{
         action: :follow,