refactor: wip

Author: mydearxym

lib/groupher_server/cms/delegates/article_operation.ex

@@ -8,7 +8,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
 
   import Helper.ErrorCode
   import ShortMaps
-  import Helper.Utils, only: [strip_struct: 1, integerfy: 1]
+  import Helper.Utils, only: [strip_struct: 1, integerfy: 1, done: 1]
   import GroupherServer.CMS.Helper.Matcher2
 
   alias Helper.Types, as: T
@@ -29,6 +29,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
   alias GroupherServer.CMS.Repo, as: CMSRepo
   alias GroupherServer.Repo
 
+  alias Ecto.Multi
+
   @max_pinned_article_count_per_thread Community.max_pinned_article_count_per_thread()
 
   @spec pin_article(T.article_thread(), Integer.t(), Integer.t()) :: {:ok, PinnedArticle.t()}
@@ -103,7 +105,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
   end
 
   @doc """
-  set content to diffent community
+  mirror article to other community
   """
   def set_community(thread, article_id, community_id) do
     with {:ok, info} <- match(thread),
@@ -116,6 +118,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
     end
   end
 
+  @doc """
+  unmirror article to a community
+  """
   def unset_community(thread, article_id, community_id) do
     with {:ok, info} <- match(thread),
          {:ok, article} <-
@@ -135,18 +140,33 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
   end
 
   @doc """
-  set article original community in meta
+  move article original community to other community
   """
   def move_article(thread, article_id, community_id) do
     with {:ok, info} <- match(thread),
-         {:ok, article} <- ORM.find(info.model, article_id) do
-      article
-      |> Ecto.Changeset.change()
-      |> Ecto.Changeset.put_change(:original_community_id, integerfy(community_id))
-      |> Repo.update()
+         {:ok, community} <- ORM.find(Community, community_id),
+         {:ok, article} <- ORM.find(info.model, article_id, preload: [:communities]) do
+      Multi.new()
+      |> Multi.run(:change_original_community, fn _, _ ->
+        article
+        |> Ecto.Changeset.change()
+        |> Ecto.Changeset.put_change(:original_community_id, community.id)
+        |> Repo.update()
+      end)
+      |> Multi.run(:unmirror_community, fn _, %{change_original_community: article} ->
+        article
+        |> Ecto.Changeset.change()
+        |> Ecto.Changeset.put_assoc(:communities, article.communities -- [community])
+        |> Repo.update()
+      end)
+      |> Repo.transaction()
+      |> result()
     end
   end
 
+  defp result({:ok, %{change_original_community: result}}), do: result |> done()
+  defp result({:error, _, result, _steps}), do: {:error, result}
+
   @doc """
   set general tag for post / tuts ...
   """

test/groupher_server/cms/article_community/job_test.exs

@@ -25,14 +25,16 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Job do
       assert job.original_community_id == community.id
     end
 
+    @tag :wip2
     test "job can be move to other community", ~m(user community community2 job_attrs)a do
       {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
       assert job.original_community_id == community.id
 
       {:ok, _} = CMS.move_article(:job, job.id, community2.id)
-      {:ok, job} = ORM.find(CMS.Job, job.id, preload: :original_community)
+      {:ok, job} = ORM.find(CMS.Job, job.id, preload: [:original_community, :communities])
 
       assert job.original_community.id == community2.id
+      assert is_nil(Enum.find(job.communities, &(&1.id == community2.id)))
     end
 
     test "job can be mirror to other community", ~m(user community community2 job_attrs)a do

test/groupher_server/cms/article_community/post_test.exs

@@ -25,14 +25,16 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Post do
       assert post.original_community_id == community.id
     end
 
+    @tag :wip2
     test "post can be move to other community", ~m(user community community2 post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
       assert post.original_community_id == community.id
 
       {:ok, _} = CMS.move_article(:post, post.id, community2.id)
-      {:ok, post} = ORM.find(CMS.Post, post.id, preload: :original_community)
+      {:ok, post} = ORM.find(CMS.Post, post.id, preload: [:original_community, :communities])
 
       assert post.original_community.id == community2.id
+      assert is_nil(Enum.find(post.communities, &(&1.id == community2.id)))
     end
 
     test "post can be mirror to other community", ~m(user community community2 post_attrs)a do

test/groupher_server/cms/article_community/repo_test.exs

@@ -25,14 +25,16 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Repo do
       assert repo.original_community_id == community.id
     end
 
+    @tag :wip2
     test "repo can be move to other community", ~m(user community community2 repo_attrs)a do
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
       assert repo.original_community_id == community.id
 
       {:ok, _} = CMS.move_article(:repo, repo.id, community2.id)
-      {:ok, repo} = ORM.find(CMS.Repo, repo.id, preload: :original_community)
+      {:ok, repo} = ORM.find(CMS.Repo, repo.id, preload: [:original_community, :communities])
 
       assert repo.original_community.id == community2.id
+      assert is_nil(Enum.find(repo.communities, &(&1.id == community2.id)))
     end
 
     test "repo can be mirror to other community", ~m(user community community2 repo_attrs)a do