refactor(mailbox): paged mentions & test

Author: mydearxym

lib/groupher_server/accounts/accounts.ex

@@ -67,6 +67,8 @@ defmodule GroupherServer.Accounts do
   defdelegate mark_read(type, ids, user_id), to: Mailbox
   defdelegate mark_read_all(tyoe, user_id), to: Mailbox
 
+  defdelegate paged_mailbox_messages(type, user, filter), to: Mailbox
+
   # customization
   defdelegate get_customization(user), to: Customization
   defdelegate set_customization(user, key, value), to: Customization

lib/groupher_server/accounts/delegates/mailbox.ex

@@ -19,6 +19,10 @@ defmodule GroupherServer.Accounts.Delegate.Mailbox do
 
   def mark_read_all(type, %User{} = user), do: Delivery.mark_read_all(type, user)
 
+  def paged_mailbox_messages(type, user, filter) do
+    Delivery.fetch(type, user, filter)
+  end
+
   @doc "update messages count in mailbox"
   def update_mailbox_status(user_id) do
     with {:ok, user} <- ORM.find(User, user_id),

lib/groupher_server_web/resolvers/accounts_resolver.ex

@@ -233,6 +233,11 @@ defmodule GroupherServerWeb.Resolvers.Accounts do
     Accounts.mark_read_all(type, cur_user)
   end
 
+  def paged_mailbox_mentions(_root, ~m(filter)a, %{context: %{cur_user: cur_user}}) do
+    IO.inspect(cur_user.login, label: "in resolver")
+    Accounts.paged_mailbox_messages(:mention, cur_user, filter)
+  end
+
   # mailbox end
 
   # for check other users subscribed_communities

lib/groupher_server_web/schema/account/account_metrics.ex

@@ -4,6 +4,11 @@ defmodule GroupherServerWeb.Schema.Account.Metrics do
   use Absinthe.Schema.Notation
   import GroupherServerWeb.Schema.Helper.Fields
 
+  input_object :mailbox_mentions_filter do
+    field(:read, :boolean, default_value: false)
+    pagination_args()
+  end
+
   @desc "article_filter doc"
   input_object :paged_users_filter do
     pagination_args()

lib/groupher_server_web/schema/account/account_queries.ex

@@ -35,14 +35,14 @@ defmodule GroupherServerWeb.Schema.Account.Queries do
       resolve(&R.Accounts.subscribed_communities/3)
     end
 
-    # @desc "get user's mentions"
-    # field :mentions, :paged_mentions do
-    #   arg(:filter, :messages_filter)
-
-    #   middleware(M.Authorize, :login)
-    #   middleware(M.PageSizeProof)
-    #   resolve(&R.Accounts.fetch_mentions/3)
-    # end
+    @desc "get login user's mentions in mailbox"
+    field :paged_mentions, :paged_mailbox_mentions do
+      arg(:filter, :mailbox_mentions_filter)
+
+      middleware(M.Authorize, :login)
+      middleware(M.PageSizeProof)
+      resolve(&R.Accounts.paged_mailbox_mentions/3)
+    end
 
     @desc "get user's follower"
     field :paged_followers, :paged_users do

lib/groupher_server_web/schema/account/account_types.ex

@@ -97,6 +97,21 @@ defmodule GroupherServerWeb.Schema.Account.Types do
     field(:unread_notifications_count, :integer)
   end
 
+  object :mailbox_mention do
+    field(:id, :id)
+    field(:thread, :string)
+    field(:article_id, :id)
+    field(:title, :string)
+    field(:comment_id, :id)
+    field(:read, :boolean)
+
+    field(:block_linker, list_of(:string))
+
+    field(:user, :common_user)
+
+    timestamp_fields()
+  end
+
   # field(:sidebar_layout, :map)
   object :customization do
     field(:theme, :string)
@@ -200,6 +215,11 @@ defmodule GroupherServerWeb.Schema.Account.Types do
     pagination_fields()
   end
 
+  object :paged_mailbox_mentions do
+    field(:entries, list_of(:mailbox_mention))
+    pagination_fields()
+  end
+
   enum :mailbox_type do
     value(:mention)
     value(:notification)

test/groupher_server/accounts/mailbx_test.exs

@@ -17,7 +17,7 @@ defmodule GroupherServer.Test.Accounts.Mailbox do
   end
 
   describe "mailbox status" do
-    @tag :wip
+    @tag :wip2
     test "can get default mailbox status", ~m(user)a do
       {:ok, status} = Accounts.mailbox_status(user)
       assert status == @default_mailbox_status

test/groupher_server_web/mutation/accounts/mailbox_test.exs

@@ -22,7 +22,7 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       }
     }
     """
-    # @tag :wip
+    # @tag :wip2
     test "can mark read a mention", ~m(user_conn user user2)a do
       {:ok, _} = mock_mention_for(user, user2)
 
@@ -37,7 +37,7 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       assert mention.read
     end
 
-    @tag :wip
+    @tag :wip2
     test "can mark read a notification", ~m(user_conn user user2)a do
       {:ok, _} = mock_notification_for(user, user2)
 
@@ -60,7 +60,7 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       }
     }
     """
-    @tag :wip
+    @tag :wip2
     test "can mark read all mentions", ~m(user_conn user user2 user3)a do
       {:ok, _} = mock_mention_for(user, user2)
       {:ok, _} = mock_mention_for(user, user3)
@@ -75,7 +75,7 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       assert mentions.total_count == 2
     end
 
-    @tag :wip
+    @tag :wip2
     test "can mark read all notifications", ~m(user_conn user user2)a do
       {:ok, _} = mock_notification_for(user, user2)
 
@@ -89,16 +89,4 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       assert notifications.total_count == 1
     end
   end
-
-  describe "[paged messages]" do
-    test "can get paged mentions" do
-      #
-      true
-    end
-
-    test "can get paged notifications" do
-      #
-      true
-    end
-  end
 end

test/groupher_server_web/query/accounts/mailbox_test.exs

@@ -5,7 +5,7 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
     {:ok, user} = db_insert(:user)
     {:ok, user2} = db_insert(:user)
 
-    user_conn = simu_conn(:user)
+    user_conn = simu_conn(:user, user)
     guest_conn = simu_conn(:guest)
 
     {:ok, ~m(user_conn guest_conn user user2)a}
@@ -25,10 +25,8 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       }
     }
     """
-    @tag :wip
-    test "auth user can get it's own default mailbox status", ~m(user)a do
-      user_conn = simu_conn(:user, user)
-
+    @tag :wip2
+    test "auth user can get it's own default mailbox status", ~m(user_conn user)a do
       results = user_conn |> query_result(@query, %{login: user.login}, "user")
       mailbox = results["mailbox"]
 
@@ -38,12 +36,11 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       assert mailbox["unreadNotificationsCount"] == 0
     end
 
-    @tag :wip
-    test "auth user can get latest mailbox status after being mentioned", ~m(user user2)a do
+    @tag :wip2
+    test "auth user can get latest mailbox status after being mentioned",
+         ~m(user_conn user user2)a do
       {:ok, _} = mock_mention_for(user, user2)
 
-      user_conn = simu_conn(:user, user)
-
       results = user_conn |> query_result(@query, %{login: user.login}, "user")
       mailbox = results["mailbox"]
 
@@ -53,12 +50,11 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
       assert mailbox["unreadNotificationsCount"] == 0
     end
 
-    @tag :wip
-    test "auth user can get latest mailbox status after being notified", ~m(user user2)a do
+    @tag :wip2
+    test "auth user can get latest mailbox status after being notified",
+         ~m(user_conn user user2)a do
       mock_notification_for(user, user2)
 
-      user_conn = simu_conn(:user, user)
-
       results = user_conn |> query_result(@query, %{login: user.login}, "user")
       mailbox = results["mailbox"]
 
@@ -69,6 +65,49 @@ defmodule GroupherServer.Test.Query.Accounts.Mailbox do
     end
   end
 
+  describe "[paged messages]" do
+    @query """
+    query($filter: MailboxMentionsFilter!) {
+      pagedMentions(filter: $filter) {
+        entries {
+          id
+          thread
+          articleId
+          title
+          commentId
+          read
+          blockLinker
+          user {
+            login
+            nickname
+          }
+        }
+        totalPages
+        totalCount
+        pageSize
+        pageNumber
+      }
+    }
+    """
+    @tag :wip
+    test "can get paged mentions", ~m(user_conn user user2)a do
+      mock_mention_for(user, user2)
+
+      varibles = %{filter: %{page: 1, size: 20}}
+
+      results = user_conn |> query_result(@query, varibles, "pagedMentions")
+
+      assert results |> is_valid_pagination?
+      mention = results["entries"] |> List.first()
+      assert user2.login == mention |> get_in(["user", "login"])
+    end
+
+    test "can get paged notifications" do
+      #
+      true
+    end
+  end
+
   # describe "[accounts mention]" do
   #   @query """
   #   query($filter: MessagesFilter!) {