chore: wip

Author: mydearxym

lib/groupher_server/cms/delegates/article_curd.ex

@@ -292,8 +292,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
         CMS.PinedPost
         |> join(:inner, [p], c in assoc(p, :community))
         |> join(:inner, [p], content in assoc(p, :post))
-        |> where([p, c, t, content], c.raw == ^community)
-        |> select([p, c, t, content], content)
+        |> where([p, c, content], c.raw == ^community)
+        |> select([p, c, content], content)
         # 10 pined contents per community/thread, at most
         |> ORM.paginater(%{page: 1, size: 10})
         |> done()

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -99,27 +99,29 @@ defmodule GroupherServerWeb.Resolvers.CMS do
   # #######################
   # content flag ..
   # #######################
+  def pin_content(_root, ~m(id community_id thread)a, _info) do
+    do_pin_content(id, community_id, thread)
+  end
+
   def pin_content(_root, ~m(id community_id)a, _info) do
     CMS.pin_content(%CMS.Post{id: id}, %Community{id: community_id})
   end
 
-  def pin_content(_root, ~m(id community_id thread)a, _info) do
-    do_pin_content(id, community_id, thread)
+  def undo_pin_content(_root, ~m(id community_id thread)a, _info) do
+    do_undo_pin_content(id, community_id, thread)
   end
 
   def undo_pin_content(_root, ~m(id community_id)a, _info) do
     CMS.undo_pin_content(%CMS.Post{id: id}, %Community{id: community_id})
   end
 
-  def undo_pin_content(_root, ~m(id community_id thread)a, _info) do
-    do_undo_pin_content(id, community_id, thread)
+  def do_pin_content(id, community_id, :job) do
+    CMS.pin_content(%CMS.Job{id: id}, %Community{id: community_id})
   end
 
-  def do_pin_content(id, community_id, :job),
-    do: CMS.pin_content(%CMS.Job{id: id}, %Community{id: community_id})
-
-  def do_pin_content(id, community_id, :repo),
-    do: CMS.pin_content(%CMS.Repo{id: id}, %Community{id: community_id})
+  def do_pin_content(id, community_id, :repo) do
+    CMS.pin_content(%CMS.Repo{id: id}, %Community{id: community_id})
+  end
 
   def do_undo_pin_content(id, community_id, :job) do
     CMS.undo_pin_content(%CMS.Job{id: id}, %Community{id: community_id})
@@ -129,11 +131,13 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     CMS.undo_pin_content(%CMS.Repo{id: id}, %Community{id: community_id})
   end
 
-  def trash_content(_root, ~m(id thread community_id)a, _info),
-    do: set_community_flags(community_id, thread, id, %{trash: true})
+  def trash_content(_root, ~m(id thread community_id)a, _info) do
+    set_community_flags(community_id, thread, id, %{trash: true})
+  end
 
-  def undo_trash_content(_root, ~m(id thread community_id)a, _info),
-    do: set_community_flags(community_id, thread, id, %{trash: false})
+  def undo_trash_content(_root, ~m(id thread community_id)a, _info) do
+    set_community_flags(community_id, thread, id, %{trash: false})
+  end
 
   # TODO: report contents
   # def report_content(_root, ~m(id thread community_id)a, _info),

test/groupher_server/cms/article_comment_replies_test.exs

@@ -100,7 +100,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommentReplies do
       {:ok, replyed_comment_2} = CMS.reply_article_comment(replyed_comment_1.id, "reply 2", user2)
       {:ok, replyed_comment_3} = CMS.reply_article_comment(replyed_comment_2.id, "reply 3", user)
 
-      {:ok, parent_comment} = ORM.find(ArticleComment, parent_comment.id)
+      {:ok, _parent_comment} = ORM.find(ArticleComment, parent_comment.id)
 
       {:ok, replyed_comment_1} = ORM.find(ArticleComment, replyed_comment_1.id)
       {:ok, replyed_comment_2} = ORM.find(ArticleComment, replyed_comment_2.id)

test/groupher_server/cms/article_comment_test.exs

@@ -321,7 +321,6 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
     @tag :wip
     test "can load paged comments participators of a article", ~m(user post)a do
       total_count = 30
-      page_number = 1
       page_size = 10
       thread = :post
 
@@ -332,8 +331,8 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
         acc ++ [comment]
       end)
 
-      {:ok, comment} = CMS.create_article_comment(:post, post.id, "commment", user)
-      {:ok, comment} = CMS.create_article_comment(:post, post.id, "commment", user)
+      {:ok, _comment} = CMS.create_article_comment(:post, post.id, "commment", user)
+      {:ok, _comment} = CMS.create_article_comment(:post, post.id, "commment", user)
 
       {:ok, results} =
         CMS.list_article_comments_participators(thread, post.id, %{page: 1, size: page_size})

test/groupher_server/cms/content_pin_test.exs

@@ -24,16 +24,16 @@ defmodule GroupherServer.Test.CMS.ContentsPin do
 
   describe "[cms post pin]" do
     test "can pin a post", ~m(community post)a do
-      {:ok, pined_post} = CMS.pin_content(post, community, "posts")
+      {:ok, pined_post} = CMS.pin_content(post, community)
 
       assert pined_post.id == post.id
     end
 
     test "can undo pin to a post", ~m(community post)a do
-      {:ok, pined_post} = CMS.pin_content(post, community, "posts")
+      {:ok, pined_post} = CMS.pin_content(post, community)
       assert pined_post.id == post.id
 
-      assert {:ok, unpined} = CMS.undo_pin_content(post, community, "posts")
+      assert {:ok, unpined} = CMS.undo_pin_content(post, community)
       assert unpined.id == post.id
     end
   end

test/groupher_server_web/mutation/cms/cms_test.exs

@@ -216,6 +216,7 @@ defmodule GroupherServer.Test.Mutation.CMS.Basic do
       assert belong_community["id"] == to_string(community.id)
     end
 
+    @tag :wip3
     test "auth user create duplicate tag fails", ~m(community)a do
       variables = mock_attrs(:tag, %{communityId: community.id})
 

test/groupher_server_web/mutation/cms/post_flag_test.exs

@@ -118,7 +118,7 @@ defmodule GroupherServer.Test.Mutation.PostFlag do
       passport_rules = %{community.raw => %{"post.undo_pin" => true}}
       rule_conn = simu_conn(:user, cms: passport_rules)
 
-      CMS.pin_content(post, community, "posts")
+      CMS.pin_content(post, community)
       updated = rule_conn |> mutation_result(@query, variables, "undoPinPost")
 
       assert updated["id"] == to_string(post.id)

test/groupher_server_web/mutation/cms/repo_test.exs

@@ -141,7 +141,7 @@ defmodule GroupherServer.Test.Mutation.Repo do
       created = user_conn |> mutation_result(@create_repo_query, variables, "createRepo")
       {:ok, repo} = ORM.find(CMS.Repo, created["id"])
 
-      updated =
+      _updated =
         user_conn
         |> mutation_result(
           @update_repo_query,

test/groupher_server_web/query/cms/article_comment_test.exs

@@ -288,7 +288,7 @@ defmodule GroupherServer.Test.Query.ArticleComment do
       assert results["totalCount"] == total_count + 2
     end
 
-    @tag :wip2
+    @tag :wip
     test "guest user can get paged comment with floor it", ~m(guest_conn post user)a do
       total_count = 5
       thread = :post

test/groupher_server_web/query/cms/paged_posts_test.exs

@@ -186,26 +186,7 @@ defmodule GroupherServer.Test.Query.PagedPosts do
       assert results["totalCount"] == 1
     end
 
-    # test "read state false filter should work", ~m(user)a do
-    # user_conn = simu_conn(:user, user)
-    # {:ok, community} = db_insert(:community)
-
-    # {:ok, post} = CMS.create_content(community, :post, mock_attrs(:post), user)
-    # {:ok, _post2} = CMS.create_content(community, :post, mock_attrs(:post), user)
-    # {:ok, _post3} = CMS.create_content(community, :post, mock_attrs(:post), user)
-
-    # variables = %{filter: %{community: community.raw}}
-    # results = user_conn |> query_result(@query, variables, "pagedPosts")
-    # assert results["totalCount"] == 3
-
-    # {:ok, _} = CMS.read_content(:post, post.id, user)
-
-    # variables = %{filter: %{community: community.raw, read: "FALSE"}}
-    # results = user_conn |> query_result(@query, variables, "pagedPosts")
-
-    # assert results["totalCount"] == 2
-    # end
-
+    @tag :wip2
     test "read state all filter should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)