feat: add more social info to users

Author: mydearxym

lib/mastani_server/accounts/delegates/profile.ex

@@ -115,6 +115,7 @@ defmodule MastaniServer.Accounts.Delegate.Profile do
   defp create_user(profile, :github) do
     attrs = %{
       nickname: profile["login"],
+      github: "https://github.com/#{profile["login"]}",
       avatar: profile["avatar_url"],
       bio: profile["bio"],
       location: profile["location"],

lib/mastani_server/accounts/user.ex

@@ -21,7 +21,7 @@ defmodule MastaniServer.Accounts.User do
   alias MastaniServer.CMS
 
   @required_fields ~w(nickname avatar)a
-  @optional_fields ~w(nickname bio sex location email qq weichat weibo)a
+  @optional_fields ~w(nickname bio sex location douban dribble email facebook github huaban qq  weibo weichat twitter zhihu)a
 
   @type t :: %User{}
   schema "users" do
@@ -33,14 +33,22 @@ defmodule MastaniServer.Accounts.User do
     field(:location, :string)
 
     # TODO
-    # field(:twitter, :string)
-    # field(:facebook, :string)
     embeds_many(:education_backgrounds, EducationBackground)
     embeds_many(:work_backgrounds, WorkBackground)
 
+    # social info
+    field(:github, :string)
+    field(:twitter, :string)
+    field(:facebook, :string)
+    field(:zhihu, :string)
+    field(:dribble, :string)
+    field(:huaban, :string)
+    field(:douban, :string)
+
     field(:qq, :string)
     field(:weibo, :string)
     field(:weichat, :string)
+
     field(:from_github, :boolean)
     has_one(:achievement, Achievement)
     has_one(:github_profile, GithubUser)

priv/repo/migrations/20180826082635_add_more_social_info_to_users.exs

@@ -0,0 +1,15 @@
+defmodule MastaniServer.Repo.Migrations.AddMoreSocialInfoToUsers do
+  use Ecto.Migration
+
+  def change do
+    alter table(:users) do
+      add(:github, :string)
+      add(:twitter, :string)
+      add(:facebook, :string)
+      add(:zhihu, :string)
+      add(:dribble, :string)
+      add(:huaban, :string)
+      add(:douban, :string)
+    end
+  end
+end

test/mastani_server/accounts/accounts_test.exs

@@ -89,6 +89,7 @@ defmodule MastaniServer.Test.Accounts do
   describe "[github login]" do
     alias Accounts.{GithubUser, User}
 
+    @tag :wip
     test "register a valid github user with non-exist in db" do
       assert {:error, _} =
                ORM.find_by(GithubUser, github_id: to_string(@valid_github_profile["id"]))
@@ -104,6 +105,7 @@ defmodule MastaniServer.Test.Accounts do
       assert created_user.nickname == @valid_github_profile["login"]
       assert created_user.avatar == @valid_github_profile["avatar_url"]
       assert created_user.bio == @valid_github_profile["bio"]
+      assert created_user.github == "https://github.com/#{@valid_github_profile["login"]}"
 
       assert created_user.email == @valid_github_profile["email"]
 

test/support/factory.ex

@@ -187,7 +187,7 @@ defmodule MastaniServer.Factory do
 
     %{
       id: "#{Faker.Name.first_name()} #{unique_num}",
-      login: "#{Faker.Name.first_name()} #{unique_num}",
+      login: "#{Faker.Name.first_name()}#{unique_num}",
       github_id: "#{unique_num + 1000}",
       node_id: "#{unique_num + 2000}",
       access_token: "#{unique_num + 3000}",