refactor(reactions-test): re-org wip

Author: mydearxym

test/groupher_server/cms/upvotes/job_upvote_test.exs

@@ -0,0 +1,88 @@
+defmodule GroupherServer.Test.Upvotes.JobUpvote do
+  @moduledoc false
+  use GroupherServer.TestTools
+
+  alias GroupherServer.CMS
+
+  setup do
+    {:ok, user} = db_insert(:user)
+    {:ok, user2} = db_insert(:user)
+    {:ok, community} = db_insert(:community)
+
+    job_attrs = mock_attrs(:job, %{community_id: community.id})
+
+    {:ok, ~m(user user2 community job_attrs)a}
+  end
+
+  describe "[cms job upvote]" do
+    @tag :wip2
+    test "job can be upvote && upvotes_count should inc by 1",
+         ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+
+      {:ok, article} = CMS.upvote_article(:job, job.id, user)
+      assert article.id == job.id
+      assert article.upvotes_count == 1
+
+      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
+      assert article.upvotes_count == 2
+    end
+
+    @tag :wip2
+    test "job can be undo upvote && upvotes_count should dec by 1",
+         ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+
+      {:ok, article} = CMS.upvote_article(:job, job.id, user)
+      assert article.id == job.id
+      assert article.upvotes_count == 1
+
+      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user2)
+      assert article.upvotes_count == 0
+    end
+
+    @tag :wip2
+    test "can get upvotes_users", ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+
+      {:ok, _article} = CMS.upvote_article(:job, job.id, user)
+      {:ok, _article} = CMS.upvote_article(:job, job.id, user2)
+
+      {:ok, users} = CMS.upvoted_users(:job, job.id, %{page: 1, size: 2})
+
+      assert users |> is_valid_pagination?(:raw)
+      assert user_exist_in?(user, users.entries)
+      assert user_exist_in?(user2, users.entries)
+    end
+
+    @tag :wip2
+    test "job meta history should be updated after upvote",
+         ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+      {:ok, article} = CMS.upvote_article(:job, job.id, user)
+      assert user.id in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
+      assert user.id in article.meta.upvoted_user_ids
+      assert user2.id in article.meta.upvoted_user_ids
+    end
+
+    @tag :wip2
+    test "job meta history should be updated after undo upvote",
+         ~m(user user2 community job_attrs)a do
+      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
+
+      {:ok, _article} = CMS.upvote_article(:job, job.id, user)
+      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
+
+      assert user.id in article.meta.upvoted_user_ids
+      assert user2.id in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user2)
+      assert user2.id not in article.meta.upvoted_user_ids
+
+      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user)
+      assert user.id not in article.meta.upvoted_user_ids
+    end
+  end
+end

test/groupher_server/cms/article_upvote_test.exs renamed to test/groupher_server/cms/upvotes/post_upvote_test.exs

@@ -1,4 +1,4 @@
-defmodule GroupherServer.Test.ArticleUpvote do
+defmodule GroupherServer.Test.Upvotes.PostUpvote do
   @moduledoc false
   use GroupherServer.TestTools
 
@@ -10,13 +10,12 @@ defmodule GroupherServer.Test.ArticleUpvote do
     {:ok, community} = db_insert(:community)
 
     post_attrs = mock_attrs(:post, %{community_id: community.id})
-    job_attrs = mock_attrs(:job, %{community_id: community.id})
 
-    {:ok, ~m(user user2 community post_attrs job_attrs)a}
+    {:ok, ~m(user user2 community post_attrs)a}
   end
 
   describe "[cms post upvote]" do
-    @tag :wip
+    @tag :wip2
     test "post can be upvote && upvotes_count should inc by 1",
          ~m(user user2 community post_attrs)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
@@ -29,7 +28,7 @@ defmodule GroupherServer.Test.ArticleUpvote do
       assert article.upvotes_count == 2
     end
 
-    @tag :wip
+    @tag :wip2
     test "post can be undo upvote && upvotes_count should dec by 1",
          ~m(user user2 community post_attrs)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
@@ -42,7 +41,7 @@ defmodule GroupherServer.Test.ArticleUpvote do
       assert article.upvotes_count == 0
     end
 
-    @tag :wip
+    @tag :wip2
     test "can get upvotes_users", ~m(user user2 community post_attrs)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
 
@@ -56,6 +55,7 @@ defmodule GroupherServer.Test.ArticleUpvote do
       assert user_exist_in?(user2, users.entries)
     end
 
+    @tag :wip2
     test "post meta history should be updated after upvote",
          ~m(user user2 community post_attrs)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
@@ -67,6 +67,7 @@ defmodule GroupherServer.Test.ArticleUpvote do
       assert user2.id in article.meta.upvoted_user_ids
     end
 
+    @tag :wip2
     test "post meta history should be updated after undo upvote",
          ~m(user user2 community post_attrs)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)
@@ -84,73 +85,4 @@ defmodule GroupherServer.Test.ArticleUpvote do
       assert user.id not in article.meta.upvoted_user_ids
     end
   end
-
-  describe "[cms job upvote]" do
-    @tag :wip
-    test "job can be upvote && upvotes_count should inc by 1",
-         ~m(user user2 community job_attrs)a do
-      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
-
-      {:ok, article} = CMS.upvote_article(:job, job.id, user)
-      assert article.id == job.id
-      assert article.upvotes_count == 1
-
-      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
-      assert article.upvotes_count == 2
-    end
-
-    @tag :wip
-    test "job can be undo upvote && upvotes_count should dec by 1",
-         ~m(user user2 community job_attrs)a do
-      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
-
-      {:ok, article} = CMS.upvote_article(:job, job.id, user)
-      assert article.id == job.id
-      assert article.upvotes_count == 1
-
-      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user2)
-      assert article.upvotes_count == 0
-    end
-
-    @tag :wip
-    test "can get upvotes_users", ~m(user user2 community job_attrs)a do
-      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
-
-      {:ok, _article} = CMS.upvote_article(:job, job.id, user)
-      {:ok, _article} = CMS.upvote_article(:job, job.id, user2)
-
-      {:ok, users} = CMS.upvoted_users(:job, job.id, %{page: 1, size: 2})
-
-      assert users |> is_valid_pagination?(:raw)
-      assert user_exist_in?(user, users.entries)
-      assert user_exist_in?(user2, users.entries)
-    end
-
-    test "job meta history should be updated", ~m(user user2 community job_attrs)a do
-      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
-      {:ok, article} = CMS.upvote_article(:job, job.id, user)
-      assert user.id in article.meta.upvoted_user_ids
-
-      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
-      assert user.id in article.meta.upvoted_user_ids
-      assert user2.id in article.meta.upvoted_user_ids
-    end
-
-    test "job meta history should be updated after undo upvote",
-         ~m(user user2 community job_attrs)a do
-      {:ok, job} = CMS.create_content(community, :job, job_attrs, user)
-
-      {:ok, _article} = CMS.upvote_article(:job, job.id, user)
-      {:ok, article} = CMS.upvote_article(:job, job.id, user2)
-
-      assert user.id in article.meta.upvoted_user_ids
-      assert user2.id in article.meta.upvoted_user_ids
-
-      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user2)
-      assert user2.id not in article.meta.upvoted_user_ids
-
-      {:ok, article} = CMS.undo_upvote_article(:job, job.id, user)
-      assert user.id not in article.meta.upvoted_user_ids
-    end
-  end
 end

test/groupher_server_web/query/cms/article_reaction_users_test.exs

@@ -0,0 +1,54 @@
+defmodule GroupherServer.Test.Query.Collects.PostUpvote do
+  @moduledoc false
+  use GroupherServer.TestTools
+
+  alias GroupherServer.CMS
+
+  setup do
+    {:ok, post} = db_insert(:post)
+    {:ok, user} = db_insert(:user)
+    {:ok, user2} = db_insert(:user)
+
+    guest_conn = simu_conn(:guest)
+    user_conn = simu_conn(:user, user)
+
+    {:ok, ~m(user_conn guest_conn user user2 post)a}
+  end
+
+  describe "[collect users]" do
+    @query """
+    query(
+      $id: ID!
+      $thread: CmsThread
+      $filter: PagedFilter!
+    ) {
+      collectedUsers(id: $id, thread: $thread, filter: $filter) {
+        entries {
+          id
+          avatar
+          nickname
+        }
+        totalPages
+        totalCount
+        pageSize
+        pageNumber
+      }
+    }
+    """
+    @tag :wip2
+    test "guest can get collected users list after collect a post",
+         ~m(guest_conn post user user2)a do
+      {:ok, _} = CMS.collect_article(:post, post.id, user)
+      {:ok, _} = CMS.collect_article(:post, post.id, user2)
+
+      variables = %{id: post.id, thread: "POST", filter: %{page: 1, size: 20}}
+      results = guest_conn |> query_result(@query, variables, "collectedUsers")
+
+      assert results |> is_valid_pagination?
+      assert results["totalCount"] == 2
+
+      assert user_exist_in?(user, results["entries"], :string_key)
+      assert user_exist_in?(user2, results["entries"], :string_key)
+    end
+  end
+end