refactor(changeset): enhance lint

Author: mydearxym

lib/mastani_server/accounts/delegates/fans.ex

@@ -50,6 +50,10 @@ defmodule MastaniServer.Accounts.Delegate.Fans do
     User |> ORM.find(user_follower.user_id)
   end
 
+  defp follow_result({:error, :create_follower, %Ecto.Changeset{} = result, _steps}) do
+    {:error, [message: "already followed", code: ecode(:already_did)]}
+  end
+
   defp follow_result({:error, :create_follower, _result, _steps}) do
     {:error, [message: "already followed", code: ecode(:already_did)]}
   end

lib/mastani_server/accounts/delegates/favorite_category.ex

@@ -100,6 +100,10 @@ defmodule MastaniServer.Accounts.Delegate.FavoriteCategory do
 
   defp delete_favorites_result({:ok, %{downgrade_achievement: result}}), do: {:ok, result}
 
+  defp delete_favorites_result({:error, :delete_category, %Ecto.Changeset{} = result, _steps}) do
+    {:error, result}
+  end
+
   defp delete_favorites_result({:error, :delete_category, _result, _steps}) do
     {:error, [message: "delete category fails", code: ecode(:delete_fails)]}
   end

lib/mastani_server/accounts/delegates/profile.ex

@@ -162,6 +162,9 @@ defmodule MastaniServer.Accounts.Delegate.Profile do
 
   defp register_github_result({:ok, %{create_user: user}}), do: gen_token(user)
 
+  defp register_github_result({:error, :create_user, %Ecto.Changeset{} = result, _steps}),
+    do: {:error, result}
+
   defp register_github_result({:error, :create_user, _result, _steps}),
     do: {:error, "Accounts create_user internal error"}
 

lib/mastani_server/cms/delegates/article_curd.ex

@@ -397,7 +397,10 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
 
   defp create_content_result({:ok, %{add_content_author: result}}), do: {:ok, result}
 
-  # TODO: need more spec error handle
+  defp create_content_result({:error, :add_content_author, %Ecto.Changeset{} = result, _steps}) do
+    {:error, result}
+  end
+
   defp create_content_result({:error, :add_content_author, _result, _steps}) do
     {:error, [message: "create cms content author", code: ecode(:create_fails)]}
   end

lib/mastani_server/cms/delegates/article_reaction.ex

@@ -35,6 +35,10 @@ defmodule MastaniServer.CMS.Delegate.ArticleReaction do
 
   defp reaction_result({:ok, %{create_reaction_record: result}}), do: result |> done()
 
+  defp reaction_result({:error, :create_reaction_record, %Ecto.Changeset{} = result, _steps}) do
+    {:error, result}
+  end
+
   defp reaction_result({:error, :create_reaction_record, _result, _steps}) do
     {:error, [message: "create reaction fails", code: ecode(:react_fails)]}
   end

lib/mastani_server/cms/delegates/community_operation.ex

@@ -90,6 +90,9 @@ defmodule MastaniServer.CMS.Delegate.CommunityOperation do
     User |> ORM.find(editor.user_id)
   end
 
+  defp set_editor_result({:error, :stamp_passport, %Ecto.Changeset{} = result, _steps}),
+    do: {:error, result}
+
   defp set_editor_result({:error, :stamp_passport, _result, _steps}),
     do: {:error, "stamp passport error"}
 

lib/mastani_server/cms/job.ex

@@ -80,11 +80,19 @@ defmodule MastaniServer.CMS.Job do
     job
     |> cast(attrs, @optional_fields ++ @required_fields)
     |> validate_required(@required_fields)
+    |> generl_changeset
   end
 
   @doc false
   def update_changeset(%Job{} = job, attrs) do
     job
     |> cast(attrs, @optional_fields ++ @required_fields)
+    |> generl_changeset
+  end
+
+  defp generl_changeset(content) do
+    content
+    |> validate_length(:title, min: 3, max: 50)
+    |> validate_length(:body, min: 3, max: 10_000)
   end
 end

lib/mastani_server/cms/job_comment.ex

@@ -31,15 +31,20 @@ defmodule MastaniServer.CMS.JobComment do
     job_comment
     |> cast(attrs, @required_fields ++ @optional_fields)
     |> validate_required(@required_fields)
-    |> foreign_key_constraint(:job_id)
-    |> foreign_key_constraint(:author_id)
+    |> generl_changeset
   end
 
   @doc false
   def update_changeset(%JobComment{} = job_comment, attrs) do
     job_comment
     |> cast(attrs, @required_fields ++ @optional_fields)
+    |> generl_changeset
+  end
+
+  defp generl_changeset(content) do
+    content
     |> foreign_key_constraint(:job_id)
     |> foreign_key_constraint(:author_id)
+    |> validate_length(:body, min: 3, max: 2000)
   end
 end

lib/mastani_server/cms/post.ex

@@ -87,15 +87,21 @@ defmodule MastaniServer.CMS.Post do
     post
     |> cast(attrs, @optional_fields ++ @required_fields)
     |> validate_required(@required_fields)
-
-    # |> foreign_key_constraint(:posts_tags, name: :posts_tags_tag_id_fkey)
-    # |> foreign_key_constraint(name: :posts_tags_tag_id_fkey)
+    |> generl_changeset
   end
 
   @doc false
   def update_changeset(%Post{} = post, attrs) do
     post
     |> cast(attrs, @optional_fields ++ @required_fields)
+    |> generl_changeset
+  end
+
+  defp generl_changeset(content) do
+    content
+    |> validate_length(:title, min: 3, max: 50)
+    |> validate_length(:body, min: 3, max: 10_000)
+    |> validate_length(:link_addr, min: 5, max: 200)
 
     # |> foreign_key_constraint(:posts_tags, name: :posts_tags_tag_id_fkey)
     # |> foreign_key_constraint(name: :posts_tags_tag_id_fkey)

lib/mastani_server/cms/post_comment.ex

@@ -36,15 +36,20 @@ defmodule MastaniServer.CMS.PostComment do
     post_comment
     |> cast(attrs, @required_fields ++ @optional_fields)
     |> validate_required(@required_fields)
-    |> foreign_key_constraint(:post_id)
-    |> foreign_key_constraint(:author_id)
+    |> generl_changeset
   end
 
   @doc false
   def update_changeset(%PostComment{} = post_comment, attrs) do
     post_comment
     |> cast(attrs, @required_fields ++ @optional_fields)
+    |> generl_changeset
+  end
+
+  defp generl_changeset(content) do
+    content
     |> foreign_key_constraint(:post_id)
     |> foreign_key_constraint(:author_id)
+    |> validate_length(:body, min: 3, max: 2000)
   end
 end