refactor(viewer-solution): wip

Author: mydearxym

lib/groupher_server/cms/delegates/article_reaction.ex

@@ -13,10 +13,12 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
   alias GroupherServer.{Accounts, CMS, Repo}
 
   alias Accounts.User
-  alias CMS.{ArticleUpvote, ArticleCollect}
+  alias CMS.{ArticleUpvote, ArticleCollect, Embeds}
 
   alias Ecto.Multi
 
+  @default_article_meta Embeds.ArticleMeta.default_meta()
+
   def upvoted_users(thread, article_id, filter) do
     load_reaction_users(ArticleUpvote, thread, article_id, filter)
   end
@@ -221,6 +223,20 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
           String.t(),
           :add | :remove
         ) :: T.article_common()
+  defp update_article_reaction_user_list(action, %{meta: nil} = article, user_id, opt) do
+    cur_user_ids = []
+
+    updated_user_ids =
+      case opt do
+        :add -> [user_id] ++ cur_user_ids
+        :remove -> cur_user_ids -- [user_id]
+      end
+
+    updated_meta = @default_article_meta |> Map.merge(%{"#{action}ed_user_ids": updated_user_ids})
+
+    do_update_article_meta(article, updated_meta)
+  end
+
   defp update_article_reaction_user_list(action, article, user_id, opt) do
     cur_user_ids = get_in(article, [:meta, :"#{action}ed_user_ids"])
 
@@ -230,15 +246,19 @@ defmodule GroupherServer.CMS.Delegate.ArticleReaction do
         :remove -> cur_user_ids -- [user_id]
       end
 
-    updated_meta =
+    meta =
       article.meta
       |> Map.merge(%{"#{action}ed_user_ids": updated_user_ids})
       |> Map.from_struct()
       |> Map.delete(:id)
 
+    do_update_article_meta(article, meta)
+  end
+
+  defp do_update_article_meta(article, meta) do
     article
     |> Ecto.Changeset.change()
-    |> Ecto.Changeset.put_embed(:meta, updated_meta)
+    |> Ecto.Changeset.put_embed(:meta, meta)
     |> Repo.update()
   end
 

lib/groupher_server/cms/post.ex

@@ -55,6 +55,12 @@ defmodule GroupherServer.CMS.Post do
     field(:viewer_has_collected, :boolean, default: false, virtual: true)
     field(:viewer_has_reported, :boolean, default: false, virtual: true)
 
+    has_many(:upvotes, {"article_upvotes", ArticleUpvote})
+    field(:upvotes_count, :integer, default: 0)
+
+    has_many(:collects, {"article_collects", ArticleCollect})
+    field(:collects_count, :integer, default: 0)
+
     # TODO
     # 相关文章
     # has_may(:related_post, ...)
@@ -67,12 +73,6 @@ defmodule GroupherServer.CMS.Post do
     # 评论参与者，只保留最近 5 个
     embeds_many(:article_comments_participators, Accounts.User, on_replace: :delete)
 
-    has_many(:upvotes, {"article_upvotes", ArticleUpvote})
-    field(:upvotes_count, :integer, default: 0)
-
-    has_many(:collects, {"article_collects", ArticleCollect})
-    field(:collects_count, :integer, default: 0)
-
     has_many(:viewers, {"posts_viewers", PostViewer})
     # The keys are inflected from the schema names!
     # see https://hexdocs.pm/ecto/Ecto.Schema.html

lib/groupher_server_web/schema/cms/cms_queries.ex

@@ -67,10 +67,6 @@ defmodule GroupherServerWeb.Schema.CMS.Queries do
       resolve(&R.CMS.paged_threads/3)
     end
 
-    article_queries(:post)
-    article_queries(:job)
-    article_queries(:repo)
-
     @desc "get wiki by community raw name"
     field :wiki, non_null(:wiki) do
       arg(:community, :string)
@@ -83,25 +79,12 @@ defmodule GroupherServerWeb.Schema.CMS.Queries do
       resolve(&R.CMS.cheatsheet/3)
     end
 
-    @desc "get paged upvoted users of an article"
-    field :upvoted_users, :paged_users do
-      arg(:id, non_null(:id))
-      arg(:thread, :cms_thread, default_value: :post)
-      arg(:filter, non_null(:paged_filter))
-
-      middleware(M.PageSizeProof)
-      resolve(&R.CMS.upvoted_users/3)
-    end
-
-    @desc "get paged upvoted users of an article"
-    field :collected_users, :paged_users do
-      arg(:id, non_null(:id))
-      arg(:thread, :cms_thread, default_value: :post)
-      arg(:filter, non_null(:paged_filter))
+    article_queries(:post)
+    article_queries(:job)
+    article_queries(:repo)
 
-      middleware(M.PageSizeProof)
-      resolve(&R.CMS.collected_users/3)
-    end
+    article_reacted_users_query(:upvot, &R.CMS.upvoted_users/3)
+    article_reacted_users_query(:collect, &R.CMS.collected_users/3)
 
     # get all tags
     @desc "get paged tags"

lib/groupher_server_web/schema/utils/helper.ex

@@ -123,6 +123,20 @@ defmodule GroupherServerWeb.Schema.Utils.Helper do
     end
   end
 
+  defmacro article_reacted_users_query(action, resolver) do
+    quote do
+      @desc unquote("get paged #{action}ed users of an article")
+      field unquote(:"#{action}ed_users"), :paged_users do
+        arg(:id, non_null(:id))
+        arg(:thread, :cms_thread, default_value: :post)
+        arg(:filter, non_null(:paged_filter))
+
+        middleware(M.PageSizeProof)
+        resolve(unquote(resolver))
+      end
+    end
+  end
+
   defmacro comments_fields do
     quote do
       field(:id, :id)

test/groupher_server/cms/post_test.exs

@@ -26,7 +26,7 @@ defmodule GroupherServer.Test.CMS.Post do
       assert post.title == post_attrs.title
     end
 
-    @tag :wip2
+    @tag :wip3
     test "read post should update views and meta viewed_user_list",
          ~m(post_attrs community user user2)a do
       {:ok, post} = CMS.create_content(community, :post, post_attrs, user)

test/groupher_server_web/query/cms/article_reaction_users_test.exs

@@ -36,8 +36,8 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       }
     }
     """
-    @tag :wip
-    test "guest can get favroted user list after upvote to a post",
+    @tag :wip2
+    test "guest can get upvoted users list after upvote to a post",
          ~m(guest_conn post user user2)a do
       {:ok, _} = CMS.upvote_article(:post, post.id, user)
       {:ok, _} = CMS.upvote_article(:post, post.id, user2)
@@ -52,8 +52,8 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       assert user_exist_in?(user2, results["entries"], :string_key)
     end
 
-    @tag :wip
-    test "guest can get favroted user list after upvote to a job",
+    @tag :wip3
+    test "guest can get upvoted users list after upvote to a job",
          ~m(guest_conn job user user2)a do
       {:ok, _} = CMS.upvote_article(:job, job.id, user)
       {:ok, _} = CMS.upvote_article(:job, job.id, user2)
@@ -89,8 +89,9 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       }
     }
     """
-    @tag :wip
-    test "guest can get stared user list after collect a post", ~m(guest_conn post user user2)a do
+    @tag :wip3
+    test "guest can get collected users list after collect a post",
+         ~m(guest_conn post user user2)a do
       {:ok, _} = CMS.collect_article(:post, post.id, user)
       {:ok, _} = CMS.collect_article(:post, post.id, user2)
 
@@ -104,8 +105,9 @@ defmodule GroupherServer.Test.Query.ArticleReactionUsers do
       assert user_exist_in?(user2, results["entries"], :string_key)
     end
 
-    @tag :wip
-    test "guest can get stared user list after collect a job", ~m(guest_conn job user user2)a do
+    @tag :wip3
+    test "guest can get collected users list after collect a job",
+         ~m(guest_conn job user user2)a do
       {:ok, _} = CMS.collect_article(:job, job.id, user)
       {:ok, _} = CMS.collect_article(:job, job.id, user2)
 

test/groupher_server_web/query/cms/job_test.exs

@@ -19,7 +19,7 @@ defmodule GroupherServer.Test.Query.Job do
     }
   }
   """
-  @tag :wip2
+  @tag :wip3
   test "basic graphql query on job with logined user", ~m(user_conn job)a do
     variables = %{id: job.id}
     results = user_conn |> query_result(@query, variables, "job")
@@ -30,7 +30,7 @@ defmodule GroupherServer.Test.Query.Job do
     assert length(Map.keys(results)) == 3
   end
 
-  @tag :wip2
+  @tag :wip3
   test "basic graphql query on job with stranger(unloged user)", ~m(guest_conn job)a do
     variables = %{id: job.id}
     results = guest_conn |> query_result(@query, variables, "job")

test/groupher_server_web/query/cms/paged_jobs_test.exs

@@ -97,7 +97,7 @@ defmodule GroupherServer.Test.Query.PagedJobs do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/paged_posts_test.exs

@@ -170,7 +170,7 @@ defmodule GroupherServer.Test.Query.PagedPosts do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)

test/groupher_server_web/query/cms/paged_repos_test.exs

@@ -93,7 +93,7 @@ defmodule GroupherServer.Test.Query.PagedRepos do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "has_xxx state should work", ~m(user)a do
       user_conn = simu_conn(:user, user)
       {:ok, community} = db_insert(:community)