feat(post-qa): solution digest edge case

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment.ex

@@ -134,6 +134,14 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   @doc """
   update a comment for article like psot, job ...
   """
+  # 如果是 solution, 那么要更新对应的 post 的 solution_digest
+  def update_article_comment(%ArticleComment{is_solution: true} = article_comment, content) do
+    with {:ok, post} <- ORM.find(Post, article_comment.post_id) do
+      post |> ORM.update(%{solution_digest: content})
+      article_comment |> ORM.update(%{body_html: content})
+    end
+  end
+
   def update_article_comment(%ArticleComment{} = article_comment, content) do
     article_comment |> ORM.update(%{body_html: content})
   end

test/groupher_server/cms/articles/post_test.exs

@@ -148,23 +148,20 @@ defmodule GroupherServer.Test.CMS.Articles.Post do
   end
 
   describe "[cms post question]" do
-    @tag :wip2
     test "post have default question flags", ~m(user community post_attrs)a do
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
 
       assert not post.is_question
       assert not post.is_solved
     end
 
-    @tag :wip2
     test "can create post with question", ~m(user community post_attrs)a do
       post_attrs = Map.merge(post_attrs, %{is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
 
       assert post.is_question
     end
 
-    @tag :wip2
     test "can update post with question", ~m(user community post_attrs)a do
       post_attrs = Map.merge(post_attrs, %{is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)

test/groupher_server/cms/comments/post_comment_test.exs

@@ -670,7 +670,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
   end
 
   describe "[article comment qa type]" do
-    @tag :wip2
     test "create comment for normal post should have default qa flags", ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -680,7 +679,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert not post_comment.is_solution
     end
 
-    @tag :wip2
     test "create comment for question post should have flags", ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -690,7 +688,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert post_comment.is_for_question
     end
 
-    @tag :wip2
     test "update comment with is_question should batch update exsit comments is_for_question field",
          ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
@@ -714,7 +711,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert not comment3.is_for_question
     end
 
-    @tag :wip2
     test "can mark a comment as solution", ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -732,7 +728,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert post.solution_digest == comment.body_html
     end
 
-    @tag :wip2
     test "non-post-author can not mark a comment as solution", ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -747,7 +742,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       reason |> is_error?(:require_questioner)
     end
 
-    @tag :wip2
     test "can undo mark a comment as solution", ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -765,7 +759,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert not post.is_solved
     end
 
-    @tag :wip2
     test "non-post-author can not undo mark a comment as solution", ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -780,7 +773,6 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       reason |> is_error?(:require_questioner)
     end
 
-    @tag :wip2
     test "can only mark one best comment as solution", ~m(user community)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
@@ -801,5 +793,23 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert answers |> length == 1
       assert answers |> List.first() |> Map.get(:id) == comment2.id
     end
+
+    test "update a solution should also update post's solution digest", ~m(user community)a do
+      post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})
+      {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
+
+      {:ok, post} = ORM.find(Post, post.id, preload: [author: :user])
+      post_author = post.author.user
+
+      {:ok, comment} = CMS.create_article_comment(:post, post.id, "solution", post_author)
+      {:ok, comment} = CMS.mark_comment_solution(comment.id, post_author)
+
+      {:ok, post} = ORM.find(Post, post.id, preload: [author: :user])
+      assert post.solution_digest == "solution"
+
+      {:ok, _comment} = CMS.update_article_comment(comment, "new solution")
+      {:ok, post} = ORM.find(Post, post.id, preload: [author: :user])
+      assert post.solution_digest == "new solution"
+    end
   end
 end

test/groupher_server_web/query/cms/comments/job_comment_test.exs

@@ -240,7 +240,6 @@ defmodule GroupherServer.Test.Query.Comments.JobComment do
       assert results["totalCount"] == total_count
     end
 
-    @tag :wip
     test "guest user can get paged comment with pinned comment in it",
          ~m(guest_conn job user)a do
       total_count = 20

test/groupher_server_web/query/cms/comments/post_comment_test.exs

@@ -242,7 +242,6 @@ defmodule GroupherServer.Test.Query.Comments.PostComment do
       assert results["totalCount"] == total_count
     end
 
-    @tag :wip
     test "guest user can get paged comment with pinned comment in it",
          ~m(guest_conn post user)a do
       total_count = 20
@@ -272,7 +271,7 @@ defmodule GroupherServer.Test.Query.Comments.PostComment do
     end
 
     # post only
-    @tag :wip
+
     test "if solution in pinned comments, solution should always on top",
          ~m(guest_conn community user)a do
       post_attrs = mock_attrs(:post, %{community_id: community.id, is_question: true})

test/groupher_server_web/query/cms/comments/repo_comment_test.exs

@@ -238,7 +238,6 @@ defmodule GroupherServer.Test.Query.Comments.RepoComment do
       assert results["totalCount"] == total_count
     end
 
-    @tag :wip
     test "guest user can get paged comment with pinned comment in it",
          ~m(guest_conn repo user)a do
       total_count = 20