fix(article-comments): rename pined -> pinned

Author: mydearxym

lib/groupher_server/cms/article_comment.ex

@@ -33,7 +33,7 @@ defmodule GroupherServer.CMS.ArticleComment do
   @report_threshold_for_fold 5
 
   # 每篇文章最多含有置顶评论的条数
-  @pined_comment_limit 10
+  @pinned_comment_limit 10
 
   @doc "latest participators stores in article article_comment_participators field"
   def max_participator_count(), do: @max_participator_count
@@ -47,7 +47,7 @@ defmodule GroupherServer.CMS.ArticleComment do
   def delete_hint(), do: @delete_hint
 
   def report_threshold_for_fold, do: @report_threshold_for_fold
-  def pined_comment_limit, do: @pined_comment_limit
+  def pinned_comment_limit, do: @pinned_comment_limit
 
   @type t :: %ArticleComment{}
   schema "articles_comments" do

lib/groupher_server/cms/delegates/article_comment.ex

@@ -23,7 +23,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   @delete_hint ArticleComment.delete_hint()
 
   @default_comment_meta Embeds.ArticleCommentMeta.default_meta()
-  @pined_comment_limit ArticleComment.pined_comment_limit()
+  @pinned_comment_limit ArticleComment.pinned_comment_limit()
 
   @doc """
   [timeline-mode] list paged article comments
@@ -248,7 +248,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
 
         _ ->
           preloaded_pined_comments =
-            Enum.slice(pined_comments, 0, @pined_comment_limit) |> Repo.preload(reply_to: :author)
+            Enum.slice(pined_comments, 0, @pinned_comment_limit)
+            |> Repo.preload(reply_to: :author)
 
           entries = Enum.concat(preloaded_pined_comments, entries)
           pined_comment_count = length(pined_comments)

lib/groupher_server/cms/delegates/article_comment_action.ex

@@ -32,7 +32,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentAction do
 
   @article_threads Community.article_threads()
   @max_parent_replies_count ArticleComment.max_parent_replies_count()
-  @pined_comment_limit ArticleComment.pined_comment_limit()
+  @pinned_comment_limit ArticleComment.pinned_comment_limit()
 
   @spec pin_article_comment(Integer.t()) :: {:ok, ArticleComment.t()}
   @doc "pin a comment"
@@ -49,8 +49,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentAction do
 
         pined_comments_count = Repo.aggregate(count_query, :count)
 
-        case pined_comments_count >= @pined_comment_limit do
-          true -> {:error, "only support #{@pined_comment_limit} pined comment for each article"}
+        case pined_comments_count >= @pinned_comment_limit do
+          true -> {:error, "only support #{@pinned_comment_limit} pinned comment for each article"}
           false -> {:ok, :pass}
         end
       end)

lib/groupher_server/cms/delegates/article_community.ex

@@ -201,7 +201,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
 
   def lock_article_comment(content), do: {:ok, content}
 
-  # check if the thread has aready enough pined articles
+  # check if the thread has aready enough pinned articles
   defp check_pinned_article_count(community_id, thread) do
     thread_upcase = thread |> to_string |> String.upcase()
 

lib/groupher_server/cms/delegates/article_curd.ex

@@ -305,7 +305,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
            |> join(:inner, [p], article in assoc(p, ^thread))
            |> where([p, c, article], c.raw == ^community)
            |> select([p, c, article], article)
-           # 10 pined articles per community/thread, at most
+           # 10 pinned articles per community/thread, at most
            |> ORM.find_all(%{page: 1, size: 10}) do
       concat_articles(pinned_articles, articles)
     else
@@ -334,7 +334,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
 
     normal_count = non_pinned_articles |> Map.get(:total_count)
 
-    # remote the pined article from normal_entries (if have)
+    # remote the pinned article from normal_entries (if have)
     pind_ids = pick_by(pinned_entries, :id)
     normal_entries = Enum.reject(normal_entries, &(&1.id in pind_ids))
 

test/groupher_server/cms/comments/job_comment_test.exs

@@ -11,7 +11,7 @@ defmodule GroupherServer.Test.CMS.Comments.JobComment do
   @delete_hint CMS.ArticleComment.delete_hint()
   @report_threshold_for_fold ArticleComment.report_threshold_for_fold()
   @default_comment_meta Embeds.ArticleCommentMeta.default_meta()
-  @pined_comment_limit ArticleComment.pined_comment_limit()
+  @pinned_comment_limit ArticleComment.pinned_comment_limit()
 
   setup do
     {:ok, user} = db_insert(:user)
@@ -240,10 +240,10 @@ defmodule GroupherServer.Test.CMS.Comments.JobComment do
       assert {:error, _} = ArticlePinnedComment |> ORM.find_by(%{article_comment_id: comment.id})
     end
 
-    test "pined comments has a limit for each article", ~m(user job)a do
+    test "pinned comments has a limit for each article", ~m(user job)a do
       {:ok, comment} = CMS.create_article_comment(:job, job.id, "commment", user)
 
-      Enum.reduce(0..(@pined_comment_limit - 1), [], fn _, _acc ->
+      Enum.reduce(0..(@pinned_comment_limit - 1), [], fn _, _acc ->
         {:ok, _comment} = CMS.pin_article_comment(comment.id)
       end)
 
@@ -374,7 +374,7 @@ defmodule GroupherServer.Test.CMS.Comments.JobComment do
       assert total_count == paged_comments.total_count
     end
 
-    test "paged article comments should contains pined comments at top position",
+    test "paged article comments should contains pinned comments at top position",
          ~m(user job)a do
       total_count = 20
       page_number = 1
@@ -401,7 +401,7 @@ defmodule GroupherServer.Test.CMS.Comments.JobComment do
       assert paged_comments.total_count == total_count + 2
     end
 
-    test "only page 1 have pined coments",
+    test "only page 1 have pinned coments",
          ~m(user job)a do
       total_count = 20
       page_number = 2
@@ -533,7 +533,7 @@ defmodule GroupherServer.Test.CMS.Comments.JobComment do
       assert job.article_comments_count == 4
     end
 
-    test "delete comment still delete pined record if needed", ~m(user job)a do
+    test "delete comment still delete pinned record if needed", ~m(user job)a do
       total_count = 10
 
       all_comments =

test/groupher_server/cms/comments/post_comment_test.exs

@@ -11,7 +11,7 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
   @delete_hint CMS.ArticleComment.delete_hint()
   @report_threshold_for_fold ArticleComment.report_threshold_for_fold()
   @default_comment_meta Embeds.ArticleCommentMeta.default_meta()
-  @pined_comment_limit ArticleComment.pined_comment_limit()
+  @pinned_comment_limit ArticleComment.pinned_comment_limit()
 
   setup do
     {:ok, user} = db_insert(:user)
@@ -240,10 +240,10 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert {:error, _} = ArticlePinnedComment |> ORM.find_by(%{article_comment_id: comment.id})
     end
 
-    test "pined comments has a limit for each article", ~m(user post)a do
+    test "pinned comments has a limit for each article", ~m(user post)a do
       {:ok, comment} = CMS.create_article_comment(:post, post.id, "commment", user)
 
-      Enum.reduce(0..(@pined_comment_limit - 1), [], fn _, _acc ->
+      Enum.reduce(0..(@pinned_comment_limit - 1), [], fn _, _acc ->
         {:ok, _comment} = CMS.pin_article_comment(comment.id)
       end)
 
@@ -379,7 +379,7 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert total_count == paged_comments.total_count
     end
 
-    test "paged article comments should contains pined comments at top position",
+    test "paged article comments should contains pinned comments at top position",
          ~m(user post)a do
       total_count = 20
       page_number = 1
@@ -411,7 +411,7 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert paged_comments.total_count == total_count + 2
     end
 
-    test "only page 1 have pined coments",
+    test "only page 1 have pinned coments",
          ~m(user post)a do
       total_count = 20
       page_number = 2
@@ -558,7 +558,7 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert post.article_comments_count == 4
     end
 
-    test "delete comment still delete pined record if needed", ~m(user post)a do
+    test "delete comment still delete pinned record if needed", ~m(user post)a do
       total_count = 10
 
       all_comments =

test/groupher_server_web/query/cms/flags/jobs_flags_test.exs

@@ -49,7 +49,7 @@ defmodule GroupherServer.Test.Query.Flags.JobsFlags do
     }
     """
 
-    test "if have pined jobs, the pined jobs should at the top of entries",
+    test "if have pinned jobs, the pinned jobs should at the top of entries",
          ~m(guest_conn community job_m)a do
       variables = %{filter: %{community: community.raw}}
       # variables = %{filter: %{}}

test/groupher_server_web/query/cms/flags/posts_flags_test.exs

@@ -49,7 +49,7 @@ defmodule GroupherServer.Test.Query.Flags.PostsFlags do
     }
     """
 
-    test "if have pined posts, the pined posts should at the top of entries",
+    test "if have pinned posts, the pinned posts should at the top of entries",
          ~m(guest_conn community post_m)a do
       variables = %{filter: %{community: community.raw}}
       # variables = %{filter: %{}}

test/groupher_server_web/query/cms/flags/repos_flags_test.exs

@@ -49,7 +49,7 @@ defmodule GroupherServer.Test.Query.Flags.ReposFlags do
     }
     """
 
-    test "if have pined repos, the pined repos should at the top of entries",
+    test "if have pinned repos, the pinned repos should at the top of entries",
          ~m(guest_conn community repo_m)a do
       variables = %{filter: %{community: community.raw}}
       # variables = %{filter: %{}}