chore(article-comments): wip && clean up

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment.ex

@@ -68,7 +68,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     do_paged_comment_replies(comment_id, filters, user)
   end
 
-  @spec paged_article_comments_participators(T.comment_thread(), Integer.t(), T.paged_filter()) ::
+  @spec paged_article_comments_participators(T.article_thread(), Integer.t(), T.paged_filter()) ::
           {:ok, T.paged_users()}
   def paged_article_comments_participators(thread, article_id, filters) do
     %{page: page, size: size} = filters

lib/groupher_server/cms/delegates/article_comment_action.ex

@@ -260,7 +260,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentAction do
 
   defp get_article(%ArticleComment{repo_id: repo_id} = comment) when not is_nil(repo_id) do
     with {:ok, article} <- ORM.find(CMS.Repo, comment.repo_id, preload: [author: :user]) do
-      {:job, article}
+      {:repo, article}
     end
   end
 

lib/helper/types.ex

@@ -34,7 +34,6 @@ defmodule Helper.Types do
         }
 
   @type article_thread :: :post | :job | :repo
-  @type comment_thread :: :post | :job
 
   @type paged_filter :: %{
           page: Integer.t(),

test/groupher_server_web/query/cms/comments/repo_comment_test.exs

@@ -154,7 +154,7 @@ defmodule GroupherServer.Test.Query.Comments.RepoComment do
                to_string(replyed_comment_2.id)
     end
 
-    @tag :wip
+    @tag :wip2
     test "timeline-mode paged comments", ~m(guest_conn repo user user2)a do
       total_count = 3
       page_size = 20
@@ -363,7 +363,6 @@ defmodule GroupherServer.Test.Query.Comments.RepoComment do
       assert List.last(results["entries"]) |> Map.get("id") == to_string(comment.id)
     end
 
-    @tag :wip2
     test "guest user can get paged comment with upvotes_count", ~m(guest_conn repo user user2)a do
       total_count = 10
       page_size = 10