refactor(post-meta): fix ci tests & warnings

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment.ex

@@ -458,6 +458,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   defp upsert_comment_result({:ok, %{add_reply_to: result}}), do: {:ok, result}
   defp upsert_comment_result({:ok, %{inc_upvotes_count: result}}), do: {:ok, result}
   defp upsert_comment_result({:ok, %{update_report_flag: result}}), do: {:ok, result}
+  defp upsert_comment_result({:ok, %{update_comment_emotion: result}}), do: {:ok, result}
 
   defp upsert_comment_result({:error, :create_comment, result, _steps}) do
     {:error, result}

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -11,7 +11,6 @@ defmodule GroupherServerWeb.Resolvers.CMS do
   alias CMS.{Post, Repo, Job, Community, Category, Tag, Thread}
 
   alias Helper.ORM
-  alias Helper.Utils
 
   # #######################
   # community ..

lib/groupher_server_web/schema/cms/cms_types.ex

@@ -8,7 +8,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
   import Ecto.Query, warn: false
   import Absinthe.Resolution.Helpers, only: [dataloader: 2, on_load: 2]
 
-  alias GroupherServer.{CMS, Accounts}
+  alias GroupherServer.CMS
   alias GroupherServerWeb.Schema
 
   import_types(Schema.CMS.Misc)

lib/groupher_server_web/schema/utils/helper.ex

@@ -215,30 +215,6 @@ defmodule GroupherServerWeb.Schema.Utils.Helper do
         middleware(M.ViewerDidConvert)
       end
 
-      field :dislikes, list_of(:user) do
-        arg(:filter, :members_filter)
-
-        middleware(M.PageSizeProof)
-        resolve(dataloader(CMS, :dislikes))
-      end
-
-      field :viewer_has_disliked, :boolean do
-        arg(:viewer_did, :viewer_did_type, default_value: :viewer_did)
-
-        middleware(M.Authorize, :login)
-        # put current user into dataloader's args
-        middleware(M.PutCurrentUser)
-        resolve(dataloader(CMS, :dislikes))
-        middleware(M.ViewerDidConvert)
-      end
-
-      field :dislikes_count, :integer do
-        arg(:count, :count_type, default_value: :count)
-
-        resolve(dataloader(CMS, :dislikes))
-        middleware(M.ConvertToInt)
-      end
-
       field :replies, list_of(:comment) do
         arg(:filter, :members_filter)
 

lib/helper/query_builder.ex

@@ -133,9 +133,6 @@ defmodule Helper.QueryBuilder do
       {:sort, :most_likes}, queryable ->
         queryable |> sort_by_count(:likes, :desc)
 
-      {:sort, :most_dislikes}, queryable ->
-        queryable |> sort_by_count(:dislikes, :desc)
-
       {:length, :most_words}, queryable ->
         queryable |> order_by(desc: :length)
 

test/groupher_server/cms/article_comment_replies_test.exs

@@ -134,7 +134,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommentReplies do
 
   describe "[paged article comment replies]" do
     @tag :wip
-    test "can get paged replies of a parent comment", ~m(post user user2)a do
+    test "can get paged replies of a parent comment", ~m(post user)a do
       {:ok, parent_comment} = CMS.create_article_comment(:post, post.id, "parent_conent", user)
       {:ok, paged_replies} = CMS.list_comment_replies(parent_comment.id, %{page: 1, size: 20})
       assert is_valid_pagination?(paged_replies, :raw, :empty)

test/groupher_server/cms/article_comment_test.exs

@@ -6,7 +6,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
   alias Helper.ORM
   alias GroupherServer.CMS
 
-  alias CMS.{ArticleComment, Post}
+  alias CMS.{ArticleComment, Post, Job}
 
   @delete_hint CMS.ArticleComment.delete_hint()
   @report_threshold_for_fold ArticleComment.report_threshold_for_fold()
@@ -21,7 +21,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
   end
 
   describe "[basic article comment]" do
-    @tag :wip
+    @tag :wip2
     test "post, job are supported by article comment.", ~m(user post job)a do
       post_comment_1 = "post_comment 1"
       post_comment_2 = "post_comment 2"
@@ -209,7 +209,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert not comment.is_reported
       assert not comment.is_folded
 
-      Enum.reduce(1..(@report_threshold_for_fold - 1), [], fn _, acc ->
+      Enum.reduce(1..(@report_threshold_for_fold - 1), [], fn _, _acc ->
         {:ok, user} = db_insert(:user)
         {:ok, _comment} = CMS.report_article_comment(comment.id, user)
       end)
@@ -226,7 +226,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
       assert not comment.is_reported
       assert not comment.is_folded
 
-      Enum.reduce(1..(@report_threshold_for_fold + 1), [], fn _, acc ->
+      Enum.reduce(1..(@report_threshold_for_fold + 1), [], fn _, _acc ->
         {:ok, user} = db_insert(:user)
         {:ok, _comment} = CMS.report_article_comment(comment.id, user)
       end)

test/groupher_server_web/mutation/cms/post_test.exs

@@ -631,7 +631,7 @@ defmodule GroupherServer.Test.Mutation.Post do
     }
     """
     @tag :wip
-    test "write comment to a exsit post", ~m(post user_conn community)a do
+    test "write comment to a exsit post", ~m(post user_conn)a do
       comment = "a test comment"
       variables = %{thread: "POST", id: post.id, content: comment}
 

test/groupher_server_web/query/cms/post_comment_test.exs

@@ -222,7 +222,6 @@ defmodule GroupherServer.Test.Query.PostComment do
         entries {
           id
           likesCount
-          dislikesCount
         }
         totalPages
         totalCount
@@ -286,43 +285,6 @@ defmodule GroupherServer.Test.Query.PostComment do
       assert entries |> Enum.at(1) |> Map.get("likesCount") == 4
     end
 
-    test "MOST_DISLIKES filter should work", ~m(guest_conn post user community)a do
-      body = "test comment"
-
-      comments =
-        Enum.reduce(1..10, [], fn _, acc ->
-          {:ok, value} =
-            CMS.create_comment(:post, post.id, %{community: community.raw, body: body}, user)
-
-          acc ++ [value]
-        end)
-
-      [comment_1, _comment_2, comment_3, _comment_last] = comments |> firstn_and_last(3)
-      {:ok, [user_1, user_2, user_3, user_4, user_5]} = db_insert_multi(:user, 5)
-
-      # comment_3 is most likes
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_3.id, user_1)
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_3.id, user_2)
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_3.id, user_3)
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_3.id, user_4)
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_3.id, user_5)
-
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_1.id, user_1)
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_1.id, user_2)
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_1.id, user_3)
-      {:ok, _} = CMS.dislike_comment(:post_comment, comment_1.id, user_4)
-
-      variables = %{id: post.id, filter: %{page: 1, size: 10, sort: "MOST_DISLIKES"}}
-      results = guest_conn |> query_result(@query, variables, "pagedComments")
-      entries = results["entries"]
-
-      assert entries |> Enum.at(0) |> Map.get("id") == to_string(comment_3.id)
-      assert entries |> Enum.at(0) |> Map.get("dislikesCount") == 5
-
-      assert entries |> Enum.at(1) |> Map.get("id") == to_string(comment_1.id)
-      assert entries |> Enum.at(1) |> Map.get("dislikesCount") == 4
-    end
-
     @query """
     query($id: ID!, $filter: CommentsFilter!) {
       pagedComments(id: $id, filter: $filter) {
@@ -399,47 +361,6 @@ defmodule GroupherServer.Test.Query.PostComment do
       assert found["likes"] |> Enum.any?(&(&1["id"] == to_string(user.id)))
     end
 
-    @query """
-    query($id: ID!, $filter: CommentsFilter!) {
-      pagedComments(id: $id, filter: $filter) {
-        entries {
-          id
-          body
-          author {
-            id
-            nickname
-          }
-          dislikesCount
-          dislikes {
-            id
-            nickname
-          }
-        }
-      }
-    }
-    """
-    test "guest user can get dislikes info", ~m(guest_conn post user community)a do
-      body = "test comment"
-
-      {:ok, comment} =
-        CMS.create_comment(:post, post.id, %{community: community.raw, body: body}, user)
-
-      {:ok, _like} = CMS.dislike_comment(:post_comment, comment.id, user)
-
-      variables = %{id: post.id, filter: %{page: 1, size: 10}}
-      results = guest_conn |> query_result(@query, variables, "pagedComments")
-
-      found =
-        results["entries"] |> Enum.filter(&(&1["id"] == to_string(comment.id))) |> List.first()
-
-      author = found |> Map.get("author")
-
-      assert author["id"] == to_string(user.id)
-      assert found["dislikesCount"] == 1
-
-      assert found["dislikes"] |> Enum.any?(&(&1["id"] == to_string(user.id)))
-    end
-
     @query """
     query($id: ID!, $filter: CommentsFilter!) {
       pagedComments(id: $id, filter: $filter) {