refactor(c11n): replace with new c11n stradgy

Author: mydearxym

lib/mastani_server/accounts/accounts.ex

@@ -3,7 +3,6 @@ defmodule MastaniServer.Accounts do
 
   alias MastaniServer.Accounts.Delegate.{
     Achievements,
-    Billing,
     Customization,
     Fans,
     FavoriteCategory,
@@ -61,11 +60,6 @@ defmodule MastaniServer.Accounts do
   defdelegate mark_mail_read_all(user, opt), to: Mails
   defdelegate mark_mail_read(mail, user), to: Mails
 
-  # purchase
-  defdelegate purchase_service(user, key, value), to: Billing
-  defdelegate purchase_service(user, key), to: Billing
-  defdelegate has_purchased?(user, key), to: Billing
-
   # customization
   defdelegate get_customization(user), to: Customization
   defdelegate set_customization(user, key, value), to: Customization

lib/mastani_server/accounts/delegates/billing.ex

@@ -48,80 +48,63 @@ defmodule MastaniServer.Accounts.Delegate.Customization do
   """
   # for map_size
   # see https://stackoverflow.com/questions/33248816/pattern-match-function-against-empty-map
+
   def set_customization(%User{} = _user, map) when map_size(map) == 0 do
-    {:error, "AccountCustomization: invalid option or not purchased"}
+    {:error, "AccountCustomization: invalid option or not member"}
   end
 
-  def set_customization(%User{} = user, map) when is_map(map) do
-    map = map |> map_atom_value(:string)
+  def set_customization(%User{id: user_id} = user, map) when is_map(map) do
+    with {:ok, %{achievement: achievement}} <- ORM.find(User, user_id, preload: :achievement) do
+      map = map |> map_atom_value(:string)
 
-    valid? =
-      map
-      |> Map.keys()
-      |> Enum.all?(&can_set?(user, &1, :boolean))
+      valid? =
+        map
+        |> Map.keys()
+        |> Enum.all?(&c11n_item_require?(&1, achievement))
 
-    case valid? do
-      true ->
-        attrs = Map.merge(%{user_id: user.id}, map)
-        Customization |> ORM.upsert_by([user_id: user.id], attrs)
+      case valid? do
+        true ->
+          attrs = Map.merge(%{user_id: user.id}, map)
+          Customization |> ORM.upsert_by([user_id: user.id], attrs)
 
-      false ->
-        {:error, "AccountCustomization: invalid option or not purchased"}
+        false ->
+          {:error, "AccountCustomization: invalid option or not member"}
+      end
     end
   end
 
   def set_customization(%User{} = user, key, value \\ true) do
-    with {:ok, key} <- can_set?(user, key) do
-      attrs = Map.put(%{user_id: user.id}, key, value)
-      Customization |> ORM.upsert_by([user_id: user.id], attrs)
-    end
-  end
-
-  defp can_set?(%User{} = user, key, :boolean) do
-    case can_set?(%User{} = user, key) do
-      {:ok, _} -> true
-      {:error, _} -> false
-    end
-  end
-
-  def can_set?(%User{} = user, key) do
-    cond do
-      key in valid_custom_items(:free) ->
-        {:ok, key}
-
-      key in valid_custom_items(:advance) ->
-        Accounts.has_purchased?(user, key)
-
-      true ->
-        {:error, "AccountCustomization: invalid option"}
+    with {:ok, %{achievement: achievement}} <- ORM.find(User, user.id, preload: :achievement) do
+      case c11n_item_require?(key, achievement) do
+        true ->
+          attrs = Map.put(%{user_id: user.id}, key, value)
+          Customization |> ORM.upsert_by([user_id: user.id], attrs)
+
+        false ->
+          {:error, "AccountCustomization: invalid option or not member"}
+      end
     end
   end
 
-  @doc """
-  # theme           --  user can set a default theme
-  # sidebar_layout  --  user can arrange subscribed community index
-  """
-  def valid_custom_items(:free) do
-    [
-      :sidebar_layout,
-      :sidebar_communities_index,
-      :banner_layout,
-      :contents_layout,
-      :content_divider,
-      :mark_viewed,
-      :display_density
-    ]
+  defp c11n_item_require?(:theme, %{
+         donate_member: donate_member,
+         seninor_member: seninor_member,
+         sponsor_member: sponsor_member
+       }) do
+    donate_member or seninor_member or sponsor_member
   end
 
-  @doc """
-  # :brainwash_free    --  ads free
-  # ::community_chart  --  user can access comunity charts
-  """
-  def valid_custom_items(:advance) do
-    # NOTE: :brainwash_free aka. "ads_free"
-    # use brainwash to avoid brower-block-plugins
-    [:theme, :brainwash_free, :community_chart]
-  end
+  defp c11n_item_require?(:banner_layout, _), do: true
+  defp c11n_item_require?(:contents_layout, _), do: true
+  defp c11n_item_require?(:content_divider, _), do: true
+  defp c11n_item_require?(:mark_viewed, _), do: true
+  defp c11n_item_require?(:display_density, _), do: true
+  defp c11n_item_require?(:sidebar_layout, _), do: true
+  defp c11n_item_require?(:sidebar_communities_index, _), do: true
+  # defp c11n_item_require?(:brainwash_free, _), do: true
+  # defp c11n_item_require?(:community_chart, _), do: true
+
+  defp c11n_item_require?(_, _), do: false
 
   defp filter_nil_value(map) do
     for {k, v} <- map, !is_nil(v), into: %{}, do: {k, v}

lib/mastani_server/accounts/delegates/customization.ex

@@ -12,25 +12,23 @@ defmodule MastaniServer.Test.Accounts.Customization do
   end
 
   describe "[user customization]" do
+    @tag :wip
     test "user can have default customization without payment", ~m(user)a do
       {:ok, result} = Accounts.set_customization(user, :banner_layout, "digest")
       assert result.banner_layout == "digest"
-
-      {:error, _result} = Accounts.set_customization(user, :non_exsit, true)
     end
 
-    test "user set advance customization without payment fails", ~m(user)a do
-      {:error, _result} = Accounts.set_customization(user, :non_exsit, true)
-      {:error, _result} = Accounts.set_customization(user, :brainwash_free, true)
+    @tag :wip
+    test "user set non exsit customization fails", ~m(user)a do
+      {:error, _} = Accounts.set_customization(user, :non_exsit, true)
     end
 
-    test "user can set advance customization after pay for it", ~m(user)a do
-      {:error, _result} = Accounts.set_customization(user, :brainwash_free, true)
-      {:ok, _result} = Accounts.purchase_service(user, :brainwash_free)
-
-      {:ok, _result} = Accounts.set_customization(user, :brainwash_free, true)
+    @tag :wip2
+    test "user set advance customization without payment fails", ~m(user)a do
+      {:error, _} = Accounts.set_customization(user, :theme, "blue")
     end
 
+    @tag :wip2
     test "user can set multiable customization at once", ~m(user)a do
       {:ok, result} =
         Accounts.set_customization(user, %{
@@ -48,18 +46,5 @@ defmodule MastaniServer.Test.Accounts.Customization do
 
       assert {:error, _result} = Accounts.set_customization(user, %{})
     end
-
-    test "user can purchase multiable items at once", ~m(user)a do
-      {:ok, result} =
-        Accounts.purchase_service(user, %{brainwash_free: true, community_chart: true})
-
-      assert result.brainwash_free == true
-      assert result.community_chart == true
-
-      assert {:error, _result} =
-               Accounts.purchase_service(user, %{brainwash_free: true, no_exsit: true})
-
-      assert {:error, _result} = Accounts.purchase_service(user, %{})
-    end
   end
 end

test/mastani_server/accounts/customization_test.exs

@@ -96,7 +96,7 @@ defmodule MastaniServer.Test.Billing do
       assert achievement.seninor_member == true
     end
 
-    @tag :wip2
+    @tag :wip
     test "sponsor updgrade to seninor_member after bill handled", ~m(user valid_attrs)a do
       attrs = valid_attrs |> Map.merge(%{amount: 0, payment_usage: "sponsor"})
 

test/mastani_server/billing/billing_test.exs

@@ -1,8 +1,12 @@
 defmodule MastaniServer.Test.Mutation.Billing.Basic do
   use MastaniServer.TestTools
 
+  import Helper.Utils
+
   alias MastaniServer.Billing
 
+  @seninor_amount_threshold get_config(:general, :seninor_amount_threshold)
+
   setup do
     {:ok, user} = db_insert(:user)