refactor(article): add thread to meta when create

Author: mydearxym

lib/groupher_server/cms/delegates/article_curd.ex

@@ -6,7 +6,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
 
   import GroupherServer.CMS.Helper.Matcher
 
-  import Helper.Utils, only: [done: 1, pick_by: 2, module_to_atom: 1, get_config: 2, ensure: 2]
+  import Helper.Utils,
+    only: [done: 1, pick_by: 2, module_to_atom: 1, get_config: 2, ensure: 2, module_to_upcase: 1]
 
   import GroupherServer.CMS.Delegate.Helper, only: [mark_viewer_emotion_states: 2]
   import Helper.ErrorCode
@@ -384,6 +385,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   defp do_create_article(model, attrs, %Author{id: author_id}, %Community{id: community_id}) do
     # special article like Repo do not have :body, assign it with default-empty rich text
     body = Map.get(attrs, :body, Converter.Article.default_rich_text())
+    meta = @default_article_meta |> Map.merge(%{thread: module_to_upcase(model)})
     attrs = attrs |> Map.merge(%{body: body})
 
     with {:ok, attrs} <- add_rich_text_attrs(attrs) do
@@ -392,7 +394,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
       |> Ecto.Changeset.put_change(:emotions, @default_emotions)
       |> Ecto.Changeset.put_change(:author_id, author_id)
       |> Ecto.Changeset.put_change(:original_community_id, community_id)
-      |> Ecto.Changeset.put_embed(:meta, @default_article_meta)
+      |> Ecto.Changeset.put_embed(:meta, meta)
       |> Repo.insert()
     end
   end

lib/groupher_server/cms/models/embeds/article_meta.ex

@@ -6,11 +6,12 @@ defmodule GroupherServer.CMS.Model.Embeds.ArticleMeta do
   use Accessible
   import Ecto.Changeset
 
-  @optional_fields ~w(is_edited is_comment_locked upvoted_user_ids collected_user_ids viewed_user_ids reported_user_ids reported_count is_sinked can_undo_sink last_active_at)a
+  @optional_fields ~w(thread is_edited is_comment_locked upvoted_user_ids collected_user_ids viewed_user_ids reported_user_ids reported_count is_sinked can_undo_sink last_active_at)a
 
   @doc "for test usage"
   def default_meta() do
     %{
+      thread: "POST",
       is_edited: false,
       is_comment_locked: false,
       upvoted_user_ids: [],
@@ -25,6 +26,7 @@ defmodule GroupherServer.CMS.Model.Embeds.ArticleMeta do
   end
 
   embedded_schema do
+    field(:thread, :string)
     field(:is_edited, :boolean, default: false)
     field(:is_comment_locked, :boolean, default: false)
     # reaction history

lib/helper/utils/utils.ex

@@ -182,6 +182,13 @@ defmodule Helper.Utils do
 
   def strip_struct(map) when is_map(map), do: map
 
+  @doc """
+  get upcase name of a module, most used for store thread in DB
+  """
+  def module_to_upcase(module) do
+    module |> Module.split() |> List.last() |> String.upcase()
+  end
+
   @doc """
   get atom name of a module
   """

test/groupher_server/cms/articles/blog_test.exs

@@ -22,12 +22,15 @@ defmodule GroupherServer.Test.Articles.Blog do
   end
 
   describe "[cms blogs curd]" do
+    @tag :wip
     test "can create blog with valid attrs", ~m(user community blog_attrs)a do
       assert {:error, _} = ORM.find_by(Author, user_id: user.id)
       {:ok, blog} = CMS.create_article(community, :blog, blog_attrs, user)
 
       body_map = Jason.decode!(blog.body)
 
+      assert blog.meta.thread == "BLOG"
+
       assert blog.title == blog_attrs.title
       assert body_map |> Validator.is_valid()
       assert blog.body_html |> String.contains?(~s(<div class="#{@root_class["viewer"]}">))

test/groupher_server/cms/articles/job_test.exs

@@ -23,12 +23,15 @@ defmodule GroupherServer.Test.Articles.Job do
   end
 
   describe "[cms jobs curd]" do
+    @tag :wip
     test "can create job with valid attrs", ~m(user community job_attrs)a do
       assert {:error, _} = ORM.find_by(Author, user_id: user.id)
       {:ok, job} = CMS.create_article(community, :job, job_attrs, user)
 
       body_map = Jason.decode!(job.body)
 
+      assert job.meta.thread == "JOB"
+
       assert job.title == job_attrs.title
       assert body_map |> Validator.is_valid()
       assert job.body_html |> String.contains?(~s(<div class="#{@root_class["viewer"]}">))

test/groupher_server/cms/articles/post_test.exs

@@ -23,12 +23,15 @@ defmodule GroupherServer.Test.CMS.Articles.Post do
   end
 
   describe "[cms post curd]" do
+    @tag :wip
     test "can create post with valid attrs", ~m(user community post_attrs)a do
       assert {:error, _} = ORM.find_by(Author, user_id: user.id)
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
 
       body_map = Jason.decode!(post.body)
 
+      assert post.meta.thread == "POST"
+
       assert post.title == post_attrs.title
       assert body_map |> Validator.is_valid()
       assert post.body_html |> String.contains?(~s(<div class="#{@root_class["viewer"]}">))

test/groupher_server/cms/articles/repo_test.exs

@@ -23,12 +23,15 @@ defmodule GroupherServer.Test.Articles.Repo do
   end
 
   describe "[cms repo curd]" do
+    @tag :wip
     test "can create repo with valid attrs", ~m(user community repo_attrs)a do
       assert {:error, _} = ORM.find_by(Author, user_id: user.id)
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
 
       body_map = Jason.decode!(repo.body)
 
+      assert repo.meta.thread == "REPO"
+
       assert repo.title == repo_attrs.title
       assert body_map |> Validator.is_valid()
       assert repo.body_html |> String.contains?(~s(<div class="#{@root_class["viewer"]}">))
@@ -63,7 +66,6 @@ defmodule GroupherServer.Test.Articles.Repo do
       assert user2.id in created.meta.viewed_user_ids
     end
 
-    @tag :wip
     test "read repo should contains viewer_has_xxx state", ~m(repo_attrs community user user2)a do
       {:ok, repo} = CMS.create_article(community, :repo, repo_attrs, user)
       {:ok, repo} = CMS.read_article(:repo, repo.id, user)