refactor(abuse-report): wip

Author: mydearxym

lib/groupher_server/accounts/embeds/collect_folder_meta.ex

@@ -1,4 +1,4 @@
-defmodule GroupherServer.CMS.Embeds.CollectFolderMeta.Macros do
+defmodule GroupherServer.Accounts.Embeds.CollectFolderMeta.Macros do
   @moduledoc """
   general fields for each folder meta
 
@@ -31,7 +31,7 @@ defmodule GroupherServer.Accounts.Embeds.CollectFolderMeta do
   """
   use Ecto.Schema
   import Ecto.Changeset
-  import GroupherServer.CMS.Embeds.CollectFolderMeta.Macros
+  import GroupherServer.Accounts.Embeds.CollectFolderMeta.Macros
 
   alias GroupherServer.Accounts.CollectFolder
 

lib/groupher_server/accounts/embeds/user_meta.ex

@@ -0,0 +1,26 @@
+defmodule GroupherServer.Accounts.Embeds.UserMeta do
+  @moduledoc """
+  general article meta info for article-like content, like post, job, works ...
+  """
+  use Ecto.Schema
+  use Accessible
+  import Ecto.Changeset
+
+  @optional_fields ~w(reported_count)a
+
+  @default_meta %{
+    reported_count: 0
+  }
+
+  @doc "for test usage"
+  def default_meta(), do: @default_meta
+
+  embedded_schema do
+    field(:reported_count, :integer, default: 0)
+  end
+
+  def changeset(struct, params) do
+    struct
+    |> cast(params, @optional_fields)
+  end
+end

lib/groupher_server/accounts/user.ex

@@ -9,6 +9,7 @@ defmodule GroupherServer.Accounts.User do
 
   alias GroupherServer.Accounts.{
     Achievement,
+    Embeds,
     Customization,
     EducationBackground,
     CollectFolder,
@@ -60,6 +61,9 @@ defmodule GroupherServer.Accounts.User do
     # field(:paid_member, :boolean)
     # field(:platinum_member, :boolean)
 
+    field(:is_reported, :boolean, default: false)
+    embeds_one(:meta, Embeds.UserMeta, on_replace: :update)
+
     has_one(:customization, Customization)
     has_one(:purchase, Purchase)
 
@@ -70,6 +74,7 @@ defmodule GroupherServer.Accounts.User do
   def changeset(%User{} = user, attrs) do
     user
     |> update_changeset(attrs)
+    |> cast_embed(:meta, required: false, with: &Embeds.UserMeta.changeset/2)
     |> validate_required(@required_fields)
 
     # |> unique_constraint(:username)
@@ -80,6 +85,7 @@ defmodule GroupherServer.Accounts.User do
     |> cast(attrs, @optional_fields ++ @required_fields)
     |> cast_embed(:education_backgrounds, with: &EducationBackground.changeset/2)
     |> cast_embed(:work_backgrounds, with: &WorkBackground.changeset/2)
+    |> cast_embed(:meta, required: false, with: &Embeds.UserMeta.changeset/2)
     |> validate_length(:nickname, min: 3, max: 30)
     |> validate_length(:bio, min: 3, max: 100)
     |> validate_inclusion(:sex, ["dude", "girl"])

lib/groupher_server/cms/cms.ex

@@ -162,9 +162,11 @@ defmodule GroupherServer.CMS do
   # TODO: move report to abuse report module
   defdelegate create_report(type, content_id, reason, attr, user), to: AbuseReport
   defdelegate report_article(thread, article_id, reason, attr, user), to: AbuseReport
+  defdelegate report_article_comment(comment_id, reason, attr, user), to: ArticleCommentAction
+  defdelegate report_account(account_id, reason, attr, user), to: AbuseReport
+  defdelegate undo_report_account(account_id, user), to: AbuseReport
   defdelegate undo_report_article(thread, article_id, user), to: AbuseReport
   defdelegate list_reports(filter), to: AbuseReport
-  defdelegate report_article_comment(comment_id, reason, attr, user), to: ArticleCommentAction
   defdelegate undo_report_article_comment(comment_id, user), to: AbuseReport
 
   # Passport CURD

lib/groupher_server/cms/delegates/abuse_report.ex

@@ -29,6 +29,8 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
   # }
 
   @article_threads [:post, :job, :repo]
+  @export_author_keys [:id, :login, :nickname, :avatar]
+  @export_article_keys [:id, :title, :digest, :upvotes_count, :views]
   @export_report_keys [
     :id,
     :deal_with,
@@ -40,8 +42,26 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
     :updated_at
   ]
 
-  @export_author_keys [:id, :login, :nickname, :avatar]
-  @export_article_keys [:id, :title, :digest, :upvotes_count, :views]
+  @doc """
+  list paged reports for article comemnts
+  """
+  def list_reports(%{content_type: :user, content_id: content_id} = filter) do
+    %{page: page, size: size} = filter
+
+    with {:ok, info} <- match(:account_user) do
+      query =
+        from(r in AbuseReport,
+          where: field(r, ^info.foreign_key) == ^content_id,
+          preload: :account
+        )
+
+      query
+      |> QueryBuilder.filter_pack(filter)
+      |> ORM.paginater(~m(page size)a)
+      |> reports_formater(:account_user)
+      |> done()
+    end
+  end
 
   @doc """
   list paged reports for article comemnts
@@ -87,42 +107,39 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
     end
   end
 
-  defp reports_formater(%{entries: entries} = paged_reports, :article_comment) do
-    paged_reports
-    |> Map.put(
-      :entries,
-      Enum.map(entries, fn report ->
-        basic_report = report |> Map.take(@export_report_keys)
-        basic_report |> Map.put(:article_comment, extract_article_comment_info(report))
+  def report_account(account_id, reason, attr, user) do
+    with {:ok, info} <- match(:account_user),
+         {:ok, account} <- ORM.find(info.model, account_id) do
+      Multi.new()
+      |> Multi.run(:create_abuse_report, fn _, _ ->
+        create_report(:account_user, account.id, reason, attr, user)
       end)
-    )
-  end
-
-  defp reports_formater(%{entries: entries} = paged_reports, thread)
-       when thread in @article_threads do
-    paged_reports
-    |> Map.put(
-      :entries,
-      Enum.map(entries, fn report ->
-        basic_report = report |> Map.take(@export_report_keys)
-        basic_report |> Map.put(:article, extract_article_info(thread, report))
+      |> Multi.run(:update_report_flag, fn _, _ ->
+        update_report_meta(info, account)
       end)
-    )
+      |> Repo.transaction()
+      |> result()
+    end
   end
 
-  # TODO: original community and communities info
-  defp extract_article_info(thread, %AbuseReport{} = report) do
-    article = Map.get(report, thread)
-
-    article
-    |> Map.take(@export_article_keys)
-    |> Map.merge(%{thread: thread})
+  @doc """
+  undo report article content
+  """
+  def undo_report_account(account_id, %User{} = user) do
+    with {:ok, info} <- match(:account_user),
+         {:ok, account} <- ORM.find(info.model, account_id) do
+      Multi.new()
+      |> Multi.run(:delete_abuse_report, fn _, _ ->
+        delete_report(:account_user, account.id, user)
+      end)
+      |> Multi.run(:update_report_flag, fn _, _ ->
+        update_report_meta(info, account)
+      end)
+      |> Repo.transaction()
+      |> result()
+    end
   end
 
-  # def report_account(user_id) do
-  #   # TODO*
-  # end
-
   @doc """
   report article content
   """
@@ -131,10 +148,10 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
          {:ok, article} <- ORM.find(info.model, article_id) do
       Multi.new()
       |> Multi.run(:create_abuse_report, fn _, _ ->
-        create_report(thread, article_id, reason, attr, user)
+        create_report(thread, article.id, reason, attr, user)
       end)
       |> Multi.run(:update_report_flag, fn _, _ ->
-        update_report_meta(info, article, true)
+        update_report_meta(info, article)
       end)
       |> Repo.transaction()
       |> result()
@@ -149,10 +166,10 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
          {:ok, article} <- ORM.find(info.model, article_id) do
       Multi.new()
       |> Multi.run(:delete_abuse_report, fn _, _ ->
-        delete_report(thread, article_id, user)
+        delete_report(thread, article.id, user)
       end)
       |> Multi.run(:update_report_flag, fn _, _ ->
-        update_report_meta(info, article, false)
+        update_report_meta(info, article)
       end)
       |> Repo.transaction()
       |> result()
@@ -219,23 +236,26 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
     end
   end
 
-  # update is_reported flag and reported_count in mete for article or comment
-  defp update_report_meta(info, content, is_reported) do
+  # update  reported_count in mete for article or comment
+  defp update_report_meta(info, content) do
     case ORM.find_by(AbuseReport, Map.put(%{}, info.foreign_key, content.id)) do
       {:ok, record} ->
         reported_count = record.report_cases |> length
-        meta = content.meta |> Map.merge(%{reported_count: reported_count}) |> strip_struct
+
+        safe_meta = if is_nil(content.meta), do: info.default_meta, else: content.meta
+        meta = safe_meta |> Map.merge(%{reported_count: reported_count}) |> strip_struct
 
         content
-        |> Ecto.Changeset.change(%{is_reported: is_reported})
+        |> Ecto.Changeset.change()
         |> Ecto.Changeset.put_embed(:meta, meta)
         |> Repo.update()
 
       {:error, _} ->
-        meta = content.meta |> Map.merge(%{reported_count: 0}) |> strip_struct
+        safe_meta = if is_nil(content.meta), do: info.default_meta, else: content.meta
+        meta = safe_meta |> Map.merge(%{reported_count: 0}) |> strip_struct
 
         content
-        |> Ecto.Changeset.change(%{is_reported: false})
+        |> Ecto.Changeset.change()
         |> Ecto.Changeset.put_embed(:meta, meta)
         |> Repo.update()
     end
@@ -261,6 +281,52 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
     end
   end
 
+  defp reports_formater(%{entries: entries} = paged_reports, :account_user) do
+    paged_reports
+    |> Map.put(
+      :entries,
+      Enum.map(entries, fn report ->
+        basic_report = report |> Map.take(@export_report_keys)
+        basic_report |> Map.put(:account, extract_account_info(report))
+      end)
+    )
+  end
+
+  defp reports_formater(%{entries: entries} = paged_reports, :article_comment) do
+    paged_reports
+    |> Map.put(
+      :entries,
+      Enum.map(entries, fn report ->
+        basic_report = report |> Map.take(@export_report_keys)
+        basic_report |> Map.put(:article_comment, extract_article_comment_info(report))
+      end)
+    )
+  end
+
+  defp reports_formater(%{entries: entries} = paged_reports, thread)
+       when thread in @article_threads do
+    paged_reports
+    |> Map.put(
+      :entries,
+      Enum.map(entries, fn report ->
+        basic_report = report |> Map.take(@export_report_keys)
+        basic_report |> Map.put(:article, extract_article_info(thread, report))
+      end)
+    )
+  end
+
+  defp extract_account_info(%AbuseReport{} = report) do
+    account = report |> Map.get(:account) |> Map.take(@export_author_keys)
+  end
+
+  # TODO: original community and communities info
+  defp extract_article_info(thread, %AbuseReport{} = report) do
+    report
+    |> Map.get(thread)
+    |> Map.take(@export_article_keys)
+    |> Map.merge(%{thread: thread})
+  end
+
   def extract_article_comment_info(%AbuseReport{} = report) do
     keys = [:id, :upvotes_count, :body_html]
     author = Map.take(report.article_comment.author, @export_author_keys)

lib/groupher_server/cms/helper/matcher2.ex

@@ -5,12 +5,18 @@ defmodule GroupherServer.CMS.Helper.Matcher2 do
 
   import Ecto.Query, warn: false
 
-  alias GroupherServer.CMS
+  alias GroupherServer.{Accounts, CMS}
 
+  alias Accounts.User
   alias CMS.{ArticleComment, Post, Job, Repo}
 
   def match(:article_comment) do
-    {:ok, %{model: ArticleComment, foreign_key: :article_comment_id}}
+    {:ok,
+     %{
+       model: ArticleComment,
+       foreign_key: :article_comment_id,
+       default_meta: CMS.Embeds.ArticleCommentMeta.default_meta()
+     }}
   end
 
   def match(:comment_article, %ArticleComment{post_id: post_id}) when not is_nil(post_id) do
@@ -25,29 +31,41 @@ defmodule GroupherServer.CMS.Helper.Matcher2 do
     {:error, "not supported"}
   end
 
+  def match(:account_user) do
+    {:ok,
+     %{
+       model: User,
+       foreign_key: :account_id,
+       default_meta: Accounts.Embeds.UserMeta.default_meta()
+     }}
+  end
+
   # used for paged pin articles
   def match(Post) do
     {:ok, %{thread: :post}}
   end
 
   def match(:post) do
-    {:ok, %{model: Post, foreign_key: :post_id}}
+    {:ok,
+     %{model: Post, foreign_key: :post_id, default_meta: CMS.Embeds.ArticleMeta.default_meta()}}
   end
 
   def match(Job) do
     {:ok, %{thread: :job}}
   end
 
   def match(:job) do
-    {:ok, %{model: Job, foreign_key: :job_id}}
+    {:ok,
+     %{model: Job, foreign_key: :job_id, default_meta: CMS.Embeds.ArticleMeta.default_meta()}}
   end
 
   def match(Repo) do
     {:ok, %{thread: :repo}}
   end
 
   def match(:repo) do
-    {:ok, %{model: Repo, foreign_key: :repo_id}}
+    {:ok,
+     %{model: Repo, foreign_key: :repo_id, default_meta: CMS.Embeds.ArticleMeta.default_meta()}}
   end
 
   def match(:post, :query, id), do: {:ok, dynamic([c], c.post_id == ^id)}

lib/helper/utils/utils.ex

@@ -173,6 +173,8 @@ defmodule Helper.Utils do
     struct |> Map.from_struct() |> Map.delete(:id)
   end
 
+  def strip_struct(map) when is_map(map), do: map
+
   @doc "html uniq id generator for editorjs"
   @spec uid(:html, map) :: String.t()
   def uid(:html, %{"id" => id}) when g_none_empty_str(id), do: id

priv/repo/migrations/20210512072528_add_report_meta_to_user.exs

@@ -0,0 +1,10 @@
+defmodule GroupherServer.Repo.Migrations.AddReportMetaToUser do
+  use Ecto.Migration
+
+  def change do
+    alter table(:users) do
+      add(:is_reported, :boolean, default: false)
+      add(:meta, :map)
+    end
+  end
+end