refactor(cited-article): wip

Author: mydearxym

lib/groupher_server/cms/delegates/block_tasks.ex

@@ -35,41 +35,41 @@ defmodule GroupherServer.CMS.Delegate.BlockTasks do
   def handle(%{body: body} = article) do
     with {:ok, body_map} <- Jason.decode(body) do
       run_tasks(:cite, article, body_map["blocks"])
+      # run_tasks(:mention, article, body_map["blocks"])
     end
   end
 
   defp run_tasks(:cite, article, blocks) do
     article = article |> Repo.preload(author: :user)
 
-    # NOTE:
-    cited_contents =
-      blocks
-      |> Enum.reduce([], &(&2 ++ get_cited_contents_per_block(article, &1)))
-      |> merge_same_cited_article_block
+    blocks
+    |> Enum.reduce([], &(&2 ++ get_cited_contents_per_block(article, &1)))
+    |> merge_same_cited_article_block
+    |> update_cited_info
+  end
 
-    IO.inspect(cited_contents, label: "fuck all")
+  defp update_cited_info(cited_contents) do
+    # batch update CitedContent List
+    cited_contents_fields = [:cited_by_id, :cited_by_type, :block_linker, :user_id]
+    clean_cited_contents = Enum.map(cited_contents, &Map.take(&1, cited_contents_fields))
+    IO.inspect(clean_cited_contents, label: "clean_cited_contents")
+    Repo.insert_all(CitedContent, clean_cited_contents)
 
-    CitedContent |> Repo.insert_all(cited_contents)
+    # update citting count meta
     update_citing_count(cited_contents)
-
-    # CitedContent |>  ORM.create
   end
 
   defp update_citing_count(cited_contents) do
     Enum.each(cited_contents, fn content ->
       count_query = from(c in CitedContent, where: c.cited_by_id == ^content.cited_by_id)
       count = Repo.aggregate(count_query, :count)
 
-      IO.inspect(count, label: "the count")
+      cited_article = content.cited_article
+      meta = Map.merge(cited_article.meta, %{citing_count: count})
+      cited_article |> ORM.update_meta(meta)
     end)
-
-    # count = Repo.aggregate(count_query, :count)
-    # IO.inspect cited_contents, label: "update_citing_count"
   end
 
-  # count_query = from(s in CommunitySubscriber, where: s.user_id == ^user.id)
-  # count = Repo.aggregate(count_query, :count)
-
   @doc """
   e.g:
   [
@@ -115,14 +115,35 @@ defmodule GroupherServer.CMS.Delegate.BlockTasks do
   """
   defp merge_same_cited_article_block(cited_contents) do
     cited_contents
-    |> Enum.chunk_by(& &1.cited_by_id)
-    |> Enum.map(fn content_by_group ->
-      Enum.reduce(content_by_group, fn content, acc ->
-        Map.merge(content, %{block_linker: content.block_linker ++ acc.block_linker})
-      end)
+    |> Enum.reduce([], fn content, acc ->
+      case Enum.find_index(acc, &(&1.cited_by_id == content.cited_by_id)) do
+        nil ->
+          acc ++ [content]
+
+        index ->
+          List.update_at(
+            acc,
+            index,
+            &Map.merge(&1, %{block_linker: &1.block_linker ++ content.block_linker})
+          )
+      end
     end)
   end
 
+  @doc """
+  return fmt like:
+  [
+    %{
+      block_linker: ["block-ZgKJs"],
+      cited_by_id: 190057,
+      cited_by_type: "POST",
+      cited_article: #loaded,
+      post_id: 190059,
+      user_id: 1413053
+    }
+    ...
+  ]
+  """
   defp get_cited_contents_per_block(article, %{
          "id" => block_id,
          "data" => %{"text" => text}
@@ -147,30 +168,43 @@ defmodule GroupherServer.CMS.Delegate.BlockTasks do
     %{
       cited_by_id: cited_article.id,
       cited_by_type: cited_article.meta.thread,
-      # cited_article: cited_article,
+      cited_article: cited_article,
       block_linker: [block_id],
       user_id: article.author.user.id
     }
     |> Map.put(info.foreign_key, article.id)
   end
 
   defp parse_cited_article({"a", attrs, _}) do
-    with {:ok, link} <- get_link(Enum.find(attrs, fn {a, v} -> a == "href" end)),
-         true <- is_valid_article_link?(link) do
-      get_cited_article(link)
+    with {:ok, link} <- parse_link(attrs),
+         true <- is_site_article_link?(link) do
+      load_cited_article_from_url(link)
     end
   end
 
-  defp get_link({"href", link}), do: {:ok, link}
-  defp get_link(_), do: {:error, "invalid fmt"}
+  @doc """
+  parse link from Floki parse result
+
+  e.g:
+  [{"href", "https://coderplanets.com/post/190220", "bla", "bla"}] ->
+  {:ok, "https://coderplanets.com/post/190220"}
+  """
+  defp parse_link(attrs) do
+    with {"href", link} <- Enum.find(attrs, fn {a, v} -> a == "href" end) do
+      {:ok, link}
+    else
+      _ -> {:error, "invalid fmt"}
+    end
+  end
 
-  defp is_valid_article_link?(url) do
+  # 检测是否是站内文章的链接
+  defp is_site_article_link?(url) do
     Enum.any?(@valid_article_prefix, &String.starts_with?(url, &1))
   end
 
   # get cited article from url
   # e.g: https://coderplanets.com/post/189993 -> ORM.find(Post, 189993)
-  defp get_cited_article(url) do
+  defp load_cited_article_from_url(url) do
     %{path: path} = URI.parse(url)
     path_list = path |> String.split("/")
     thread = path_list |> Enum.at(1) |> String.downcase() |> String.to_atom()
@@ -180,19 +214,4 @@ defmodule GroupherServer.CMS.Delegate.BlockTasks do
       ORM.find(info.model, article_id)
     end
   end
-
-  defp run_tasks(:mention) do
-    #
-  end
-
-  # 还是单抽一个模块吧
-  defp run_tasks(:danger_words) do
-    # title & body
-  end
-
-  defp parse_blocks(%{body: body} = article) do
-    with {:ok, body_map} <- Jason.decode(body) do
-      #
-    end
-  end
 end

lib/groupher_server/cms/helper/macros.ex

@@ -207,7 +207,6 @@ defmodule GroupherServer.CMS.Helper.Macros do
       article_comment_fields()
 
       field(:active_at, :utc_datetime_usec)
-      field(:citing_count, :integer, default: 0)
       # TODO:
       # related_articles
       timestamps()

lib/groupher_server/cms/models/embeds/article_meta.ex

@@ -40,6 +40,7 @@ defmodule GroupherServer.CMS.Model.Embeds.ArticleMeta do
     field(:can_undo_sink, :boolean, default: false)
     # if undo_sink, can recover last active_at from here
     field(:last_active_at, :utc_datetime_usec)
+    field(:citing_count, :integer, default: 0)
   end
 
   def changeset(struct, params) do

priv/repo/migrations/20210611160430_add_citing_count_to_articles.exs

@@ -20,34 +20,42 @@ defmodule GroupherServer.Test.CMS.CiteContent do
     {:ok, post} = db_insert(:post)
     {:ok, post2} = db_insert(:post)
     {:ok, post3} = db_insert(:post)
+    {:ok, post4} = db_insert(:post)
+    {:ok, post5} = db_insert(:post)
 
     {:ok, community} = db_insert(:community)
 
     post_attrs = mock_attrs(:post, %{community_id: community.id})
 
-    {:ok, ~m(user user2 community post post2 post3 post_attrs)a}
+    {:ok, ~m(user user2 community post post2 post3 post4 post5 post_attrs)a}
   end
 
   describe "[cite basic]" do
     @tag :wip
-    test "basic", ~m(user community post2 post3 post_attrs)a do
-      IO.inspect(post2.id, label: "post2.id")
-      IO.inspect(post3.id, label: "post3.id")
-
+    test "basic", ~m(user community post2 post3 post4 post5 post_attrs)a do
       body =
         mock_rich_text(
           ~s(the <a href=#{@site_host}/post/#{post2.id} /> and <a href=#{@site_host}/post/#{
             post2.id
           }>same la</a> is awesome, the <a href=#{@site_host}/post/#{post3.id}></a> is awesome too.),
           # second paragraph
-          ~s(the paragraph 2 <a href=#{@site_host}/post/#{post2.id}> again</a> )
+          ~s(the paragraph 2 <a href=#{@site_host}/post/#{post2.id} class=#{post2.title}> again</a>, the paragraph 2 <a href=#{
+            @site_host
+          }/post/#{post4.id}> again</a>, the paragraph 2 <a href=#{@site_host}/post/#{post5.id}> again</a>)
         )
 
       post_attrs = post_attrs |> Map.merge(%{body: body})
 
       {:ok, post} = CMS.create_article(community, :post, post_attrs, user)
-
       BlockTasks.handle(post)
+
+      {:ok, post2} = ORM.find(Post, post2.id)
+      {:ok, post3} = ORM.find(Post, post3.id)
+      {:ok, post4} = ORM.find(Post, post4.id)
+
+      assert post2.meta.citing_count == 1
+      assert post3.meta.citing_count == 1
+      assert post4.meta.citing_count == 1
     end
   end
 end