refactor(community): add default index to community

Author: mydearxym

lib/mastani_server/cms/community.ex

@@ -21,7 +21,7 @@ defmodule MastaniServer.CMS.Community do
 
   @required_fields ~w(title desc user_id logo raw)a
   # @required_fields ~w(title desc user_id)a
-  @optional_fields ~w(label geo_info)a
+  @optional_fields ~w(label geo_info index)a
 
   schema "communities" do
     field(:title, :string)
@@ -30,6 +30,7 @@ defmodule MastaniServer.CMS.Community do
     # field(:category, :string)
     field(:label, :string)
     field(:raw, :string)
+    field(:index, :integer)
     field(:geo_info, :map)
 
     belongs_to(:author, Accounts.User, foreign_key: :user_id)

lib/mastani_server_web/schema/cms/cms_types.ex

@@ -252,6 +252,7 @@ defmodule MastaniServerWeb.Schema.CMS.Types do
     field(:title, :string)
     field(:desc, :string)
     field(:raw, :string)
+    field(:index, :integer)
     field(:logo, :string)
     field(:author, :user, resolve: dataloader(CMS, :author))
     field(:threads, list_of(:thread), resolve: dataloader(CMS, :threads))

priv/repo/migrations/20181203051334_add_default_index_to_community.exs

@@ -0,0 +1,9 @@
+defmodule MastaniServer.Repo.Migrations.AddDefaultIndexToCommunity do
+  use Ecto.Migration
+
+  def change do
+    alter table(:communities) do
+      add(:index, :integer, default: 100_000)
+    end
+  end
+end

test/mastani_server_web/mutation/cms/post_test.exs

@@ -70,7 +70,6 @@ defmodule MastaniServer.Test.Mutation.Post do
       assert user_conn |> mutation_get_error?(@create_post_query, variables)
     end
 
-    @tag :wip
     test "can create post with tags" do
       {:ok, user} = db_insert(:user)
       user_conn = simu_conn(:user, user)
@@ -93,7 +92,6 @@ defmodule MastaniServer.Test.Mutation.Post do
       assert post.tags |> Enum.any?(&(&1.id == tag2.id))
     end
 
-    @tag :wip
     test "can create post with mentionUsers" do
       {:ok, user} = db_insert(:user)
       {:ok, user2} = db_insert(:user)

test/mastani_server_web/mutation/delivery/delivery_test.exs

@@ -150,7 +150,6 @@ defmodule MastaniServer.Test.Mutation.Delivery do
       }
     }
     """
-    @tag :wip
     test "login user can mention other user" do
       {:ok, user} = db_insert(:user)
       {:ok, user2} = db_insert(:user)
@@ -173,7 +172,6 @@ defmodule MastaniServer.Test.Mutation.Delivery do
       assert user.id == mentions.entries |> List.first() |> Map.get(:from_user_id)
     end
 
-    @tag :wip
     test "unauth user send mention fails", ~m(guest_conn)a do
       {:ok, user2} = db_insert(:user)
 

test/mastani_server_web/query/accounts/account_test.exs

@@ -36,7 +36,6 @@ defmodule MastaniServer.Test.Query.Account.Basic do
       }
     }
     """
-    @tag :wip
     test "guest user can get specific user's info by user's id", ~m(guest_conn user)a do
       variables = %{id: user.id}
       results = guest_conn |> query_result(@query, variables, "user")
@@ -48,7 +47,6 @@ defmodule MastaniServer.Test.Query.Account.Basic do
       assert results["cmsPassport"] == nil
     end
 
-    @tag :wip
     test "login user can get it's own profile", ~m(user_conn user)a do
       results = user_conn |> query_result(@query, %{}, "user")
       assert results["id"] == to_string(user.id)

test/mastani_server_web/query/accounts/mention_test.exs

@@ -26,7 +26,6 @@ defmodule MastaniServer.Test.Query.Accounts.Mention do
       }
     }
     """
-    @tag :wip
     test "auth user can get it's own mailbox status" do
       {:ok, [user, user2]} = db_insert_multi(:user, 2)
 
@@ -75,7 +74,6 @@ defmodule MastaniServer.Test.Query.Accounts.Mention do
       }
     }
     """
-    @tag :wip
     test "auth user can get it's own mentions" do
       {:ok, [user, user2]} = db_insert_multi(:user, 2)
 

test/mastani_server_web/query/cms/cms_test.exs

@@ -50,6 +50,7 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
         entries {
           id
           title
+          index
           categories {
             id
             title
@@ -74,6 +75,14 @@ defmodule MastaniServer.Test.Query.CMS.Basic do
       assert results["totalCount"] == 5 + 1
     end
 
+    test "community has default index = 100000", ~m(guest_conn)a do
+      {:ok, _communities} = db_insert_multi(:community, 5)
+      variables = %{filter: %{page: 1, size: 20}}
+      results = guest_conn |> query_result(@query, variables, "pagedCommunities")
+
+      results["entries"] |> Enum.all?(fn x -> x["index"] == 100_000 end)
+    end
+
     test "guest user can get paged communities based on category", ~m(guest_conn)a do
       {:ok, category1} = db_insert(:category)
       {:ok, category2} = db_insert(:category)