fix(pagesize middleware): edge case when passed in arg is empty

Author: mydearxym

lib/mastani_server_web/middleware/pagesize_proof.ex

@@ -16,14 +16,25 @@ defmodule MastaniServerWeb.Middleware.PageSizeProof do
   # 3. large size should trigger error
   def call(%{errors: errors} = resolution, _) when length(errors) > 0, do: resolution
 
-  def call(%{context: %{cur_user: %{customization: customization}}} = resolution, _info)
+  def call(
+        %{context: %{cur_user: %{customization: customization}}, arguments: arguments} =
+          resolution,
+        _info
+      )
       when not is_nil(customization) do
     size = String.to_integer(customization.display_density)
 
-    filter = resolution.arguments.filter |> Map.merge(%{size: size})
-    arguments = resolution.arguments |> Map.merge(%{filter: filter})
+    case Map.has_key?(arguments, :filter) do
+      true ->
+        filter = arguments.filter |> Map.merge(%{size: size})
+        arguments = arguments |> Map.merge(%{filter: filter})
+
+        %{resolution | arguments: sort_desc_by_default(arguments)}
 
-    %{resolution | arguments: sort_desc_by_default(arguments)}
+      false ->
+        arguments = arguments |> Map.merge(%{filter: %{page: 1, size: size, first: size}})
+        %{resolution | arguments: arguments}
+    end
   end
 
   def call(resolution, _) do

test/mastani_server_web/query/accounts/account_test.exs

@@ -25,6 +25,15 @@ defmodule MastaniServer.Test.Query.Account.Basic do
         views
         cmsPassport
         cmsPassportString
+        contributes {
+          records {
+            count
+            date
+          }
+          startDate
+          endDate
+          totalCount
+        }
         educationBackgrounds {
           school
           major
@@ -33,6 +42,13 @@ defmodule MastaniServer.Test.Query.Account.Basic do
           company
           title
         }
+        subscribedCommunities {
+          entries {
+            id
+          }
+          pageSize
+          totalCount
+        }
       }
     }
     """
@@ -47,6 +63,7 @@ defmodule MastaniServer.Test.Query.Account.Basic do
       assert results["cmsPassport"] == nil
     end
 
+    @tag :wip
     test "login user can get it's own profile", ~m(user_conn user)a do
       results = user_conn |> query_result(@query, %{}, "user")
       assert results["id"] == to_string(user.id)