refactor(mention): fix test

Author: mydearxym

lib/helper/utils/map.ex

@@ -11,7 +11,7 @@ defmodule Helper.Utils.Map do
   def atom_values_to_upcase(map) when is_map(map) do
     map
     |> Enum.reduce(%{}, fn {key, val}, acc ->
-      case val !== true and val !== false and is_atom(val) do
+      case val !== true and val !== false and not is_nil(val) and is_atom(val) do
         true -> Map.put(acc, key, val |> to_string |> String.upcase())
         false -> Map.put(acc, key, val)
       end

test/groupher_server/cms/hooks/mention_in_post_test.exs

@@ -22,7 +22,6 @@ defmodule GroupherServer.Test.CMS.Hooks.MentionInPost do
   end
 
   describe "[mention in post basic]" do
-    @tag :wip
     test "mention multi user in post should work", ~m(user user2 user3 community  post_attrs)a do
       body =
         mock_rich_text(

test/groupher_server/delivery/mention_test.exs

@@ -15,7 +15,7 @@ defmodule GroupherServer.Test.Delivery.Mention do
 
     mention_contents = [
       %{
-        type: "POST",
+        thread: "POST",
         title: post.title,
         article_id: post.id,
         comment_id: nil,
@@ -43,6 +43,7 @@ defmodule GroupherServer.Test.Delivery.Mention do
       assert mention.user.login == user.login
     end
 
+    @tag :wip
     test "mention multiable times on same article, will only have one record",
          ~m(post user user2 mention_contents)a do
       {:ok, :pass} = Delivery.send(:mention, post, mention_contents, user)