Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Commit fe1c22d

Browse files
committed
refactor: make all tests pass! 🎉
1 parent 79dcb42 commit fe1c22d

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

lib/mastani_server/cms/delegates/comment_curd.ex

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ defmodule MastaniServer.CMS.Delegate.CommentCURD do
100100
|> QueryBuilder.filter_pack(filters)
101101
|> join(:inner, [c], a in assoc(c, :author))
102102
|> distinct([c, a], a.id)
103+
# new added when upgrade to ecto v3
104+
|> group_by([c, a], a.id)
105+
|> group_by([c, a], c.inserted_at)
106+
# new added when upgrade to ecto v3 end
103107
|> select([c, a], a)
104108
|> ORM.paginater(~m(page size)a)
105109
|> done()

test/mastani_server_web/query/cms/post_comment_test.exs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ defmodule MastaniServer.Test.Query.PostComment do
3737
}
3838
}
3939
"""
40-
@tag :wip
4140
test "can get comments participators of a post", ~m(user guest_conn)a do
4241
{:ok, user2} = db_insert(:user)
4342

test/mastani_server_web/query/cms/post_test.exs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ defmodule MastaniServer.Test.Query.Post do
114114
}
115115
}
116116
"""
117-
@tag :wip
118117
test "login user can get nil post favorited category id", ~m(post)a do
119118
{:ok, user} = db_insert(:user)
120119
user_conn = simu_conn(:user, user)

0 commit comments

Comments
 (0)