fix(life cycle mount): rm willUmount hooks

route change will cause didMount/willUmount called

Author: mydearxym

containers/CheatsheetThread/index.js

@@ -52,10 +52,6 @@ class CheatsheetThreadContainer extends React.Component {
     }, 1000)
   }
 
-  componentWillUnmount() {
-    logic.uninit()
-  }
-
   render() {
     const { cheatsheetThread } = this.props
     const { cheatsheetData, curView, curCommunity } = cheatsheetThread

containers/CheatsheetThread/logic.js

@@ -101,11 +101,7 @@ const ErrSolver = [
 export function init(_store) {
   store = _store
 
-  if (sub$) sub$.unsubscribe()
+  if (sub$) return false
   sub$ = sr71$.data().subscribe($solver(DataSolver, ErrSolver))
   getCheatsheet()
 }
-
-export function uninit() {
-  if (sub$) sub$.unsubscribe()
-}

containers/JobsThread/index.js

@@ -42,10 +42,6 @@ class JobsThreadContainer extends React.Component {
     logic.init(jobsThread)
   }
 
-  componentWillUnmount() {
-    logic.uninit()
-  }
-
   render() {
     const { jobsThread } = this.props
 

containers/JobsThread/logic.js

@@ -34,12 +34,7 @@ const debug = makeDebugger('L:JobsThread')
 let store = null
 let sub$ = null
 
-const validFilter = R.pickBy(
-  R.compose(
-    R.not,
-    R.isEmpty
-  )
-)
+const validFilter = R.pickBy(R.compose(R.not, R.isEmpty))
 
 export const inAnchor = () => store.setHeaderFix(false)
 export const outAnchor = () => store.setHeaderFix(true)
@@ -158,10 +153,6 @@ const ErrSolver = [
 export function init(_store) {
   store = _store
 
-  if (sub$) sub$.unsubscribe()
+  if (sub$) return false // sub$.unsubscribe()
   sub$ = sr71$.data().subscribe($solver(DataSolver, ErrSolver))
 }
-
-export function uninit() {
-  if (sub$) sub$.unsubscribe()
-}

containers/PostsThread/index.js

@@ -48,9 +48,7 @@ class PostsThreadContainer extends React.Component {
 
   // componentWillUnmount will be called everytime when route changes
   // so don't use
-  componentWillUnmount() {
-    // logic.uninit()
-  }
+  componentWillUnmount() {}
 
   render() {
     const { postsThread } = this.props

containers/PostsThread/logic.js

@@ -187,8 +187,3 @@ export function init(_store) {
   if (sub$) return false // sub$.unsubscribe()
   sub$ = sr71$.data().subscribe($solver(DataSolver, ErrSolver))
 }
-
-export function uninit() {
-  // debug('======== un init')
-  // if (sub$) sub$.unsubscribe()
-}

containers/ReposThread/index.js

@@ -42,10 +42,6 @@ class ReposThreadContainer extends React.Component {
     logic.init(reposThread)
   }
 
-  componentWillUnmount() {
-    logic.uninit()
-  }
-
   render() {
     const { reposThread } = this.props
 

containers/ReposThread/logic.js

@@ -32,12 +32,7 @@ const debug = makeDebugger('L:ReposThread')
 
 let store = null
 
-const validFilter = R.pickBy(
-  R.compose(
-    R.not,
-    R.isEmpty
-  )
-)
+const validFilter = R.pickBy(R.compose(R.not, R.isEmpty))
 
 export const inAnchor = () => store.setHeaderFix(false)
 export const outAnchor = () => store.setHeaderFix(true)
@@ -131,10 +126,6 @@ const ErrSolver = []
 export function init(_store) {
   store = _store
 
-  if (sub$) sub$.unsubscribe()
+  if (sub$) return false
   sub$ = sr71$.data().subscribe($solver(DataSolver, ErrSolver))
 }
-
-export function uninit() {
-  if (sub$) sub$.unsubscribe()
-}

containers/UsersThread/index.js

@@ -47,10 +47,6 @@ class UsersThreadContainer extends React.Component {
     })
   }
 
-  componentWillUnmount() {
-    logic.uninit()
-  }
-
   render() {
     const { usersThread } = this.props
     const { geoInfosData, geoDataLoading, curTheme } = usersThread

containers/UsersThread/logic.js

@@ -60,11 +60,7 @@ const ErrSolver = [
 export function init(_store) {
   store = _store
 
-  if (sub$) sub$.unsubscribe()
+  if (sub$) return false
   sub$ = sr71$.data().subscribe($solver(DataSolver, ErrSolver))
   loadGeoData()
 }
-
-export function uninit() {
-  if (sub$) sub$.unsubscribe()
-}