Skip to content

Conversation

YannikFirre
Copy link
Contributor

@YannikFirre YannikFirre commented Nov 14, 2020

Hello,

I worked to make the package compatible with Laravel 8, I removed support for version <=6 and php <=7.2 for convenience and because I did not need them.

@nerg4l
Copy link
Member

nerg4l commented Nov 14, 2020

I will have a closer look tomorrow today.

@nerg4l
Copy link
Member

nerg4l commented Nov 14, 2020

I hope you don't mind that I rebased your PR to avoid conflicts

Copy link
Member

@nerg4l nerg4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promissing.

@YannikFirre
Copy link
Contributor Author

I hope you don't mind that I rebased your PR to avoid conflicts

No problem ;)

Copy link
Member

@nerg4l nerg4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work

@nerg4l nerg4l merged commit 886d014 into coding-socks:master Nov 15, 2020
@YannikFirre
Copy link
Contributor Author

@nerg4l Thanks !

RM : in github action you have a misstiping '^7.8' instead of '8.0' ;)

@YannikFirre YannikFirre deleted the laravel-8 branch November 15, 2020 14:58
@nerg4l nerg4l mentioned this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants