-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API for adding measurement programatically #3936
Merged
haakonflatval-cognite
merged 10 commits into
master
from
hflatval/add-measurement-programatically
Nov 22, 2023
Merged
feat: API for adding measurement programatically #3936
haakonflatval-cognite
merged 10 commits into
master
from
hflatval/add-measurement-programatically
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@haakonflatval-cognite API should be updated 😉, API extractor not updated |
16 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3936 +/- ##
==========================================
+ Coverage 71.46% 73.14% +1.68%
==========================================
Files 351 351
Lines 35103 35124 +21
Branches 2682 2703 +21
==========================================
+ Hits 25085 25691 +606
+ Misses 9910 9329 -581
+ Partials 108 104 -4
|
pramodcog
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
haakonflatval-cognite
added
the
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
label
Nov 22, 2023
haakonflatval-cognite
deleted the
hflatval/add-measurement-programatically
branch
November 22, 2023 08:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
Progress on keeping Measurements state in the URL in FDX
Description 📝
Add a method to add a new measurement programatically.
Note that the inner API for this is a little cumbersome at the moment, but cleaning it up will have to wait...
How has this been tested? 🔍
Linked into FDX, also react-components.
Test instructions ℹ️
Checklist ☑️