Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API for adding measurement programatically #3936

Merged
merged 10 commits into from
Nov 22, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Feat

Jira ticket 📘

Progress on keeping Measurements state in the URL in FDX

Description 📝

Add a method to add a new measurement programatically.

Note that the inner API for this is a little cumbersome at the moment, but cleaning it up will have to wait...

How has this been tested? 🔍

Linked into FDX, also react-components.

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner November 21, 2023 13:53
@pramodcog
Copy link
Contributor

pramodcog commented Nov 21, 2023

@haakonflatval-cognite API should be updated 😉, API extractor not updated

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #3936 (80aedc2) into master (2c03471) will increase coverage by 1.68%.
Report is 4 commits behind head on master.
The diff coverage is 71.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3936      +/-   ##
==========================================
+ Coverage   71.46%   73.14%   +1.68%     
==========================================
  Files         351      351              
  Lines       35103    35124      +21     
  Branches     2682     2703      +21     
==========================================
+ Hits        25085    25691     +606     
+ Misses       9910     9329     -581     
+ Partials      108      104       -4     
Files Coverage Δ
...ackages/tools/src/Measurement/MeasurementLabels.ts 95.12% <100.00%> (+95.12%) ⬆️
...ckages/tools/src/Measurement/MeasurementManager.ts 72.98% <100.00%> (+72.98%) ⬆️
viewer/packages/tools/index.ts 0.00% <0.00%> (ø)
.../packages/tools/src/Measurement/MeasurementTool.ts 60.72% <95.83%> (+60.72%) ⬆️
viewer/packages/tools/src/Measurement/types.ts 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Nov 22, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit 48e7cd4 into master Nov 22, 2023
13 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/add-measurement-programatically branch November 22, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants