Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-components): MeasurementButton with URL state #3938

Merged
merged 13 commits into from
Nov 22, 2023
Merged

feat(react-components): MeasurementButton with URL state #3938

merged 13 commits into from
Nov 22, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Another stepping stone to enable storage of measurements in the URL in FDX.

Depends on #3936

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner November 21, 2023 15:32
@haakonflatval-cognite haakonflatval-cognite marked this pull request as draft November 21, 2023 15:32
@haakonflatval-cognite haakonflatval-cognite marked this pull request as ready for review November 22, 2023 12:15
pramodcog
pramodcog requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, minor comments

@pramodcog pramodcog self-requested a review November 22, 2023 14:39
pramodcog
pramodcog approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Nov 22, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit 0b2172d into master Nov 22, 2023
26 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/measurement-button-with-url-state branch November 22, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodcog pramodcog pramodcog approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonflatval-cognite @pramodcog