Fix argument parsing in newer Python. #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
force-pushed
the
clalancette/fix-parse-optional
branch
2 times, most recently
from
6230515
to
b39c91c
Compare
cottsay
approved these changes
Apr 9, 2024
clalancette
force-pushed
the
clalancette/fix-parse-optional
branch
from
8c937fe
to
f04372b
Compare
The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Scott K Logan <logans@cottsay.net>
cottsay
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple.