Use [_p: P] instead of [_: P] for Scala 3 compatibility
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples compiled in Scala 2.13.4 (the Scala version used in com-lihaoyi#262) but don't compile in Scala 2.13.6 I didn't understand the real reason, but helped the compiler by adding some explicit type annotations
|
Is this essentially competing with #266 ? |
Closed
|
Ah! I see now that it's not. I hadn't noticed you'd merged it already. |
|
I wanted to help the migration by merging the easy syntactic changes first so the main PR becomes smaller and smaller. |
lihaoyi
added a commit
to ajrnz/fastparse
that referenced
this pull request
Feb 28, 2023
…om-lihaoyi#267)" This reverts commit 8927803.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if we can shrink #262 so it's easier to review by merging first the easy changes and rebasing, so the diff is smaller.