Make combine short args that fail to parse go through normal leftover-token code paths #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
approved these changes
Feb 9, 2024
|
@lihaoyi A new release would be great. |
|
Pushed a 0.6.2 tag |
lihaoyi
added a commit
that referenced
this pull request
Sep 13, 2024
This was accidentally broken in #102 and #112, and wasn't covered by tests. Noticed when trying to update Ammonite to the latest version of MainArgs in com-lihaoyi/Ammonite#1549 Restored the special casing for tracking/handling incomplete arguments and added some unit test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we aggressively errored out, which prevented the normal
def completelogic from happening: reporting missing arguments, passing remaining tokens toLeftover, etc. This change makes it so that we just go through the normal code paths when combined short args fail to parse, making the error reporting more consistent with the rest of MainArgs and allowing tokens such as-footo be passed toLeftoverwhen possibleCovered by additional unit tests