Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Dotty, download the binary version of the compiler bridge instead of compiling it from sources #591

Closed
smarter opened this issue Apr 11, 2019 · 3 comments
Labels
feedback wanted Additional feedback or testing is apreciated
Milestone

Comments

@smarter
Copy link
Collaborator

smarter commented Apr 11, 2019

Starting with Dotty 0.13.0-RC1, the bridge is a Java-only project (https://github.com/lampepfl/dotty/tree/master/sbt-bridge/src/xsbt) and binary artifacts are published on Maven: https://repo1.maven.org/maven2/ch/epfl/lamp/dotty-sbt-bridge/0.13.0-RC1/. This means you can avoid all the complications caused by having to fetch it sources, compiling these sources, caching the result, etc. In particular, it means #389 ceases to be a problem.

The relevant code in mill is in https://github.com/lihaoyi/mill/blob/master/scalalib/worker/src/ZincWorkerImpl.scala

@smarter smarter added the feedback wanted Additional feedback or testing is apreciated label Apr 11, 2019
@lefou
Copy link
Member

lefou commented Apr 11, 2019

What exactly is the issue here? Doesn't commit 981c4e1 fix the Java-only compilation for the compiler bridge?

@lefou
Copy link
Member

lefou commented Apr 11, 2019

For reference: #569

@smarter
Copy link
Collaborator Author

smarter commented Apr 11, 2019

This is a request for enhancement not a bug :). The current solution works fine, but as explained above, using a pre-built binary version of the bridge avoids a lot of complications (and is faster for the initial compilation too).

TheElectronWill added a commit to TheElectronWill/mill that referenced this issue Jul 15, 2019
@lefou lefou added this to the after 0.5.0 milestone Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Additional feedback or testing is apreciated
Projects
None yet
Development

No branches or pull requests

2 participants