Fix Scala.js toolchain logs in server-client mode #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason logging with `scala.Console` doesn't work with Scala.js linker, maybe it's related to some classpath issue. This works around the problem by using `System.out` instead, which works correctly.
lefou
reviewed
Jun 4, 2024
| private val logger = new Logger { | ||
| def log(level: Level, message: => String): Unit = level match { | ||
| case Level.Warn | Level.Error => System.err.println(message) | ||
| case Level.Info | Level.Debug => System.out.println(message) |
There was a problem hiding this comment.
Should go all log messages to the same channel, STDERR? If a user wants to use STDOUT, she would use println instead of logging, I'd assume.
There was a problem hiding this comment.
This is what ConsoleScalaLogger from Scala.js does.
That would deviate from Sbt but it would mean that the Starting process: node log will be printed to stderr and not to stdout anymore, which is nice.
I don't know what's best to be honest.
There was a problem hiding this comment.
I think the message you mentioned is predestinated to end up on STDERR. It's just tooling side-output, not the output of the actual process to run.
lefou
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason logging with
scala.Consoledoesn't work with the Scala.js linker in server-client mode, maybe it's related to some classloader issue. This works around the problem by usingSystem.outinstead, which works correctly.Pull Request: #3196