Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit moduleDeps from outer in Scoverage #623

Merged
merged 2 commits into from
Jun 2, 2019
Merged

Inherit moduleDeps from outer in Scoverage #623

merged 2 commits into from
Jun 2, 2019

Conversation

nvander1
Copy link
Contributor

@nvander1 nvander1 commented May 31, 2019 •
edited
Loading

Thanks to @kag0 for finding this bug! Fixes #622. @lefou @lihaoyi

@nvander1
Add test case that breaks via #622
506fd24 
Thanks to @kag0 for finding this! :)
@nvander1 nvander1 marked this pull request as ready for review May 31, 2019 22:43
@nvander1 nvander1 changed the title Fix #622 Inherit moduleDeps from outer in Scoverage May 31, 2019
@lihaoyi
Copy link
Member

lihaoyi commented Jun 2, 2019

no idea

@lihaoyi lihaoyi merged commit de3da65 into com-lihaoyi:master Jun 2, 2019
@lefou lefou added this to the after 0.4.0 milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

Scoverage can't compile modules with moduleDeps
3 participants
@nvander1 @lihaoyi @lefou