Add the actual command to CommandResult #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to and the discussion in PR #93 also applies to it. We should be careful to not expose secrets by exposing the whole command. |
Flowdalic
force-pushed
the
improve-subprocess-exception
branch
from
220f3df
to
52445ca
Compare
I would love to life in a world where people know by now that secrets should not be part of the command, but I know that sadly, the reality is different. @lihaoyi suggested in #93 (comment) a compromise to put the command in |
Flowdalic
force-pushed
the
improve-subprocess-exception
branch
from
52445ca
to
dd9c810
Compare
|
Friendly reminder about this PR. :) |
|
Hm, looks like PR is too old to start CI... |
Anything I need to do? |
lefou
reviewed
Apr 19, 2022
The messages of exceptions thrown by call() would previously just mention the exit status of the invoked process, but not the actual command line that was used to create the process. To help with debugging purposes, the exception message now includes the full command line and the os.proc instance provides access to it.
Flowdalic
force-pushed
the
improve-subprocess-exception
branch
from
dd9c810
to
31785c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages of exceptions thrown by call() would previously just
mention the exit status of the invoked process, but not the actual
command line that was used to create the process. To help with
debugging purposes, the exception message now includes the full
command line and the os.proc instance provides access to it.