Add more tests #392
Merged
Add more tests #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments the
rwtest helpers to also allow assertion of theupack.Msgversion of the serialized values, and then goes through and adds them to all the existing tests.Previously we were only asserting that values could be round-tripped, without checking what they serialized into.
Now, the message-pack format tests are brought up to par with the JSON format: we ensure that the message-pack output is something reasonable, explicitly specify the output that each value
tis supposed to serialize to, as well as listing out what other inputs we expect to be able to read intotapart from the one that it is written out to (e.g. old formats for backwards-compatibility)