-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out why pre-commit corrupts git repo #32846
Comments
Happened again on a completely different computer :(
EDIT: Another data point: tried on that same PC as above for the msgq submodule and it didn't repro:
|
@adeebshihadeh git rm -r -f --cached . After this, I was able to commit again. |
It maybe caused by mypy. |
@adeebshihadeh, Do commaai/rednose#44 and other PRs count as a solution to this? |
Does it fix this? Do you have a reliable repro and can show it doesn't happen anymore after those PRs? |
Yes, pre-commit broke submodules that used numpy-stubs because it cloned the numpy-stubs repo into the submodule. |
Cool, if you post a before/after that shows the repro, the bounty is yours! |
Are screenshots enough? |
p.s it's a vm |
Nice, bounty is yours. Open a ticket at comma.ai/support to claim. |
pre-commit somewhat consistently corrupts my git repo on pre-commit init. It can be either pre-commit or one of the hooks we use. Goal is to identify why this happens and ideally fix it if possible.
Here's the latest occurrence for me, on the panda repo in this case (so it's a hook that openpilot has in common with panda).
The text was updated successfully, but these errors were encountered: