Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulled in new panda firmware and updated boardd to support the changes. #114

Merged
merged 3 commits into from
Jul 12, 2017
Merged

Pulled in new panda firmware and updated boardd to support the changes. #114

merged 3 commits into from
Jul 12, 2017

Conversation

diamondman
Copy link

No description provided.

geohot
geohot reviewed Jul 12, 2017
View reviewed changes
selfdrive/boardd/boardd.cc Outdated
@@ -194,6 +215,8 @@ void can_send(void *s) {
err = zmq_msg_recv(&msg, s, 0);
assert(err >= 0);

printf("Got ZMQ message\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

geohot
geohot reviewed Jul 12, 2017
View reviewed changes
selfdrive/boardd/test_boardd_loopback.py Outdated
@@ -0,0 +1,49 @@
"""Enable the DEBUG_WITH_PANDA_LOOPBACK define in boardd.cc before test."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to an environment variable instead of needing to rebuild? How about BOARDD_LOOPBACK?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add that to boardd.cc now.

geohot
geohot reviewed Jul 12, 2017
View reviewed changes
selfdrive/boardd/boardd.cc Outdated
}

// TODO: Boardd should be able to set the baud rate
// May need to set endianess.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set endianness where? Are you saying this won't work on big endian computers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read that ARM is capable of supporting BIG and LITTLE endian. This was a comment to look to see if I should use an endianness macro so there are no issues with ARM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reasonable phones are little endian. Some ARM are big endian, and some really crazy ARM have a runtime settable flag! But all modern phones are little.

@geohot geohot merged commit 317ae0f into commaai:devel Jul 12, 2017
@geohot geohot mentioned this pull request Jul 18, 2017
Merged
rbiasini pushed a commit that referenced this pull request Nov 17, 2018
Squashed 'opendbc/' changes from 62b7a01..3f6cd74
2f0b0fb 
3f6cd74 Add 3rd RSA signal and cleanup (#120)
a308ec1 add vals honda (#121)
1317514 Toyota: fixed typos
0339fc8 Toyota: added a better cruise active indicator
b0c012d Lexus: add is
94ba43c Toyota: generated dnc files after latest change
e16723e Add Distance Lines and RSA (#118)
9aec1ef Add GM signals for ESP/Mode/Highbeams/Intellibeam (#114)
a67fff9 add   toyota_prius_2010_pt.dbc (#50)
c1ee10f Revert "Revert "GM: copy radar header from cadillac (#116)""

git-subtree-dir: opendbc
git-subtree-split: 3f6cd74
mespiritu pushed a commit to mespiritu/openpilot that referenced this pull request Apr 1, 2019
@arne182
Merge pull request commaai#114 from arne182/release2
0bfc00d 
Updatr
icmma added a commit to priuscom/openpilot that referenced this pull request Apr 6, 2019
@icmma
Merge pull request commaai#114 from hyperactive32/sienna_.5.7
bfd760c 
just version bump and merge
cfranyota referenced this pull request in cfranyota/openpilot-retired Jun 7, 2019
Use JSON text file for configuration attributes (#114)
d5e8370 
* Add kegman_conf json config class

* Syntax error fix

* Syntax Error Fix

* Update kegman_conf.py

* Update thermald.py

* Update thermald.py

* Update thermald.py

* Update thermald.py

* Update thermald.py

* Update kegman_conf.py

* Update kegman_conf.py

* Update pathplanner.py

* Update pathplanner.py

* Update kegman_conf.py

* Update driver_monitor.py

* Update driver_monitor.py

* Update carstate.py

* Update carstate.py

* Update kegman_conf.py

* Update kegman_conf.py

* Update kegman_conf.py

* Update kegman_conf.py

* Update kegman_conf.py

* Update carstate.py
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 10, 2019
@srpape @pd0wm
Add GM signals for ESP/Mode/Highbeams/Intellibeam (commaai#114)
9aec1ef 
* Add ESPButton to gm_global_a_powertrain

Bit goes to 1 when traction control button is down. Tested on 2018 Chevy Volt.

* Add DriveModeButton to gm_global_a_powertrain

DriveModeButton toggles between Normal/Sport/Mountain/Hold modes

Tested on 2018 Chevy Volt

* Add value entries for DriveModeButton / ESPButton

* Add IntelliBeam, HighBeams, and HighBeamsTemporary

Temporary high beam bit is enabled when pulling the switch forward.
It remains off when pushing it back, which keeps HighBeams enabled
permanently.

* VAL_/VAL_TABLE_ entries for highbeams/intellibeam
SippieCup pushed a commit to SippieCup/openpilot that referenced this pull request Nov 5, 2019
@rafcabezas
Merge pull request commaai#114 from rafcabezas/feature/tinklad-async-…
d8c122d 
…await

Feature/tinklad async await
dragonpilot referenced this pull request in dragonpilot-community/dragonpilot Apr 7, 2020
@geohot
Merge pull request #114 from diamondman/new_panda_code
753f81a 
Pulled in new panda firmware and updated boardd to support the changes.
rav4kumar pushed a commit to rav4kumar/openpilot that referenced this pull request Jun 16, 2020
@sshane
Add min_TR mod to change the minimum clipped TR (commaai#114)
d6fbfef 
* add new param to change the minimum allowed TR

* update README.md

* test

* revert

* New implementation of global_df_mod, should perform much better

* rearrange
Coral-coder pushed a commit to Coral-coder/openpilot that referenced this pull request Feb 20, 2023
@sunnyhaibin
Hyundai: Enhanced SCC (ESCC) Radar Interceptor support (commaai#114)
2830c02 
* escc: wip

* finish up

* use new intflag

* bump panda
garrettpall pushed a commit to garrettpall/openpilot that referenced this pull request Jul 9, 2024
@davidpdev1
Add trailblazer cc to torque_data/substitute.toml (commaai#114)
9e15115
carleeno pushed a commit to carleeno/openpilot that referenced this pull request Aug 2, 2024
@sunnyhaibin
mapd: Preload dependencies (commaai#114)
e6ce327 
* exclude third_party/mapd/ from gitignore

* all mapd dependencies

* exclude more

* more dependencies!

* add to files_common

* add script to compress locally

* compressed dependencies

* Revert "more dependencies!"

This reverts commit 0cd08beb3fa81b5e037ceb41b5e0554261c56dd5.

* Revert "all mapd dependencies"

This reverts commit b1a19b82b3911313e543a91d77ece124f5e7ded0.

* decompress preloaded deps

* fix path

* use xz

* fix script

* update deps

* no need

* strip first level

* missed this

* try that

* not needed

* try except extraction

* handle exception

* unused

---------

Co-authored-by: Comma Device <device@comma.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geohot geohot geohot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diamondman @geohot