Honda carstate: use common gas pedal signal #22010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belm0
changed the title
belm0
commented
Aug 22, 2021
belm0
force-pushed
the
honda_gas_pedal_refactor
branch
from
d21567e
to
a913a01
Compare
|
setting status to draft, may want to resolve #22009 (comment) first |
|
Let's use the common user gas signal as discussed in #22009. |
belm0
force-pushed
the
honda_gas_pedal_refactor
branch
from
a913a01
to
292293d
Compare
|
I updated the comment in cereal (commaai/msgq@6f842ba). Interestingly, carState.brake is user only. I suspect carState.gas was defined as user + computer because that's the signal we knew of on the first openpilot cars, the Civic and Acura ILX. |
belm0
commented
Sep 13, 2021
adeebshihadeh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CarState.gas is now derived exclusively from user pedal signal. Previously it was derived
from user pedal or user pedal + computer gas, depending on model.
Subsequently, this allowed several cases to be collapsed in the the signal config regarding SCM messages.
NOTE: Cereal currently defines CarState.gas as user + computer, but it's agreed that user pedal is sufficient going forward.