Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Car Port: Merge Pilot_2019 into Pilot #23590

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

vanillagorillaa
Copy link
Contributor

@vanillagorillaa vanillagorillaa commented Jan 21, 2022

The 2019 Pilot was made it's own car port due to having a different radar keep alive command (back when camera was disconnected and we had to keep the radar happy). #334 as well as using a different message and signal for car_gas. The car_gas code was refactored in #22010 so now all Honda's use the same message/signal.

Because of these two differences no longer being an issue, I have gone ahead and merged these into one. Since the Honda Pilot had some firmware versions that the Pilot_2019 did not, and to avoid breaking support for these, I have removed these values and left only the common values between each vehicle.

Probably want to get someone with a 2019 Pilot to test this

@vanillagorillaa vanillagorillaa changed the title Reverse Car Port: Merge Pilot with Pilot_2019 Reverse Car Port: Merge Pilot_2019 into Pilot Jan 21, 2022
@pd0wm
Copy link
Contributor

pd0wm commented Jan 21, 2022

Any reason why we shouldn't just merge all the FW versions?

@vanillagorillaa
Copy link
Contributor Author

For ECU's that both vehicle definitions had this is what I did. I removed a few ECU's that were only defined in one vehicle because I think this would cause some vehicles to fail fingerprinting unless they had that version. Unless I'm wrong on this, in which case I can certainly add those back in.

@VirtuallyChris
Copy link
Contributor

Yeah you’re right about that

@pd0wm
Copy link
Contributor

pd0wm commented Jan 24, 2022

If the ECUs are not in the list of essential ECUs (https://github.com/commaai/openpilot/blob/master/selfdrive/car/fw_versions.py#L255) [Ecu.engine, Ecu.eps, Ecu.esp, Ecu.fwdRadar, Ecu.fwdCamera, Ecu.vsa], being absent shouldn't be an issue.

@vanillagorillaa
Copy link
Contributor Author

The ones originally removed are non essential, so added back in, and now we just have a simple FW merge

@pd0wm
Copy link
Contributor

pd0wm commented Jan 24, 2022

LGTM

@adeebshihadeh adeebshihadeh merged commit 4f827e2 into commaai:master Jan 25, 2022
@vanillagorillaa vanillagorillaa deleted the pilot_merge branch January 25, 2022 05:25
sshane added a commit that referenced this pull request Mar 28, 2022
Disengage on gas toggle

Fix missing params lib

ui: fix invalid line vertices on startup (#23541)

sentry: rename release environment to release

sentry: rotate keys

Toyota: fix typo (#23548)

swaglog: Fix random test failure (#23546)

* print info

* retry zmq_recv on errors

* get line no from __LINE__

* cleanup

* renmae msg to thread_id
docs/cars.md: fix brand sorting (#23551)

test_logcatd_android.py: catch unicode decode error

thermald: move dbus and other slow calls into thread (#23525)

* split thermald in threads

* small cleanup

* type

* already done that

* add none check

* fix sleep

* shut down on exception
controlsd: remove extra space (#23553)

Add missing CAMRY_TSS2 engine & fwdCamera f/w (#23555)

`@Koda(Sleepy)#4682`  2021 Camry LE (ICE)  DongleID/route  3653e5d0dbd0d7ed|2022-01-16--21-15-20
ui/networking: async dbus calls (#23535)

* async dbus calls

* simplify get ip address

* Revert "simplify get ip address"

This reverts commit 7ade7ec57dd0bb76cb3194f94f039498fdcd8881.

* cleanup getConnectionPath()

* remove unused functions

* cleanup

* rename to getIp4Address

* clenup class definition
master and forks aren't dirty

clear no entry alerts if engaged (#23559)

* clear no entry alerts if engaged

* fix test
Add missing COROLLA_TSS2 ESP f/w (#23562)

`@Dom#5007`  2022 Corolla ICE  DongleID/route 2517a9ee480ef37f|2022-01-15--09-20-12
bump cereal

camerad: return 0 from main() (#23565)

Log MPC solver time (#23566)

* add solve time to plan output

* add to process replay ignore list

* print in CI
boardd: move main() to main.cc for test cases (#23564)

* move main() to main.cc

* move includes back
thermald refactor seems to have lower CPU usage

work on acados lateral MPC (#23558)

* lat_mpc: make v_ego, rotation_radius parameters instead of states

* lat_mpc: remove rotation_radius argument, since it is part of the parameters

* lat_mpc: use qp_solver_cond_N = 1

slightly faster and in line with case study in Fig. 2/ 3 in Frison2016 - https://cdn.syscop.de/publications/Frison2016.pdf
An Efficient Implementation of Partial Condensing for Nonlinear Model Predictive Control

* adapt test_lateral_mpc to formulation with parameters

* lat_mpc: set parameters in reset() and copy values

* acados_ocp_solver_pyx: make options_set useable

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Add missing ALPHARD_TSS2 f/w (#23567)

dmonitoringd: make real-time process (#23554)

* dmonitoringd: make real-time process

* Update selfdrive/monitoring/dmonitoringd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
FW for Toyota Highlander 2021 Hybrid (#23571)

dmonitoringd: remove duplicate call on update when driver engaged (#23539)

bump opendbc

Update interfaces.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Add param to process replay

these dbcs are the same

fix suffix

Toyota: use single DBC for Lexus NXH, Lexus RXH, HighlanderH, Rav4H (#23576)

* use rav4h dbc for nx

also bump opendbc

* remove from release file

* same with highlander

* bump opendbc

* rav4h -> tngakh

also rxh

* bump opendbc

* bump again

* remove from release files

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Toyota: unify Sienna, Avalon, Highlander Lexus NX, Lexus RX into single DBC (#23577)

* remove sienna dbc

same as avalon

* rx and nx are also the same as avalon

* highlander can also use avalon's dbc

* bump opendbc

* rename avalon to tnga-k

* pt

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
loggerd: make test_loggerd.py run on PC (#23574)

* run on PC

* set frameId

* remove todo

* rawlogger: remove suffix mkv

* remove unused import PC

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Toyota: LKAS_HUD expansion (#23573)

* bump opendbc

* add lkas_hud messages

* Remove duplicate

* bump opendbc

* fix comment

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Honda: use Pilot DBC for Ridgeline

androidd cloudlogs are errors

VW MQB: Update steering angle and actuator delay (#23584)

Update refs for PR:#23584)

androidd: track system_server too

NEOS 19 (#23586)

* NEOS 19

* prod manifest
Ensure controlsd can engage again in process replay (#23556)

* hacks to make process replay engage again

* dont change that

* enable engagement check again

* chmod +x

* first working regen

* proper logMonoTime

* fix video framerate consistency

* mpc is valid again

* proper alive checks

* revert loggerd change

* ensure engaged in regen, fix managerState, peripheralState

* ubloxRaw is unused

* add submaster config for gm

* regen all services we can run without HW

* fix loggerd

* loggerd: matroska without the extension

* update ref
save dongleid as value to limit cardinality (#23594)

Add more type hinting (#23595)

* Add more type hinting.

* Revert joystick_alert changes.

* Add typing to statsd.

* Update selfdrive/statsd.py

* Update selfdrive/test/test_fingerprints.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
ui: fix lead vertex coordinates (#23550)

camerad: cleanup main.cc (#23593)

* cleanup main.cc

* fix  ae_gray_test build errors
bringing the android to agnos

profiler setup

Toyota: add fwVersion for 2018 CHR (#23604)

VW MQB: Add FW for 2015 Golf 7 2.0 TDI (#23603)

ui/setup: check http status code (#23597)

* check resp code

* always cleanup curl and close file

* curl_global_init

* space

* cleaner

* Revert "curl_global_init"

This reverts commit c3f1a7cee87804993ce8f5fd5939570a8e9ffd3a.
process replay: disable alive checks for cpp replay

thermald: increase kmsg loglevel to end up in console-ramoops-0

RawLogger: downscale qcamera before encoding (#23607)

remove community features toggle (#23214)

* remove community features toggle

* bump cereal

* little more

* update refs
remove ridgeline DBC from release files

tools: auto plotjuggler install

Toyota: move gas pedal definitions into common DBC (#23582)

* Toyota: move gas pedal definitions into common DBC

* add rest of cars

* auto detection

* cleanup

* update refs
GM: use generated DBC (#23615)

* Rename GM PT dbc to generated

* bump opendbc

Co-authored-by: Jason Shuler <jshuler@gmail.com>
loggerd: less error logging

Honda: Merge Pilot_2019 into Pilot (#23590)

* merge pilot

* these weren't on the 2019 pilot

* add non essential ECUs
controlsd: remove redundant condition

Use Wide Road Camera as Light Sensor for Screen Brightness (#23610)

Using the narrow camera as a light sensor meant that the
reflection of our own headlights, tail lights, and head lights
of opposing vehicles dominated the sensor value at night
even though the broader overall scene is very dark.

This has very little effect during daylight hours.  The change
affects nightime driving the most, resulting in a dimmer
screen when it is dark.

I think this makes more sense as the wide angle camera's
field of view is much closer to the human eye's field of
view than the narrow road camera.
bump panda and cereal

bump panda

controlsd: verify unsafe mode consistency (#23563)

* add unsafe mode check to controlsd

bump submodules

forgot to add to health_t struct

bump

ahh forgot to set it!

bump

bump

clean up

clean up

bump

* fix ordering

* move to end

* unsigned

Co-authored-by: Willem Melching <willem.melching@gmail.com>
LateralPlanner: Move lane change logic to another class (#23476)

* should work

* Revert "should work"

This reverts commit dabc2ea17a072a6c835e4bd1c75a2c1e2d10623d.

* move lane change logic to DesireHelper class

* clean up desires

clean up desires

* comments

* Revert "clean up desires"

This reverts commit 7301c921e305fcbd4746b19040631d935d50dfd9.

* Update selfdrive/controls/lib/desire_helper.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* add to files_common

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
use codecov action (#23618)

* use codecov action

* convert to xml

* also coverage in longitudinal test

* fix typo
collect C++ code coverage (#23619)

* collect cpp coverage

* install llvm

* compile with coverage

* cd to root

* remove broken gcda files

* remove newline

* delete more stuff

* script to collect coverage

* Update tools/collect_coverage.sh

* actually delete
manager: don't start uploader with dongle id

Toyota: add fw for 2020 Lexus UX250h (#23626)

Revert "collect C++ code coverage (#23619)"

This reverts commit 698ab6ac97bef2a00e0a6fa8111a5a0556a064d2.

athena: unsuccessful upload handler requests. (#23620)

* Retry unsuccessful upload handler requests.

* test both cases

Co-authored-by: Willem Melching <willem.melching@gmail.com>
base LatControl class (#21967)

* base LatControl class, move sat check out of pid.py

clean up

clean up

* fix

* global variable for min control speed

* nicer name

* unify latcontrol class init arguments

* add to release files

* saturated if close to limit

* move angle mode saturation checks into class

* check_saturation function takes in current saturated status

undo

* apply latcontrol_angle's active checking to all controllers

* clean up

* move those back

* make abstract baseclass

* add test for saturation

* keep clip

* update ref

* fix static analysis

Co-authored-by: Willem Melching <willem.melching@gmail.com>
compare_logs: catch typeError (#23632)

INDI: replace internal rate limit by actuatorsOutput (#23243)

* INDI: replace internal rate limit by actuatorsOutput

* update ref
sentry improvements (#23627)

* sentry: filter out unregistered devices and PC

* add daemon name
Panda: check libusb_open status (#23622)

Toyota: use common gear packet signal (#23634)

* Toyota: remove nodsu hybrid dbc

* bump

* no longer exists
update refs

Prepare for using the ISP (#23621)

* parse out isp packet with structs

* dsp mode

* support only driver / comments for yuv

* minor touchups

* DEBUG_FRAMES

Co-authored-by: Comma Device <device@comma.ai>
Toyota: Move EPS torque factor to openpilot (#23635)

* use scaling

* or we can do it this way

* define default in one place

* just specify

* Revert "just specify"

This reverts commit 40b7b28f8416497cd1337784d336c1dd4f5dd6e3.
Toyota: rav4 DBC is same as corolla now

Toyota: Prius V 2017 support (#23636)

* Add Toyota Prius Alpha support

* Fix opendbc link

* Update interface.py

* v

* revert opendbc

Co-authored-by: CT921 <tim.chen242@gmail.com>
Co-authored-by: 【TIM】 <90225659+CT921@users.noreply.github.com>
tesla: fix actuatorsOutput logging (#23637)

clip steer saturation counter to steerLimitTimer (#23638)

* clip steer saturation counter to steerLimitTimer

* update ref
Statlog in C (#23596)

* statlog in C

* fix swaglog and the test

* add missing files

* fix context initialization todo

* speed up test
Toyota: CT200H DBC merged into Rav4

Toyota: unify TNGA-K platform DBCs

Toyota: remove Prius DBC

Toyota: use common DBC for IS and RC

Toyota: DBC rename

replay: ncurses GUI  (#23608)

* initial version

* print all message's in ncurses window

* show download progress bar

* move all to class ConsoleUI

* timeline

* improve timeline&stats

* fix logMessage

* add warning indicator

* continue

* cleanup

* cast type to int

* simplify seekToFlag

* more

* <=

* handle enter

* add box to logging window

* fix multiple threads problem

* fix concurrency issues

* draw indicator

* many improvements

* more

* fix multipe threads logging

* stop replay before exit

* use lambda instead of std::bind

* cleanup

* small cleanup

* use carFingerPrint

* don't emit signal in replay::stream

* merge car_events into timeline

* cleanup DonloadStats

* cleanup

* rename carname to carFingerprint

* improve alert

* add comments

* add help functions

templete function

* handle term resize

* display replaying status

* rename to INSTANT

* helper function pauseReplay

* more

* cleanup

use rDebug

* no template

* less colors

* remove function mv_add_str

* use BORDER_SIZE

* tune colors

* add spaces

* apply reviews

use /
Toyota: Prius V fixups (#23640)

* Fine tune Prius-V control parameter

* Adjust DBC file and enable SNG support

*Adjust the DBC file to CT200H, the parameters of this model are closer to PRIUS V
*Add PRIUS V to NO_STOP_TIMER_CAR list to enable SNG support

* Update interface.py

remove spaces

* Update values.py

Mod DBC to toyota_rav4_2017_pt_generated

* Update values.py

The file has been updated to resolve the conflict and can be directly merged

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Toyota: merge IS and RC params

bump

CANParser: remove default values (#23642)

* draft

* remove rest

* bump

* update radar interfaces

* do rest and formatting

* bump

* fix mising check

* try this

* Revert "try this"

This reverts commit 0d26d9a072f87dbc897ed525b70fb1db9cb04a06.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
boardd: add blocked msg cnt (#23647)

* boardd: add blocked msg cnt

* bump panda

* bump panda
boardd: get health struct from panda (#23648)

log error on avcodec_receive_frame (#23649)

bump panda

Honda: Merge Passport interface (#23651)

replay: cleanup functions (#23655)

* cleanup function seek

* cleanup signals&slots

* use false

* add comment back
replay: add test case for local route (#23650)

* add test for local route

* retry download on network error

* sleep 500ms before retry

* read 100 frames

* read more segments from route

* add REQUIRE
replay: fix wrong logging for local route (#23652)

CANParser: consistent style for adding signals/checks (#23646)

* consistent style, like toyota

* typo
setup: add OS version to user agent (#23656)

Honda: minor carState cleanup

Honda: no actuation while in pre-enabled state (#23657)

* Honda: no actuation in pre-enabled state

* Honda: no actuation while in pre-enabled state
No actuation while in pre-enabled state (#23658)

* No actuation while in pre-enabled state

* update refs
Volkswagen: no actuation while pre-enabled

Honda: use common DBC for PILOT and others (#23659)

* use common dbc

* bump

* remove from files common
Honda: fix controls mismatch for stock PCM configs (#23662)

* Honda: fix controls mismatch for stock PCM configs

* ready to remove

* bump panda
don't show registration error on pc

sim: fix bridge after default values removed from CANParser

test car models: fix all panda safety mismatches (#23616)

* remove tolerance

* fix nissan mismatches

* warm up

* remove additional bosch check

* another honda exception

* little more

* Update selfdrive/test/test_models.py
Honda Pilot, Passport, Ridgeline: increase user brake threshold (#23641)

test car models improvements (#23668)

* run on all routes

* min segment length

* invalid

* revert that
Log panda signature to param (#23670)

Toyota: add COROLLA_TSS2 fw (#23661)

* Update values.py

Added Toyota Corolla fingerprint.

* a
controlsd: only add startup event until initialized (#23671)

* controlsd: only add startup event until initialized

* update refs

* update again
update refs

Mazda: alert when LKAS is disabled (#23288)

* Mazda: alert when LKAS is disabled

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update refs

* revert that

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
for those who want to live in the moment

CANParser: remove rest of default values (#23676)

* forgot honda somehow!

* forgot some more signal defaults
Toyota: merge Lexus ESH params into similar vehicles (#23673)

* merge LEXUS_ESH

* min and max of all variants
bump opendbc

manager: kill UI when manager failed to start

Toyota: Add missing LEXUS_RX_TSS2 engine & fwdCamera (#23691)

logcat: include all logs since boot (#23692)

replay: fix pause key doc (#23697)

GM: remove noisy ignition signal (#23698)

* move BUICK_REGAL to dashcamOnly

* bump to master
UI: hide power off button on C3 while onroad (#23689)

* Grey out power button while onroad - comma three only

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
WifiManager: fix crash if no wifi device found (#23701)

radard.py: remove trailing space (#23703)

GM: remove dashcam only cars from cars.md (#23708)

* remove cars in dashcam mode

* Update CARS.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
NEOS 19.1 (#23707)

* NEOS 19.1

* add logging

* new manifest

* prod bucket

Co-authored-by: Comma Device <device@comma.ai>
not sure we want this

remove debug prints

Mazda CX-5 2022 Car port (#23704)

* Mazda CX5 2022 FW

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: No lockout and steer down to zero

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: No dashcam!

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: add to supported cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: stick with 800 max torque for now

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update docs/CARS.md

* Apply suggestions from code review

* Mazda: set car models where needed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: set minSteerSpeed per car

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* unused

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* cleanup

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
add cx5 to release notes

logcatd_android.cc: fix repeating the same messages (#23713)

* fix repeating the same message

* cleanup

* use blocking mode

* check duplicate msg in test
remove trailing whitespaces (#23716)

resolve misc car TODOs

tools: fix segment end index in juggle.py (#23715)

scons: fix duplicate environments with test flag (#23702)

* fix duplicate environments when built with --test

* lib

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Add setUploadLimit method to athena (#23693)

* Add setUploadLimit method to athena

* add comments

* move to hw abstraction layer

* move to hw

* better errors
remove unused int_rnd function (#23717)

* testing

* revert

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
thermald: accept ignition from any panda (#23721)

* ignition from any panda

* more elegant )

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* typo

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Hyundai: add FW for Santa Fe 2022 (#23718)

* Add finger print for Santa Fe 2022 - Vietnamese

* Add trailing commas
small test_models.py speedup

reduce shutdownd CPU usage (#23723)

* reduce shutdownd CPU usage

* sync

Co-authored-by: Comma Device <device@comma.ai>
give calibrationd rt priority (#23725)

athena: add suport for download bandwith setting (#23727)

* athena: add suport for download bandwith setting

* clean ingress rules
AGNOS 4 (#23724)

hide localizerMalfunction alert (#23730)

* hide localizerMalfunction alert

* update ref
athena: specify network type for file uploads (#23687)

* athena: specify network type for file uploads

* add comment

* catch abort transfer

* fix tests

* put athena upload args in dict

* fix defaults

Co-authored-by: Joost Wooning <jwooning@gmail.com>
VW MQB: Volkswagen Caravelle T6.1 (#23735)

* VW MQB: Volkswagen Caravelle T6.1

* autogratitude
ui: configure tethering based on prime type (#23733)

* Store prime type in param

* set tethering metric based on prime type

* update existing connections

* returning zero is fine

* always set

* add callback on activate

* call systemctl

* match server enum

* add delay

* assume field is there

* snake case
script to disable power save

paramsd: fix VehicleModelInvalid errors (#23726)

* bound steerratio, stiffness std

* remove start steer_ratio limits after looking at data

* reduce sf obs noise

* update refs

* update refs

* add comment explaining change
fix UI segfault when starting onroad and receiving radarState before modelV2 (#23739)

handle usb error in reading panda state (#23686)

disable macos CI for now

Honda: fix brake pressed signal (#23683)

* or brake_switch

* remove car exceptions

* Revert "remove car exceptions"

This reverts commit cad6a552aa4a17c69616014d3e9333d30c1fadd3.

* does have ts noise, use updated

* bump panda for tests

* bump

* messsssy draft

* clean up

* clean up

* bump

* CS: process all messages at once, like we do during real openpilot usage

* handle multiple messages updated in one cycle

* bump

* bump

* use less confusing, but equivalent cp.vl

* Update selfdrive/test/test_models.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* no msg

* bump opendbc

* Update selfdrive/car/honda/carstate.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* same test logic

* add brake_switch_prev to class

* need to set previous brake switch when not lagging (most of the time)

* need to compare

* only update previous if updated this cycle

rm

* need to maintain previous active state

* move brake_switch

* bump opendbc

* bump

* bump

* bump

* bump

* bump

* bump

* bump opendbc

* rename

* oops

* bump opendbc

* bump

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
bump panda

GM: Fix noisy brake pressed (#23712)

* GM: Use ECMEngineStatus.Brake_Pressed

* consistent style

* add TODO

* bump panda

bump panda

* it should

* bump panda

Co-authored-by: Jason Shuler <jshuler@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Update RELEASES.md
VW MQB: EPS configuration tool (#23737)

* VW MQB: EPS configuration tool

* a bit more help text

* typo

* Update selfdrive/debug/vw_mqb_config.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/debug/vw_mqb_config.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* better handling of vendor constants

* comment tweak

* more constant clarity

* move help text to argparse

* add parameterization parsing

* refactor param read, skip length byte

* touch up section headers

* removing; low value and acting weird

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Mazda: add 2017 CX-9 firmware (#23742)

bump panda

disable until dos can be reflashed

bump opendbc (#23741)

0.8.13 release notes

fix format

missing optional include (#23749)

improve logging around uploading (#23750)

* improve logging around uploading

* use int

* use raw

* duplicate
athena: expire items after 31 days (#23751)

* athena: expire items after 31 days

* add test
controlsd: Fix Toyota steer angle sensor race condition (#23747)

* fix steer angle race condition

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Resolve conflicts

Resolve conflicts

Resolve conflicts

Add param to unsafeMode

Add param to unsafeMode

Merge branch 'master' into disengage-on-gas
Add param to process replay

Revert "disable until dos can be reflashed"

This reverts commit f231caf1e3d6077deb48931bd1ecd69f33cf6f6e.

unsafe mode: update safety declaration comment (#23753)

* update safety declaration comment

* whoops
Merge branch 'master' into disengage-on-gas
Honda: use common DBC for CRV H and Accord Diesel (#23743)

* bump

* use Accord DBC for CRVH, Civic Diesel

* bump

* bump opendbc
ui: fix onroad transition with active nav (#23757)

update release date

bump panda

nav: handle route responses with duplicate points (#23769)

nav: set settings stack based on uiState.prime_type (#23770)

* nav: set settings stack based on uiState.prime_type

* also show on success
Hyundai: move unused cars to dashcam only (#23767)

* Move OptimaH to dashcamOnly

* Elantra GT also has no users for a year

* Update selfdrive/car/hyundai/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
add thneed optimizer (#23772)

* add thneed optimizer

* local work group opt

* kernels and final mods

* release files

* build system touchups

* fix kernel path, rand inputs for self test

* broken since extra is gone

* update model replay ref

Co-authored-by: Comma Device <device@comma.ai>
bump to 0.8.14

UI: fix power buttons disable logic (#23774)

same check

statsd: fix crash if there is no git repository (#23775)

* fix crash if there is no git repository

* return default

Co-authored-by: Willem Melching <willem.melching@gmail.com>
bump cereal

Longitudinal: add Kf to carParams (#23752)

* sane_kf

* long_kf + cereal

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Snpemodel: Clean up after #23772 (#23780)

* #clean up snpemodel after #23772

* Leave benchmark remove loop
add branch name to startup master alert (#23782)

* add branch name to startup master alert

* still orange

* update refs
keep the new alert consistent for process replay

process replay: fix branch name alert (#23783)

* env is modified after start

* update ref
fix in window for xmonad with SDL2 (#23786)

camerad: adjust CL priority on comma three (#23790)

Co-authored-by: Comma Device <device@comma.ai>
Longitudinal control: interpolate longitudinal plan (#23787)

* interpolate longitudinal actuator delay

rename

* formatting

* interpolate v_target most importantly!

* fix interpolation and rename

* nicer setup

* left in from testing

* update refs
camerad: fast debayer on c2 cameras (#23795)

* fast debayer on c2 dcam

* add casts

* 128 local worksize on HDR debayer, 8 ms -> 3.5 ms

* width instead of saving rgb_width

Co-authored-by: Comma Device <device@comma.ai>
camerad: use open_v4l_by_name_and_index on c2 also (#23794)

* use open_v4l_by_name_and_index on c2 also

* remove open_v4l_by_name_and_index from qcom2
Add missing CAMRYH_TSS2 fwdCamera f/w (#23796)

`@Ty.ler#0303`  2022 Toyota Camry SE Hybrid  DongleID/route 9477a77ffc4e8bd4|2022-02-18--15-40-25
HKG: Add FW for 2019 Veloster (#23756)

* HKG: Add FW for 2019 Veloster

* Add esp FW
bigmodel (#23684)

* Added wide cam vipc client and bigmodel transform logic

* Added wide_frame to ModelState, should still work normally

* Refactored image input into addImage method, should still work normally

* Updated thneed/compile.cc

* Bigmodel, untested: 44f83118-b375-4d4c-ae12-2017124f0cf4/200

* Have to initialize extra buffer in SNPEModel

* Default paramater value in the wrong place I think

* Move USE_EXTRA to SConscript

* New model: 6c34d59a-acc3-4877-84bd-904c10745ba6/250

* move use extra check to runtime, not on C2

* this is always true

* more C2 checks

* log if frames are out of sync

* more logging on no frame

* store in pointer

* print sof

* add sync logic

* log based on sof difference as well

* keep both models

* less assumptions

* define above thneed

* typo

* simplify

* no need for second client is main is already wide

* more comments update

* no optional reference

* more logging to debug lags

* add to release files

* both defines

* New model: 6831a77f-2574-4bfb-8077-79b0972a2771/950

* Path offset no longer relevant

* Remove duplicate execute

* Moved bigmodel back to big_supercombo.dlc

* add wide vipc stream

* Tici must be tici

* Needs state too

* add wide cam support to model replay

* handle syncing better

* ugh, c2

* print that

* handle ecam lag

* skip first one

* so close

* update refs

Co-authored-by: mitchellgoffpc <mitchellgoffpc@gmail.com>
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
add to release notes

paramsd cpu usage has been increasing

boardd: connect to all pandas if none specified (#23805)

Refactor convolutions (#23807)

* one conv with defines

* add conv

* building works on C3

* this is num_outputs too, process replay is so useful

Co-authored-by: Comma Device <device@comma.ai>
cleanup import chaining of T_IDXS (#23806)

bump panda

ui.py: fix model lead plotting

Param to allow upload over cellular (#23811)

* param to allow upload over cellular

* brackets to be consistent

* move outside loop

* fix tests

Co-authored-by: Willem Melching <willem.melching@gmail.com>
longitudinal planner: disable change cost when stopped. not engaged or gas pressed (#23639)

* disable change cost completely on standstill and gas press

* cleanup

* set accel to zero

* clean up logic around standstill

* update ref
onroad_test: increase camerad cpu usage after debayer changes

Update raw_logger/framereader to new new ffmpeg api (#23799)

* Update raw_logger/framereader to new new ffmpeg api

* Can be removed now

* Handled by avcodec_free_context

* handle EAGAIN and clean up
thneed: a few asserts in the optimizer for cases it will fail

docs: fix title typo

cabana for your terminal

Fix tici bigmodel (#23817)

* Fix bigmodel on tici: cam intrinsics arent static

* Give TICI route own name for import

* Make function useable in offline test

* typo

* change tici ecam focal to trained focal

* No shadow variable

* Fixed ref

* Force update this time

* Update model replay ref commit
2022 Hyundai Elantra firmware versions (#23818)

Added 2022 Hyundai Elantra fwdCamera, transmission, and engine fingerprints.
CARS.md add 2022 elantra

hyundai: custom fw version for sonata eps (#23816)

* hyundai: custom fw version for sonata eps

* another comment
HKG: Kia Sorento FPv2 (#23815)

* Replace Kia Sorento FPv1 with FPv2

* keep old fingerprint

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Subaru: add FW for Impreza Limited UDM 2017 (#23802)

* FPv2: Add Subaru Impreza Limited USM 2017

* test_fw_query_on_routes.py: add subaru support

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Fix unmetered upload over cell (fix #23811) (#23820)

omx encoder: move writing into thread (#23771)

* omx encoder: move writing to separate thread

* fix include

* pop

* log buffers sizes

* split copy and write
adjust comma two model timing thresholds after bigmodel

Toyota: fix flaky EV detection (#23825)

script to clear DTCs

move lock clearing to uploader (#23826)

* move lock clearing to uploader

* test case
Honda: revert to button enable on Nidec (#23828)

* Honda: revert to button enable on Nidec

* fix test

* bump panda
Added (Ecu.eps) fingerprint for Hyundai Ioniq EV 2017 (#23823)

fix mac_setup w/ tools+plotjuggler (#23552)

* fix pycurl issue:
* use newer curl backend for pip install
* update lib paths based on brew prefix
* fix cert issue when using pycurl using certifi
* make output setup nicer

* fix linter

* typo

* dont need that actually

* revert

* pipenv in brew

* forgot this

* make brew available on fresh install

* undo

* more undo

* oops

* use sytem curl, but homebrew openssl

Co-authored-by: Willem Melching <willem.melching@gmail.com>
replay: use QCoreApplication (#23831)

scons: use correct brew prefix (#23833)

replay: use VideoToolbox HW decoder on Mac (#23832)

* replay: support VideoToolbox HW decoding

* rename flag

* remove debug assert
Fix watch3 on mac (#23834)

this seems to about what my car converges to (#23836)

boardd: handle missing pandas

Subaru: remove Impreza CAN fingerprints (#23841)

* Subaru: remove Impreza CAN fingerprints

* fix process replay

* update refs
Toyota: remove outdated comment (#23844)

Remove unused MPC_COST_LONG class (#23843)

Subaru: add Ascent FW values (#23848)

bump panda

Merge remote-tracking branch 'upstream/master' into disengage-on-gas

add icon from jozef 🔥

MacOS: ensure 1:1 rendering on HiDPI screens (#23860)

Cython acados and minor (#23835)

* acados_ocp_solver_pyx.pyx: implement get_stats for timings and ints

* long_mpc: use acados timers

* acados_ocp_solver_pyx.pyx: fix dynamics_get

* acados_ocp_solver_pyx.pyx: get statistics

* use acados_ocp_solver_pyx.pyx from commaai/cython2 branch

* acados_ocp_solver_pyx.pyx: implement store_iterate

* acados_ocp_solver_pyx.pyx: implement get_residuals

* acados_ocp_solver_pyx.pyx: fix set() for empty fields

* acados_ocp_solver_pyx.pyx: load_iterate

* cython acados: add print_statistics

* test_following_distance: fix typo

* test_longitudinal: unique names for test maneuvers

* longitudinal MPC: comments for evaluation

* longitudinal MPC: add comments to eval acados residuals

* long_mpc: use qp_solver_cond_N = 1

* long MPC: comments, simplify set_cur_state

* update acados version in build script

* longitudinal mpc: weigh a_change in 1 place only

* update ref

* Update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
update python packages (#23864)

Toyota: fix learning bad offsets for some models (#23810)

* Update carstate.py

* comments

* use initializing

* bump opendbc

* bool

* check both

* bump opendbc

* and on TSS-P the initializing bit isn't set
fix kF value for thermal PI controller (#23871)

Hyundai: add FW versions for 2022 Elantra

Subaru: add FW for 2019 Subaru Impreza (#23873)

* Update values.py

* Update selfdrive/car/subaru/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
HKG: Add FW for 2021 Hyundai Santa Fe (#23858)

Toyota: add Leuxs NX fingerprint (#23808)

HKG: Add FW for 2022 Kia Niro HEV (#23863)

* HKG: Add FW for 2022 Kia Niro HEV

* Expand model year
THNEED_DEBUG env var support

CAN FD support in packer + parser (#23877)

modeld: remove support for small model (#23803)

* modeld: remove support for small model

* use extra
VW MQB: Add FW for 2017 Audi S3 (#23881)

Hyundai: Add FW for 2022 Ioniq Plug-in Hybrid  (#23862)

* Add car port: Hyundai Ioniq Plug-in Hybrid 2022

* minSteerSpeed is 0

* Remove from crc8 checksum

* Add test route

* Revert "Add test route"

This reverts commit a76ddca8889ba1b94a0475c4e5bd4da664c22ddb.

* Revert "Remove from crc8 checksum"

This reverts commit eb2be0a20ca1f7159a671a2b3eebefae3071a77c.

* Revert "minSteerSpeed is 0"

This reverts commit 3f40eba611cf5aeacfcc66b2f77da04a25f7ebdb.

* Revert "Add car port: Hyundai Ioniq Plug-in Hybrid 2022"

This reverts commit f4084989d00733aec039ee04dab4b4246deca542.

* Hyundai: Add FW for 2022 Ioniq Plug-in Hybrid

* Remove IONIQ_PHEV from STEER_MAX = 255

* Add additional FW version
Update Santa Fe 2019 route (#23888)

* new santa fe route, mid-drive to parking lot

* bump
minor cleanups, fix non binary compile (#23882)

Co-authored-by: Comma Device <device@comma.ai>
better steer fault names (#23890)

* better steer fault names

* bump cereal
locationd, paramsd: Check conditions before updating kalman filters (#23789)

* update filters only when all messages are alivbe and valid

* update message valid and fix unit test

* update refs

* move check outside loop

* modify fake message fn in test

* deprecate inputsOK and resolve PR comments

* avoid double looped list comprehension

* follow import conventions

* modify paramsd valid to only be invalid in case of commIssue

* update refs
camerad: log debayer + yuv processing time (#23894)

* camerad: log debayer + yuv processing time

* bump cereal
locationd: fix writing LastGPSPosition interval (#23895)

Fan controller cleanup + testing (#23886)

* clean up fan controllers in preparation for testing

* add fan controller to release

* add some unit tests around the fan controller

* subclass ABC
thermald: use latest modem temps (#23878)

* thermald: use latest modem temps

* move that
Move 2020 Lexus NX 300 fw fingerprints to TSS2 (#23893)

* Revert "Toyota: add Leuxs NX fingerprint (#23808)"

This reverts commit 4f999b44c6a6d54ec499676f5f8019208a59dfd4.

* Add engine and fwRadar fw
model: mse err from 0.02-> 0.000056 (#23891)

* mse err from 0.028070712 -> 5.8073703e-05

* build with weights fixup

* need thneed lib also

* don't break for binaries

* static analysis says i need init

* check the bias

* load_dlc_weights

* nicer scons

* tested scons

* fix static

* pylint issue

* new ref

* a few more asserts

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
remove trivial terminal constraint and associated CasADi generated functions (#23898)

* remove trivial terminal constraint and associated CasADi generated functions

* Update refs

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
Longitudinal MPC set qp tolerance to 1e-3 (#23899)

* initialize solverExecutionTime longitudinal_planner

* test_onroad: improve timing evaluation

* longitudinal MPC: set qp_tol to 1e-3

* update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
LongControl: fix control state oscillation (#23333)

* check if plan is to accelerate or not

* remove comment

* needed to see it

needed to see it

* test logic with Toyota TSS2

* hackily log conditions

* Revert "hackily log conditions"

This reverts commit 7a6b5691e2b982c7a1e3911d980fb7530647affd.

Revert "test logic with Toyota TSS2"

This reverts commit e583d6e3caaa5f5b896165cd7949dfc1caabfd9a.

order

* revert

* fix
controlsd: fix vCruise jumping on pcmCruise cars (#23388)

* clean up v_cruise_kph

fix

fix

* Revert "clean up v_cruise_kph"

This reverts commit 211b5c3dbe073414ef5c39b19d6d2c6e8de2cf0b.

* always update vCruise and don't init if pcmCruise

* revert change

* update refs
Remove KIA_NIRO_HEV_2021 from STEER_MAX = 255 blacklist (#23906)

mac setup: add catch2

VW MQB: Add FW for 2018 Škoda Octavia (#23909)

VW MQB: Add FW for 2020 Volkswagen Jetta (#23908)

VW MQB: Add FW for 2022 Volkswagen Tiguan (#23913)

lower model FCW + stock longitudinal threshold to -1.25m/s^2 (#23915)

modeld: sync based on frame timestamp (#23901)

* sync based on frame ts

* log extra frame id

* ints only

* update ref

* no rounding errors
bump cereal

bump cereal

HKG: Add FW for 2022 Hyundai Santa Fe (#23889)

* 2022 Hyundai Santa Fe fingerprint

* Update selfdrive/car/hyundai/values.py

Co-authored-by: Chris Frank <chrsfr@users.noreply.github.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
UI: remove redundant condition (#23918)

tools: add MultiLogIterator example to readme (#23917)

* update LogReader doc

use MultiLogIterator to read the entire route, get timestamps and deal with exceptions

* bring back the old example

* clean f-strings

* simplify

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Honda: remove redundant steer fault check (#23920)

jenkins: don't rely on SSH params (#23924)

* jenkins: don't rely on SSH param

* better ssh enabling

* fix path

* fix that
Add --dbc argument to plotjuggler (#23919)

* add --dbc argument

* Update tools/plotjuggler/juggle.py

* update readme

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
real can table column header

panda.cc: add panda deep sleep mode(#23911)

* needed for panda deepsleep mode

* add set_deepsleep to panda.cc

* rename to enable_deepsleep

* remove void

* fix value

* bump panda
DM: update wheeltouch timeouts to match EU guidelines (#23925)

* update time to match 15/30

* add ref
Remove void argument (#23928)

bump opendbc

ui: white color define (#23930)

C3: detect metered Android hotspot (#23734)

* C3: detect metered networks

* show in ui

* fix text layout

* bump cereal

* revert ui changes

* set networkMetered

* add athena method

* add metered logging to uploader

* use in athena uploader

* remove param

* use networkmanager properties to set cell to unmetered

* fix indentation

* no need to check

* bump cereal

* review

* bump cereal
build: remove /system/comma (#23937)

Ford: add minEnableSpeed (#23940)

Subaru: add FW for 2019 Subaru Impreza Sport (#23945)

can_print_changes improvements

positional args are nicer

thneed: a more sane way of doing record/debug (#23938)

Co-authored-by: Comma Device <device@comma.ai>
this is pretty nice now

add table support

bump submodules, fix swaglog (#23943)

Upstreamed and update acados (#23927)

* change acados version to finalized PR https://github.com/acados/acados/pull/791

* acados: update include and x86_64 build

* acados: update pyextra

* adapt mpc files to updated acados

* acados buid: clear acados_template and include dir before updating

* update acados again

* acados MPC: only generate solver, building is done via scons

* update acados to latest acados/master

* c3 libs

* c2 libs

* acados scons files: add acados build script as a dependency

* acados scons files: add libacados.so and ocp_nlp_interface.h, build script not in files_common

* update acados

* adapts long & lat MPC file

* update acados reference commit to acados/master

Co-authored-by: Comma Device <device@comma.ai>
camera_qcom2 refactor (#23946)

* convert camerastate to a class

* more refactor

* do the refactor in file

* put that one back

* those changes can wait

* very minor

Co-authored-by: Comma Device <device@comma.ai>
2019+ Avalon: allow stop and go (#23952)

* Avalon actually has SNG

* update readme

* Revert "update readme"

This reverts commit 076561a0578bcc626fd6710bc411330ef13334d4.

* update readme

* fix

* variants as it includes hybrids
add script to receive camerastream supported by camerad

install pre-commit hooks for all submodules

no git in CI

fix pre-commit install when subdirectories don't have a config

cars: remove duplicated cancel logic (#23956)

carControl: add long and lat active fields (#23859)

* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
move pandad to boardd/ (#23958)

bump panda

break up selfdrive.config (#23959)

* break up selfdrive.config

* add to release files

* fix import order
12bit only (#23953)

Co-authored-by: Comma Device <device@comma.ai>
longitudinal MPC: add MAX_T in T_IDXS_LST (#23960)

* longitudinal MPC: add MAX_T in T_IDXS_LST

* update refs

Co-authored-by: KexianShen <shenkexian@gmail.com>
Improve style in drive_helpers (#23962)

Rename RGB vision streams to match YUV streams (#23961)

* Renaming VISION_STREAM_RGB_.. to match yuv names like VISION_STREAM_ROAD
VISION_STREAM_RGB_BACK -> VISION_STREAM_RGB_ROAD
VISION_STREAM_RGB_FRONT -> VISION_STREAM_RGB_DRIVER

* little more

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
thermald: use named thermal zones (#23936)

* thermald: use named thermal zones

* remove print

* and for c2

Co-authored-by: Comma Device <device@comma.ai>
camerastream: update receive.py with some options

cleanup selfdrive/test (#23967)

* move test routes and test_models

* move fingerprints

* little more

* remove that
add parkingBrake to carState (#23968)

* add parkingBrake to carState

* fix gm
Toyota: parking brake state (#23970)

Merge remote-tracking branch 'upstream/master' into disengage-on-gas

locationd: Commissue fix (#23951)

* check allAliveAndValid only at filter init

* revert cereal and bugfix test

* rename filterValid to filterInitialized

* bump cereal

* correct err

* update refs
Honda: fix possible controls mismatch on Nidecs (#23973)

* Honda: fix possible controls mismatch on Nidecs

* bump panda
DM: more precision running on DSP + e2e outputs (#23900)

* update cereal

* run but not use

* log distraction type

* regression scaling

* clean up naming

* add calib buf

* add to header

* fake model

* no calib model

* adjust threshs

* 018a305f

* fix bn

* tweak1

* tweak2

* 0ff2/666

* tweak3

* t4

* t5

* fix out of bound

* skip when replaying old segments

* update ref

* fix onnxmodel

* get calib

* update model replay refs

* up ref
checkout cereal master

Move gas/brake pedal event logic to controlsd (#23850)

* move some state machine logic to controlsd

move some state machine logic to controlsd

* same order

same order

* move unsafeMode up

* disable at standstill

* save last CS

save last CS

* do we need to copy at all?

* don't copy

* rename

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Revert "Update selfdrive/controls/controlsd.py"

This reverts commit 10bb51a0f0ee0d8e2a27c746a0638280a5eaea8a.

* Update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Merge remote-tracking branch 'upstream/master' into disengage-on-gas

this was flipped

stash

should work

these are null checks right now

clean up a bit

Fix controls mismatch on button enable cars + test against panda safety (#23975)

* test models: check button enable cars against panda safety

* gm too

* cleanup
don't read params in car interfaces (#23978)

VW MQB: Add FW for 2021 Volkswagen Jetta (#23979)

Toyota: clean up CarInterface apply function (#23714)

* clean up CarController with intermediate variables only accessed once or twice

* format

* fixes and move frame to CarController
Hyundai: set radarOffCan by radar DBC (#23981)

Add angular rates carcontroller packet (#23980)

* Controlsd: give carcontroller angular rates

* Update cereal

* Needs to be list

* Update refs
Docs: auto-generate supported cars documentation (#23762)

* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Bump cereal

Merge remote-tracking branch 'upstream/master' into disengage-on-gas

send pre-enable state when gas is pressed

formatting and it's out

forgot one

allow gas press

show toggle

revert changes

revert changes

re-run car docs generator

test onroad: better mpc timing prints (#23896)

* initialize solverExecutionTime longitudinal_planner

* test_onroad: improve timing evaluation
bump cereal

onroad UI: show negative speed (#23987)

* show negative speed

* remove ()
CARS.md tweaks (#23983)

* CARS.md fixups

* wrong one

* sort footnotes

* Mazda CX-9 has good torque

* Try this

* generate

* yup, os uses native filesystem order
update references to CARS.md and routes.py (#23993)

Update carla script to easier install docker and nvidia-docker (#23986)

* Easier docker and nvidia-docker install in carla script

* Small cleanup

* cleanuo

* cleanup

* More comments

* Remove adding usergroup step
Hyundai: send driver override state when gas is pressed (#23745)

* send pre-enable state when gas is pressed

formatting and it's out

forgot one

allow gas press

show toggle

revert changes

revert changes

* revert change
camerad: imx390 support (#23966)

* something is output

* min stuff

* visible picture

* pics look good

* maybe

* whole sensor

* fix all cameras

* support both cameras

* autoexposure for imx390

* fix imx390 blacklevel

* touchups

* put gain in db scale

* inline and fix max exposure

Co-authored-by: Comma Device <device@comma.ai>
Nissan + Tesla: fix controls mismatch on blocked msg (#23994)

* Nissan + Tesla: fix controls mismatch on blocked msg

* bump panda
cars: cleanup CS usage (#23957)

plotjuggle: add blockedCnt to controls mismatch debug layout

Car ports: update PR template (#23996)

* update text for docs generator

* use docs.py

* Update .github/pull_request_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Revert "send pre-enable state when gas is pressed"

This reverts commit 8d82e697dc2efade307413e767d14b56b4d2d079.

Merge remote-tracking branch 'upstream/master' into disengage-on-gas

Honda: clean up CarInterface.apply and CarController (#23876)

* clean up honda/carcontroller

* indentation

* fixes

* clean up apply function

clean up apply function
Hyundai: clean up CarInterface apply function (#24000)

* clean up Hyundai CarController

* remove
Toyota: Support Avalon Hybrid 2022 (TSS2.5) (#23892)

* Add Avalon Hybrid 2022

* update docs

* set a tune

* add test route

* uploaded route
Support Toyota Alphard Hybrid 2021 (#24003)

* add 2021 Alphard Hybrid

revert

* fix fp name

* run docs generator

* Add to releases

* test route

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Mazda: no steer unavailable alert for cars with full range steering (#23998)

* allow steer if minSteerSpeed is <= 0

* need to understand lkas_blocked, can we just use that?

need to understand lkas_blocked, can we just use that?

* Revert "need to understand lkas_blocked, can we just use that?"

This reverts commit 8793fb562d6ba41ce4fd8c8e8a974d639e98f79b.

* better

* fix

* little more clear

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
replay: fix wrong format code in print (#24006)

Add warning for unsupported NVME (#23972)

* Add warning for unsupported NVME

* fix it up

* fix typo

Co-authored-by: Comma Device <device@comma.ai>
Sanitize IP zookeeper/enable_and_wait.py (#24007)

* Sanitize IP zookeeper/enable_and_wait.py

* Fixed Identation

* Fixed Gaierror
skip test models in unittest discovery

cleanup tici_init in launch script

calibrationd: remove unused arg in function (#24004)

camerad: set QCOM CL perf hint (#23791)

Co-authored-by: Comma Device <device@comma.ai>
update tesla ap2 fingerprint after OTA update (#24013)

Revert "camerad: set QCOM CL perf hint (#23791)"

This reverts commit b079475ad3045300b26db54924f0c3db3e2e06d8.

Ignore BrokenPipeError

Tesla: disable temp fault on hands on error (#24014)

plotjuggler: add lag debugging layout

Apply EU guideline lateral limits (#23974)

* Apply EU limits

* Lower bound v_ego

* Add curvature limit comment

* Remove comment

* Update ref
calibrationd: add function typing (#24018)

deleter: handle files (#24023)

set MANAGER_DAEMON for boardd

docs: support for automatically generating website vehicles page (#24020)

* add vehicles.vue template

* add original vue file

* stash

* stash

* clean up a bit

* add template for now

* implement footnotes and tier copy

* no more generator

* convert to 2 spaces

* should work, now onto vue

* does GH handle this html well?

* fix

* auto-generate descriptions and make tiers' maps non-str

* remove old files

* move template specific variable into templates, should be a bit simpler

* js template is simplier too now

js template is simplier too now

js template is simplier too now

* add video links from the nice car_info

* make rows attributes

* clean up

* fix

* remove template

* experiment with video links in GH

add image

how does this look?

fix

* Revert "experiment with video links in GH"

This reverts commit 8375e717b563f7b4ecf009ffae00174de1a0b8e9.

* sort tier_car_info in place

* unused Tuple

* no type check

* fix script
test models: skip with flag

Honda Nidec: don't actuate while longitudinal is inactive (#24028)

* don't command any pcm_speed when long is not active

* update refs
Merge remote-tracking branch 'upstream/master' into disengage-on-gas

Bump panda

update unsafeMode to alternativeExperience (#23995)

* update unsafeMode to alternativeExperience

* fix

* fix

* bump submodules

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Merge remote-tracking branch 'upstream/master' into disengage-on-gas

these changes will be in border PR

these changes will be border PR

⛽ ➡️ 🔋

bump

test onroad: CPU usage test improvements (#24035)

* test onroad: CPU usage test improvements

* remove those
update SAFETY.md

sensord: add support for Quectel raw gps (#24027)

* connecting to rawgps

* dumping rawfps packets

* this works, but it might be useless

* fix parsing

* parsing 0x1476

* compare

* compare better

* refactoring

* parsing and broadcasting GPS packet

* glonass support

* compare using submaster

* fix compare for glonass

* update cereal

* make linter happy

* other linter issue

* last mypy complaints

* add support for publishing gpsLocationExternal

* set flags to 1 to match ubloxd

* ready to ship

* qcomdiag

* use unused variables

* last one

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
pylint: enforce indentation (W0311) (#24039)

* pylint: enforce indentation (W0311)

* few more
CARLA: fix setting camera EOF (#24034)

* Fix Openpilot in Carla isn't accelerating

The scalars of the timestamp are different in real-world and simulation,
which will cause an infinite loop in selfdrive/modeld/modeld.cc.

* Set eof based on the frame ID

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* remove global

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
bunch of gpu config (#23932)

Co-authored-by: Comma Device <device@comma.ai>
ui: repaint toggles after offroadTransition (#24038)

* repaint after offroadTransition

* Update selfdrive/ui/qt/widgets/controls.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
UI: better lag logging (#24042)

* UI: better lag logging

* remove print
sim: add ignition toggling (#24043)

Training guide updates (#24033)

* add new images

* update boxes

* copy updates and fix checkmark spacing

* update wide images and boxes

* tune path and smaller triangle

* tune bounding boxes

* clean up

* same triangle as c3

* revert panda

* optimize images

* Revert "revert panda"

This reverts commit f66aac85a01135d68d0c51ad4c383b7cd23ef86f.

* add comment

* add new step18

* final fixes

* pixel perfect
Update README.md
CarParams: remove max steer (#24044)

* Remove max steer

* Update ref
bump cereal

HKG: Add FW for 2020 Genesis G70 (#24045)

bump laika

MultiLogIterator: add function to reset

bump cereal

VW MQB: Add FW for 2018 Volkswagen Arteon (#24050)

VW MQB: Add FW for 2019 Volkswagen Golf (#24051)

HKG: Add FW for 2022 Hyundai Santa Fe PHEV (#24048)

Add missing CAMRYH_TSS2 fwdRadar (#24047)

`@SloshyZebra#8815` 2022 Toyota Camry Hybrid  DongleID/route 34c6eea208b2f059|2022-03-26--13-14-41
controlsd: no cruise speed while main off (#24052)

* controlsd: no cruise speed while main off

* probably more accurate

* update refs
Add sample metric type to statsd (#23557)

* add sample stat, and make current power draw work on eon/c2

* fix power monitoring test

* little cleanup

* add type hinting to dict

* save as different values

* duh

* rip out power stat

* small fix

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* cleanup this too

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Merge remote-tracking branch 'upstream/master' into disengage-on-gas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants