Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Car Port for Ioniq 5 (HDA2) 2022 #25308

Merged
merged 14 commits into from
Aug 12, 2022

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Jul 29, 2022

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: 22de8111a8c5463c|2022-07-29--13-34-49
  • harness type: Hyundai P Hyundai K (modified)
    • HDA2 specific: User had to modify the harness to flip the can bus pairs in order to successfully intercept the LKAS (0x50) steering message

Physical setup

  • Top port behind comma three
    • comma Power <-> First Harness Box <-> comma three USB C/Right-Angle C <-> comma three
  • Bottom port behind comma three
    • Camera Harness <-> Second Harness Box <-> USB C/C 3.1 <-> Red Panda <-> USB A/A <-> USB A to C OTG Adapter <-> comma three

Thanks to community Ioniq 5 owner spectre3ooo and G80Tampa.

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jul 30, 2022

Do disengage on gas and resume spam both work? I know that LFA isn't properly blocked on the Ioniq 5. I would first try sending zero's for all the bytes in CAM_0x2A4.

camera_values.update({

@sunnyhaibin
Copy link
Contributor Author

Do disengage on gos and resume spam both work? I know that LFA isn't properly blocked on the Ioniq 5. I would first try sending zero's for all the bytes in CAM_0x2A4.

camera_values.update({

User mentioned disengage on accelerator sometimes would work but inconsistent.

@sunnyhaibin sunnyhaibin marked this pull request as ready for review August 11, 2022 15:24
@adeebshihadeh
Copy link
Contributor

User mentioned disengage on accelerator sometimes would work but inconsistent.

Discussed with our two uses on Discord, and they're reporting both gas disengage and LFA blocking work as expected now.

@adeebshihadeh
Copy link
Contributor

Congrats on #200 @sunnyhaibin!

@adeebshihadeh adeebshihadeh merged commit 6e2584e into commaai:master Aug 12, 2022
@sunnyhaibin sunnyhaibin deleted the ioniq-5-2022-port branch August 24, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants