UI: connect to wifi prompt #28273
Merged
UI: connect to wifi prompt #28273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
incognitojam
commented
May 23, 2023
•
incognitojam
commented
- move PrimeAd to left column, replacing DriveStats when user is not subscribed to prime (expected to be replaced by the MapPanel in UI: easier nav destination entry #27629)
- shrink comma prime widget
- add "Setup Wi-Fi" widget
- switch between setup/uploading using network state
| New | Old | |
|---|---|---|
| Unpaired |  |
 |
| No prime (Wi-Fi) |  |
 |
| No prime (No Wi-Fi) |  |
|
| Prime |  |
 |
| Prime (No Wi-Fi) |  |
incognitojam
force-pushed
the
homescreen-map
branch
from
073a1f9
to
d4a8727
Compare
incognitojam
force-pushed
the
homescreen-map
branch
4 times, most recently
from
e4cab7a
to
210d502
Compare
incognitojam
force-pushed
the
homescreen-map
branch
from
210d502
to
e08b707
Compare
incognitojam
force-pushed
the
wifi-prompt
branch
3 times, most recently
from
f242898
to
c574067
Compare
incognitojam
force-pushed
the
homescreen-map
branch
from
e08b707
to
633787f
Compare
incognitojam
force-pushed
the
wifi-prompt
branch
3 times, most recently
from
f054db6
to
9f601bf
Compare
|
Did you try making the button expand to fill the width like the pair button? Also looks like some stuff is left aligned vs. centered |
|
Like this? |
incognitojam
force-pushed
the
wifi-prompt
branch
3 times, most recently
from
0c00932
to
c1c7d5a
Compare
incognitojam
force-pushed
the
wifi-prompt
branch
3 times, most recently
from
8cab22a
to
c53d7e2
Compare
incognitojam
commented
Jun 1, 2023
sshane
reviewed
Jun 3, 2023
| title_layout->addStretch(); | ||
|
|
||
| QLabel *icon = new QLabel; | ||
| QPixmap *pixmap = new QPixmap("../assets/offroad/icon_wifi_uploading.svg"); |
There was a problem hiding this comment.
should add to assets.qrc and use ASSETS_PATH. this doesn't work if you're not in selfdrive/ui, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.