Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyundai: clean up FW queries #32022

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Hyundai: clean up FW queries #32022

merged 11 commits into from
Mar 27, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Mar 27, 2024 •
edited
Loading

Enabled by: #31985 (removal of engine and transmission), #32020, #32019, #32008

  • combine explicit CAN camera logging queries (that shouldn't be logging because we are starting to rely on them) with the CAN FD camera queries (that are also getting queried on CAN vehicles)
  • remove whitelists. this was causing more complications than the minor amount of time they could be saving. will re-evaluate in the future now that we have less ECUs (no trans or engine)
  • remove the MULTI query. neither fwdRadar, fwdCamera, abs, or eps don't support the simpler LONG query with the platform code at the start. the MULTI query just has redundant part number at the start, nothing new generally (except engine and trans)

@github-actions github-actions bot added car vehicle-specific hyundai labels Mar 27, 2024
@sshane sshane merged commit 1306edd into master Mar 27, 2024
5 checks passed
@sshane sshane deleted the cleanup-hkg-requests branch March 27, 2024 03:49
@sshane sshane mentioned this pull request Apr 17, 2024
Closed
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
@sshane @cydia2020
Hyundai: clean up FW queries (commaai#32022)
8ae1d57 
* mark MULTI as logging

* rm whitelists

* rm MULTI

* major clean up :D

* faster refs :D

* wow this was a broken test (can fd can be without aux, and this allowed eps)

* expected

* only for camera (needs test change)

* Revert "only for camera (needs test change)"

This reverts commit 6156bcd.

* better msg

* yes we do
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car vehicle-specific cleanup fingerprint hyundai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sshane