Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker environment breaking #369

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Docker environment breaking #369

merged 2 commits into from
Sep 20, 2018

Conversation

energee
Copy link
Contributor

@energee energee commented Sep 19, 2018

Latest version of matplotlib is now 3.0.0 and requires Python 3.5 so needed to declare version number:

 ---> Running in b5822357e618
Collecting numpy==1.11.2
  Downloading https://files.pythonhosted.org/packages/5e/d5/3433e015f3e4a1f309dbb110e8557947f68887fe9b8438d50a4b7790a954/numpy-1.11.2-cp27-cp27mu-manylinux1_x86_64.whl (15.3MB)
Collecting scipy==0.18.1
  Downloading https://files.pythonhosted.org/packages/13/cb/8e74d28e1519b34636e4d985d49d01c23778064e01eb102914f844cd6051/scipy-0.18.1-cp27-cp27mu-manylinux1_x86_64.whl (40.3MB)
Collecting matplotlib
  Downloading https://files.pythonhosted.org/packages/ec/06/def4fb2620cbe671ba0cb6462cbd8653fbffa4acd87d6d572659e7c71c13/matplotlib-3.0.0.tar.gz (36.3MB)
    Complete output from command python setup.py egg_info:
    
    Matplotlib 3.0+ does not support Python 2.x, 3.0, 3.1, 3.2, 3.3, or 3.4.
    Beginning with Matplotlib 3.0, Python 3.5 and above is required.
    
    This may be due to an out of date pip.
    
    Make sure you have pip >= 9.0.1.```

rbiasini
rbiasini reviewed Sep 19, 2018
View reviewed changes
Dockerfile.openpilot Outdated
@@ -2,7 +2,7 @@ FROM ubuntu:16.04
ENV PYTHONUNBUFFERED 1

RUN apt-get update && apt-get install -y build-essential clang vim screen wget bzip2 git libglib2.0-0 python-pip capnproto libcapnp-dev libzmq5-dev libffi-dev libusb-1.0-0
RUN pip install numpy==1.11.2 scipy==0.18.1 matplotlib
RUN pip install numpy==1.11.2 scipy==0.18.1 matplotlib==2.2.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1.2 is what's used by our docker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What me to change to 2.1.2? I pulled 2.2.3 from latest successful build.

Collecting matplotlib Downloading https://files.pythonhosted.org/packages/59/08/04933377dc4500e3698e93f9113dc3624874e0914f4c85767ecb5b389084/matplotlib-2.2.3-cp27-cp27mu-manylinux1_x86_64.whl (12.6MB)

@rbiasini
Copy link
Contributor

thanks!

@rbiasini rbiasini merged commit 402faab into commaai:devel Sep 20, 2018
DavidWAbrahams pushed a commit to jeankalud/openpilot that referenced this pull request Sep 26, 2018
OP 0.5.4
5fd6b81 
Squashed commit of the following:

commit 1391e0c
Merge: 5b53cd4 a422246
Author: David Abrahams <you@example.com>
Date:   Wed Sep 26 04:52:42 2018 +0000

    Merge remote-tracking branch 'op/devel' 0.5.4 into cruise_devel

commit a422246
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:13:41 2018 -0700

    openpilot v0.5.4 release

commit e5b2ec4
Merge: 97f1ee4 906b55a
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:04:00 2018 -0700

    Merge opendbc subtree

commit 906b55a
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:04:00 2018 -0700

    Squashed 'opendbc/' changes from af7fff8..42f8c12

    42f8c12 Adds Chinese Odyssey DBC (commaai#110)
    7b87882 Syntax and encoding fixes (commaai#111)
    f85e646 Update mercedes e350 dbc (commaai#112)

    git-subtree-dir: opendbc
    git-subtree-split: 42f8c12

commit 97f1ee4
Merge: 2d450bc 5c0935d
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:03:58 2018 -0700

    Merge panda subtree

commit 5c0935d
Author: Vehicle Researcher <user@comma.ai>
Date:   Tue Sep 25 00:03:58 2018 -0700

    Squashed 'panda/' changes from f2292e4..5253ab0

    5253ab0 bump panda
    6277139 GM Volt: allowing 300 max steer
    63b7926 Hyundai safety: temporarily disabled button spam check to avoid camera faults
    53aef76 GM: passive on LKA-only cars (commaai#135)
    01b5235 bumped panda version
    1c0ffd1 Hyundai safety: simplifications
    56794d6 Hyundai Safety Auto-Detect which CAN bus Camera is on (commaai#134)

    git-subtree-dir: panda
    git-subtree-split: 5253ab0

commit 2d450bc
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date:   Fri Sep 21 19:41:44 2018 -0700

    Increase Volt's steering limit (commaai#351)

    * Increase Volt's steering limit

    * Merge panda subtree

commit 96c9238
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date:   Fri Sep 21 19:40:52 2018 -0700

    GM refactor (commaai#374)

commit 5b53cd4
Author: David Abrahams <you@example.com>
Date:   Fri Sep 21 03:17:44 2018 +0000

    ACC: syntax fix

commit d1d642e
Author: David Abrahams <you@example.com>
Date:   Fri Sep 21 03:15:49 2018 +0000

    ACC: Syntax fix

commit f5d3e51
Author: David Abrahams <you@example.com>
Date:   Fri Sep 21 00:15:57 2018 +0000

    ACC: If disabled, disengage traditional cruise control

commit 5ad11b2
Author: David Abrahams <you@example.com>
Date:   Thu Sep 20 23:30:29 2018 +0000

    ACC: disable on brakes or slowing below min speed

commit 14b7ead
Author: wocsor <37704329+wocsor@users.noreply.github.com>
Date:   Thu Sep 20 19:06:15 2018 -0400

    Add XSE trim to fingerprints (commaai#372)

commit 402faab
Author: Ted Slesinski <ted@slesinski.org>
Date:   Wed Sep 19 20:59:18 2018 -0400

    Docker environment breaking (commaai#369)

    * Fixes matplotlib dependency

    * Use version 2.1.2

commit d56e44b
Author: David Abrahams <you@example.com>
Date:   Wed Sep 19 18:06:44 2018 +0000

    ACC: Don't auto-engage if vRel < 0

commit d359f70
Author: David Abrahams <you@example.com>
Date:   Wed Sep 19 17:08:03 2018 +0000

    ACC: Don't autoresume if there is a slow car in front

commit de79a07
Author: Ted Slesinski <ted@slesinski.org>
Date:   Tue Sep 18 00:39:58 2018 -0400

    Add support for accord hybrid (commaai#361)

commit 4b2c137
Author: wocsor <37704329+wocsor@users.noreply.github.com>
Date:   Mon Sep 17 16:24:52 2018 -0400

    update CHR fingerprint (commaai#364)

    CHR 2016 fingerprint has more messages
klaus385 pushed a commit to klaus385/openpilot that referenced this pull request Dec 31, 2018
@energee @klaus385
Docker environment breaking (commaai#369)
7e10fd3 
* Fixes matplotlib dependency

* Use version 2.1.2
icmma pushed a commit to priuscom/openpilot that referenced this pull request Jun 16, 2019
@arne182
Merge pull request commaai#369 from arne182/priusblinker
410c1a5 
Priusblinker confrimed working by @pratik
dragonpilot pushed a commit to dragonpilot-community/dragonpilot that referenced this pull request Apr 7, 2020
@energee @rbiasini
Docker environment breaking (commaai#369)
45a1830 
* Fixes matplotlib dependency

* Use version 2.1.2
SebastienLubrano pushed a commit to SebastienLubrano/openpilot that referenced this pull request Jul 8, 2021
@sshane
Nudge speed (commaai#369)
11e6381 
* Add param to change the speed at which a nudge is not required.

* Update description

* Update description

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbiasini rbiasini rbiasini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@energee @rbiasini