Increase Volt's steering limit #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my worries is that increasing the allowed steering torque would violate safety limits. Looking at the turn that requires max torque might help to understand if the increased torque is still within the safe zone. |
|
Going through a turn with steering 300, at about 53 mph: |
|
@vntarasov , still happy with 300? |
|
@rbiasini, 300 works great! |
|
Been using this for a long time without problems. Regarding the issue when not being able to program the Panda, wouldn’t it make sense to have a some version check between Openpilot and Panda ? Could generate an error similar to a “Control Mismatch” |
|
@TheMutley would be hard to develop with that I think. let me think about it. |
|
@vntarasov this PR also need the panda FW change btw, with version bump so the auto FW re-flash happens. |
vntarasov
force-pushed
the
gm-steer-limit
branch
from
325ca21
to
1dd61c9
Compare
|
@rbiasini Thanks, done! |
DavidWAbrahams
pushed a commit
to jeankalud/openpilot
that referenced
this pull request
Sep 26, 2018
Squashed commit of the following: commit 1391e0c Merge: 5b53cd4 a422246 Author: David Abrahams <you@example.com> Date: Wed Sep 26 04:52:42 2018 +0000 Merge remote-tracking branch 'op/devel' 0.5.4 into cruise_devel commit a422246 Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:13:41 2018 -0700 openpilot v0.5.4 release commit e5b2ec4 Merge: 97f1ee4 906b55a Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:04:00 2018 -0700 Merge opendbc subtree commit 906b55a Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:04:00 2018 -0700 Squashed 'opendbc/' changes from af7fff8..42f8c12 42f8c12 Adds Chinese Odyssey DBC (commaai#110) 7b87882 Syntax and encoding fixes (commaai#111) f85e646 Update mercedes e350 dbc (commaai#112) git-subtree-dir: opendbc git-subtree-split: 42f8c12 commit 97f1ee4 Merge: 2d450bc 5c0935d Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:03:58 2018 -0700 Merge panda subtree commit 5c0935d Author: Vehicle Researcher <user@comma.ai> Date: Tue Sep 25 00:03:58 2018 -0700 Squashed 'panda/' changes from f2292e4..5253ab0 5253ab0 bump panda 6277139 GM Volt: allowing 300 max steer 63b7926 Hyundai safety: temporarily disabled button spam check to avoid camera faults 53aef76 GM: passive on LKA-only cars (commaai#135) 01b5235 bumped panda version 1c0ffd1 Hyundai safety: simplifications 56794d6 Hyundai Safety Auto-Detect which CAN bus Camera is on (commaai#134) git-subtree-dir: panda git-subtree-split: 5253ab0 commit 2d450bc Author: Vasily Tarasov <vtarasov@zoneos.com> Date: Fri Sep 21 19:41:44 2018 -0700 Increase Volt's steering limit (commaai#351) * Increase Volt's steering limit * Merge panda subtree commit 96c9238 Author: Vasily Tarasov <vtarasov@zoneos.com> Date: Fri Sep 21 19:40:52 2018 -0700 GM refactor (commaai#374) commit 5b53cd4 Author: David Abrahams <you@example.com> Date: Fri Sep 21 03:17:44 2018 +0000 ACC: syntax fix commit d1d642e Author: David Abrahams <you@example.com> Date: Fri Sep 21 03:15:49 2018 +0000 ACC: Syntax fix commit f5d3e51 Author: David Abrahams <you@example.com> Date: Fri Sep 21 00:15:57 2018 +0000 ACC: If disabled, disengage traditional cruise control commit 5ad11b2 Author: David Abrahams <you@example.com> Date: Thu Sep 20 23:30:29 2018 +0000 ACC: disable on brakes or slowing below min speed commit 14b7ead Author: wocsor <37704329+wocsor@users.noreply.github.com> Date: Thu Sep 20 19:06:15 2018 -0400 Add XSE trim to fingerprints (commaai#372) commit 402faab Author: Ted Slesinski <ted@slesinski.org> Date: Wed Sep 19 20:59:18 2018 -0400 Docker environment breaking (commaai#369) * Fixes matplotlib dependency * Use version 2.1.2 commit d56e44b Author: David Abrahams <you@example.com> Date: Wed Sep 19 18:06:44 2018 +0000 ACC: Don't auto-engage if vRel < 0 commit d359f70 Author: David Abrahams <you@example.com> Date: Wed Sep 19 17:08:03 2018 +0000 ACC: Don't autoresume if there is a slow car in front commit de79a07 Author: Ted Slesinski <ted@slesinski.org> Date: Tue Sep 18 00:39:58 2018 -0400 Add support for accord hybrid (commaai#361) commit 4b2c137 Author: wocsor <37704329+wocsor@users.noreply.github.com> Date: Mon Sep 17 16:24:52 2018 -0400 update CHR fingerprint (commaai#364) CHR 2016 fingerprint has more messages
klaus385
pushed a commit
to klaus385/openpilot
that referenced
this pull request
Dec 31, 2018
* Increase Volt's steering limit * Merge panda subtree
rav4kumar
pushed a commit
to rav4kumar/openpilot
that referenced
this pull request
May 27, 2019
Replace 058 long mpc with 0512
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
* Increase Volt's steering limit * Merge panda subtree
Ray5609
pushed a commit
to Ray5609/openpilot
that referenced
this pull request
Mar 27, 2021
* debug * run * debug * debug * debug * debug * debug * debug * debug * debug * don't import if already imported * fix * debug * debug * debug * update put * update put * update put * update put * update put * update put * update put * update put * update put * debug * debug * debug * debug * clean up * clean up * safety for reading * Rename live to not static * Fixup opEdit for static params * debug * change to static * Add msg * Revert * Debug * Right in the middle * Clean up * Clean up * Clean up * debug * clean up * clean up * debug * debug * debug * clean up * More params are live now * Use travis again * Quicker * Make read frequency a Param class attr * replace self._last_read_times with param class attr * rm reference * Add msg * Add msg * Don't show this * Only show live params in live mode * debug * live defaults to false * update msg * Reenable default live params in menu * remove redundant argument pass * Simplify importing old params * Revert rate changes * Make static * Update releases * Update features * Update README.md * These params now update with ignition * Use basedir * Can get rid of travis * Windows friendly, write file when imported * Update documentation * Can create its own instance without much issue * Update msg * Update msg * don't lie lol * Color * Color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires commaai/panda#136.
Anything more than 300 will generate SCM faults, meaning steering would be lost for a split second. 300 can be applied without a fault (see screenshot).