calibration improvements and devel synch up #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a noop for most users, but for those of us working on new car ports where we have our own additional defines, having those defines out of sync creates merge conflicts in one place (good so we can fix it) but not the other ( not good becasue they will go unnoticed). I learned this the hardway!. Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* use solve and eye func * remove uneeded import from vehicle model
Tuned kP and kI and Tire Stiffness Factor settings. Fixes lane centering issues in the following situations: 1. Hugging of left lane line during fast left curving roads 2. Hugging of right lane line during fast right curving roads 3. Left bias in fast lane on crowned roads (sloping down to the left) 4. Right bias in slow lane on crowned roads (sloping down to the right) Works better when lane_width = 2.85 (vs 3.7 default) in pathplanner.py
Confirmed working on 2017-2018 Chinese RAV4 by @fiftycentsjj
* separable filter * add missing args * formatting * fix casing
This came after testing a different trim level. This fingerprint is confirmed working on both.
* more stable calibration * no commented print
@squall and me have checked the dsu static values for our RAV4H and found that this is similar to the highlander message.
rbiasini
changed the title
rav4kumar
pushed a commit
to rav4kumar/openpilot
that referenced
this pull request
Sep 21, 2019
fix wrong addr
mlocoteta
pushed a commit
to mlocoteta/openpilot
that referenced
this pull request
Aug 7, 2021
* fix test * fix variable
cfranyota
pushed a commit
to cfranyota/openpilot
that referenced
this pull request
Aug 8, 2021
* fix test * fix variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.